* [PATCH] powerpc/64: fix debugfs_simple_attr.cocci warnings
2021-04-09 16:15 [linux-next:master 11082/11648] arch/powerpc/kernel/security.c:807:0-23: WARNING: fops_entry_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE kernel test robot
@ 2021-04-09 16:15 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-09 16:15 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3595 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Michael Ellerman <mpe@ellerman.id.au>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Nicholas Piggin <npiggin@gmail.com>
CC: Jordan Niethe <jniethe5@gmail.com>
CC: Alistair Popple <alistair@popple.id.au>
CC: Gustavo Walbon <gwalbon@linux.ibm.com>
CC: linuxppc-dev(a)lists.ozlabs.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
arch/powerpc/kernel/security.c:807:0-23: WARNING: fops_entry_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE
arch/powerpc/kernel/security.c:781:0-23: WARNING: fops_rfi_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE
arch/powerpc/kernel/security.c:833:0-23: WARNING: fops_uaccess_flush should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Fixes: c6b4c9147f8b ("powerpc/64: Move security code into security.c")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e99d8a8495175df8cb8b739f8cf9b0fc9d0cd3b5
commit: c6b4c9147f8b85d159f670d7bce71a93d16062a2 [11082/11648] powerpc/64: Move security code into security.c
:::::: branch date: 5 hours ago
:::::: commit date: 29 hours ago
Please take the patch only if it's a positive warning. Thanks!
security.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
--- a/arch/powerpc/kernel/security.c
+++ b/arch/powerpc/kernel/security.c
@@ -778,7 +778,8 @@ static int rfi_flush_get(void *data, u64
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(fops_rfi_flush, rfi_flush_get, rfi_flush_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_rfi_flush, rfi_flush_get, rfi_flush_set,
+ "%llu\n");
static int entry_flush_set(void *data, u64 val)
{
@@ -804,7 +805,8 @@ static int entry_flush_get(void *data, u
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(fops_entry_flush, entry_flush_get, entry_flush_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_entry_flush, entry_flush_get, entry_flush_set,
+ "%llu\n");
static int uaccess_flush_set(void *data, u64 val)
{
@@ -830,13 +832,18 @@ static int uaccess_flush_get(void *data,
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(fops_uaccess_flush, uaccess_flush_get, uaccess_flush_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_uaccess_flush, uaccess_flush_get,
+ uaccess_flush_set, "%llu\n");
static __init int rfi_flush_debugfs_init(void)
{
- debugfs_create_file("rfi_flush", 0600, powerpc_debugfs_root, NULL, &fops_rfi_flush);
- debugfs_create_file("entry_flush", 0600, powerpc_debugfs_root, NULL, &fops_entry_flush);
- debugfs_create_file("uaccess_flush", 0600, powerpc_debugfs_root, NULL, &fops_uaccess_flush);
+ debugfs_create_file_unsafe("rfi_flush", 0600, powerpc_debugfs_root,
+ NULL, &fops_rfi_flush);
+ debugfs_create_file_unsafe("entry_flush", 0600, powerpc_debugfs_root,
+ NULL, &fops_entry_flush);
+ debugfs_create_file_unsafe("uaccess_flush", 0600,
+ powerpc_debugfs_root, NULL,
+ &fops_uaccess_flush);
return 0;
}
device_initcall(rfi_flush_debugfs_init);
^ permalink raw reply [flat|nested] 2+ messages in thread