All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
Date: Sun, 11 Apr 2021 09:51:49 +0800	[thread overview]
Message-ID: <202104110946.xGfNWLoV-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Ravi Patel <ravi.patel@xilinx.com>
CC: Rajan Vaja <rajan.vaja@xilinx.com>
CC: Arnd Bergmann <arnd@arndb.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   52e44129fba5cfc4e351fdb5e45849afc74d9a53
commit: acfdd18591eaac25446e976a0c0d190f8b3dbfb1 firmware: xilinx: Use hash-table for api feature check
date:   5 months ago
:::::: branch date: 6 hours ago
:::::: commit date: 5 months ago
config: arm64-randconfig-m031-20210411 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'

vim +/feature_data +1288 drivers/firmware/xilinx/zynqmp.c

76582671eb5d00 Rajan Vaja        2018-09-12  1279  
76582671eb5d00 Rajan Vaja        2018-09-12  1280  static int zynqmp_firmware_remove(struct platform_device *pdev)
76582671eb5d00 Rajan Vaja        2018-09-12  1281  {
acfdd18591eaac Amit Sunil Dhamne 2020-11-23  1282  	struct pm_api_feature_data *feature_data;
acfdd18591eaac Amit Sunil Dhamne 2020-11-23  1283  	int i;
acfdd18591eaac Amit Sunil Dhamne 2020-11-23  1284  
e23d9c6d0d4912 Jolly Shah        2019-02-01  1285  	mfd_remove_devices(&pdev->dev);
b321725257c173 Rajan Vaja        2018-09-12  1286  	zynqmp_pm_api_debugfs_exit();
b321725257c173 Rajan Vaja        2018-09-12  1287  
acfdd18591eaac Amit Sunil Dhamne 2020-11-23 @1288  	hash_for_each(pm_api_features_map, i, feature_data, hentry) {
acfdd18591eaac Amit Sunil Dhamne 2020-11-23  1289  		hash_del(&feature_data->hentry);
acfdd18591eaac Amit Sunil Dhamne 2020-11-23  1290  		kfree(feature_data);
acfdd18591eaac Amit Sunil Dhamne 2020-11-23  1291  	}
acfdd18591eaac Amit Sunil Dhamne 2020-11-23  1292  
76582671eb5d00 Rajan Vaja        2018-09-12  1293  	return 0;
76582671eb5d00 Rajan Vaja        2018-09-12  1294  }
76582671eb5d00 Rajan Vaja        2018-09-12  1295  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31879 bytes --]

             reply	other threads:[~2021-04-11  1:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11  1:51 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-01-11 10:43 drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data' Dan Carpenter
2021-01-11 10:43 ` Dan Carpenter
2021-01-11 10:43 ` Dan Carpenter
2021-01-08 16:42 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104110946.xGfNWLoV-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.