From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
Date: Mon, 11 Jan 2021 13:43:10 +0300 [thread overview]
Message-ID: <20210111104310.GD5083@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f5e6c330254ae691f6d7befe61c786eb5056007e
commit: acfdd18591eaac25446e976a0c0d190f8b3dbfb1 firmware: xilinx: Use hash-table for api feature check
config: arm64-randconfig-m031-20210108 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
vim +/feature_data +1288 drivers/firmware/xilinx/zynqmp.c
76582671eb5d006 Rajan Vaja 2018-09-12 1280 static int zynqmp_firmware_remove(struct platform_device *pdev)
76582671eb5d006 Rajan Vaja 2018-09-12 1281 {
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1282 struct pm_api_feature_data *feature_data;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1283 int i;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1284
e23d9c6d0d4912f Jolly Shah 2019-02-01 1285 mfd_remove_devices(&pdev->dev);
b321725257c1733 Rajan Vaja 2018-09-12 1286 zynqmp_pm_api_debugfs_exit();
b321725257c1733 Rajan Vaja 2018-09-12 1287
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 @1288 hash_for_each(pm_api_features_map, i, feature_data, hentry) {
This has to use hash_for_each_safe().
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1289 hash_del(&feature_data->hentry);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1290 kfree(feature_data);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1291 }
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1292
76582671eb5d006 Rajan Vaja 2018-09-12 1293 return 0;
76582671eb5d006 Rajan Vaja 2018-09-12 1294 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31707 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
Date: Mon, 11 Jan 2021 13:43:10 +0300 [thread overview]
Message-ID: <20210111104310.GD5083@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f5e6c330254ae691f6d7befe61c786eb5056007e
commit: acfdd18591eaac25446e976a0c0d190f8b3dbfb1 firmware: xilinx: Use hash-table for api feature check
config: arm64-randconfig-m031-20210108 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
vim +/feature_data +1288 drivers/firmware/xilinx/zynqmp.c
76582671eb5d006 Rajan Vaja 2018-09-12 1280 static int zynqmp_firmware_remove(struct platform_device *pdev)
76582671eb5d006 Rajan Vaja 2018-09-12 1281 {
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1282 struct pm_api_feature_data *feature_data;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1283 int i;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1284
e23d9c6d0d4912f Jolly Shah 2019-02-01 1285 mfd_remove_devices(&pdev->dev);
b321725257c1733 Rajan Vaja 2018-09-12 1286 zynqmp_pm_api_debugfs_exit();
b321725257c1733 Rajan Vaja 2018-09-12 1287
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 @1288 hash_for_each(pm_api_features_map, i, feature_data, hentry) {
This has to use hash_for_each_safe().
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1289 hash_del(&feature_data->hentry);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1290 kfree(feature_data);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1291 }
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1292
76582671eb5d006 Rajan Vaja 2018-09-12 1293 return 0;
76582671eb5d006 Rajan Vaja 2018-09-12 1294 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31707 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
Ravi Patel <ravi.patel@xilinx.com>,
Rajan Vaja <rajan.vaja@xilinx.com>, Arnd Bergmann <arnd@arndb.de>
Subject: drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
Date: Mon, 11 Jan 2021 13:43:10 +0300 [thread overview]
Message-ID: <20210111104310.GD5083@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f5e6c330254ae691f6d7befe61c786eb5056007e
commit: acfdd18591eaac25446e976a0c0d190f8b3dbfb1 firmware: xilinx: Use hash-table for api feature check
config: arm64-randconfig-m031-20210108 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data'
vim +/feature_data +1288 drivers/firmware/xilinx/zynqmp.c
76582671eb5d006 Rajan Vaja 2018-09-12 1280 static int zynqmp_firmware_remove(struct platform_device *pdev)
76582671eb5d006 Rajan Vaja 2018-09-12 1281 {
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1282 struct pm_api_feature_data *feature_data;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1283 int i;
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1284
e23d9c6d0d4912f Jolly Shah 2019-02-01 1285 mfd_remove_devices(&pdev->dev);
b321725257c1733 Rajan Vaja 2018-09-12 1286 zynqmp_pm_api_debugfs_exit();
b321725257c1733 Rajan Vaja 2018-09-12 1287
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 @1288 hash_for_each(pm_api_features_map, i, feature_data, hentry) {
This has to use hash_for_each_safe().
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1289 hash_del(&feature_data->hentry);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1290 kfree(feature_data);
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1291 }
acfdd18591eaac2 Amit Sunil Dhamne 2020-11-23 1292
76582671eb5d006 Rajan Vaja 2018-09-12 1293 return 0;
76582671eb5d006 Rajan Vaja 2018-09-12 1294 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31707 bytes --]
next reply other threads:[~2021-01-11 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 10:43 Dan Carpenter [this message]
2021-01-11 10:43 ` drivers/firmware/xilinx/zynqmp.c:1288 zynqmp_firmware_remove() error: dereferencing freed memory 'feature_data' Dan Carpenter
2021-01-11 10:43 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-04-11 1:51 kernel test robot
2021-01-08 16:42 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111104310.GD5083@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.