From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, weiwan@google.com,
virtualization@lists.linux-foundation.org, willemb@google.com,
kuba@kernel.org
Subject: Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi
Date: Tue, 13 Apr 2021 00:24:35 -0400 [thread overview]
Message-ID: <20210413002340-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210412.161458.652699519749470159.davem@davemloft.net>
On Mon, Apr 12, 2021 at 04:14:58PM -0700, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Mon, 12 Apr 2021 18:33:45 -0400
>
> > On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote:
> >> OK I started looking at this again. My idea is simple.
> >> A. disable callbacks before we try to drain skbs
> >> B. actually do disable callbacks even with event idx
> >>
> >> To make B not regress, we need to
> >> C. detect the common case of disable after event triggering and skip the write then.
> >>
> >> I added a new event_triggered flag for that.
> >> Completely untested - but then I could not see the warnings either.
> >> Would be very much interested to know whether this patch helps
> >> resolve the sruprious interrupt problem at all ...
> >>
> >>
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Hmm a slightly cleaner alternative is to clear the flag when enabling interrupts ...
> > I wonder which cacheline it's best to use for this.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Please make a fresh new submission if you want to use this approach, thanks.
Absolutely. This is untested so I just sent this idea out for early feedback
and hopefully help with testing on real hardware.
Sorry about being unclear.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: weiwan@google.com, netdev@vger.kernel.org, kuba@kernel.org,
willemb@google.com, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi
Date: Tue, 13 Apr 2021 00:24:35 -0400 [thread overview]
Message-ID: <20210413002340-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210412.161458.652699519749470159.davem@davemloft.net>
On Mon, Apr 12, 2021 at 04:14:58PM -0700, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Mon, 12 Apr 2021 18:33:45 -0400
>
> > On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote:
> >> OK I started looking at this again. My idea is simple.
> >> A. disable callbacks before we try to drain skbs
> >> B. actually do disable callbacks even with event idx
> >>
> >> To make B not regress, we need to
> >> C. detect the common case of disable after event triggering and skip the write then.
> >>
> >> I added a new event_triggered flag for that.
> >> Completely untested - but then I could not see the warnings either.
> >> Would be very much interested to know whether this patch helps
> >> resolve the sruprious interrupt problem at all ...
> >>
> >>
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Hmm a slightly cleaner alternative is to clear the flag when enabling interrupts ...
> > I wonder which cacheline it's best to use for this.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Please make a fresh new submission if you want to use this approach, thanks.
Absolutely. This is untested so I just sent this idea out for early feedback
and hopefully help with testing on real hardware.
Sorry about being unclear.
--
MST
next prev parent reply other threads:[~2021-04-13 4:24 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 0:21 [PATCH net] virtio-net: suppress bad irq warning for tx napi Wei Wang
2021-02-02 2:24 ` Jakub Kicinski
2021-02-02 3:06 ` Jason Wang
2021-02-02 3:06 ` Jason Wang
2021-02-02 14:37 ` Willem de Bruijn
2021-02-02 14:37 ` Willem de Bruijn
2021-02-03 5:33 ` Jason Wang
2021-02-03 5:33 ` Jason Wang
2021-02-03 18:28 ` Willem de Bruijn
2021-02-03 18:28 ` Willem de Bruijn
2021-02-04 3:06 ` Jason Wang
2021-02-04 3:06 ` Jason Wang
2021-02-04 20:50 ` Willem de Bruijn
2021-02-04 20:50 ` Willem de Bruijn
2021-02-08 3:29 ` Jason Wang
2021-02-08 3:29 ` Jason Wang
2021-02-08 19:08 ` Willem de Bruijn
2021-02-08 19:08 ` Willem de Bruijn
2021-02-09 3:27 ` Jason Wang
2021-02-09 3:27 ` Jason Wang
2021-02-09 14:58 ` Willem de Bruijn
2021-02-09 14:58 ` Willem de Bruijn
2021-02-09 18:00 ` Wei Wang
2021-02-10 9:14 ` Michael S. Tsirkin
2021-02-10 9:14 ` Michael S. Tsirkin
2021-02-11 0:13 ` Wei Wang
2021-02-18 5:39 ` Jason Wang
2021-02-18 5:39 ` Jason Wang
2021-02-21 11:33 ` Michael S. Tsirkin
2021-02-21 11:33 ` Michael S. Tsirkin
2021-02-02 23:11 ` Michael S. Tsirkin
2021-02-02 23:11 ` Michael S. Tsirkin
2021-02-02 23:47 ` Wei Wang
2021-02-02 23:53 ` Willem de Bruijn
2021-02-03 0:06 ` Willem de Bruijn
2021-02-03 10:38 ` Michael S. Tsirkin
2021-02-03 10:38 ` Michael S. Tsirkin
2021-02-03 18:24 ` Willem de Bruijn
2021-02-03 18:24 ` Willem de Bruijn
2021-02-03 23:09 ` Michael S. Tsirkin
2021-02-03 23:09 ` Michael S. Tsirkin
2021-02-03 23:52 ` Wei Wang
2021-02-04 20:47 ` Willem de Bruijn
2021-02-04 20:47 ` Willem de Bruijn
2021-02-05 22:28 ` Wei Wang
2021-04-13 5:15 ` Michael S. Tsirkin
2021-04-13 5:15 ` Michael S. Tsirkin
2021-09-29 20:21 ` Wei Wang
2021-09-29 21:53 ` Michael S. Tsirkin
2021-09-29 21:53 ` Michael S. Tsirkin
2021-09-29 23:08 ` Wei Wang
2021-09-30 5:40 ` Michael S. Tsirkin
2021-09-30 5:40 ` Michael S. Tsirkin
2021-09-30 18:10 ` Dave Taht
2021-04-12 22:08 ` Michael S. Tsirkin
2021-04-12 22:08 ` Michael S. Tsirkin
2021-04-12 22:33 ` Michael S. Tsirkin
2021-04-12 22:33 ` Michael S. Tsirkin
2021-04-12 23:14 ` David Miller
2021-04-12 23:14 ` David Miller
2021-04-13 4:24 ` Michael S. Tsirkin [this message]
2021-04-13 4:24 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413002340-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=weiwan@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.