From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>, Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/sve: Remove redundant system_supports_sve() tests
Date: Tue, 13 Apr 2021 12:49:34 +0100 [thread overview]
Message-ID: <20210413114933.GE15806@arm.com> (raw)
In-Reply-To: <20210412172320.3315-1-broonie@kernel.org>
On Mon, Apr 12, 2021 at 06:23:20PM +0100, Mark Brown wrote:
> Currently there are a number of places in the SVE code where we check both
> system_supports_sve() and TIF_SVE. This is a bit redundant given that we
> should never get into a situation where we have set TIF_SVE without having
> SVE support and it is not clear that silently ignoring a mistakenly set
> TIF_SVE flag is the most sensible error handling approach. For now let's
> just drop the system_supports_sve() checks since this will at least reduce
> overhead a little.
It makes sense. The only advantage is if CONFIG_ARM64_SVE is disabled,
we avoid an extra check but with defconfig that's always on.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-13 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 17:23 [PATCH] arm64/sve: Remove redundant system_supports_sve() tests Mark Brown
2021-04-13 11:49 ` Catalin Marinas [this message]
2021-04-14 10:06 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413114933.GE15806@arm.com \
--to=catalin.marinas@arm.com \
--cc=Dave.Martin@arm.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.