All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	linux-mtd@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: lpc32xx_slc: Fix external use of SW Hamming ECC helper
Date: Tue, 13 Apr 2021 08:51:48 -0400	[thread overview]
Message-ID: <20210413125148.GB34377@localhost> (raw)
In-Reply-To: <20210413095916.330405-1-miquel.raynal@bootlin.com>

On Tue 2021-04-13 @ 11:59:16 AM, Miquel Raynal wrote:
> Since the Hamming software ECC engine has been updated to become a
> proper and independent ECC engine, it is now mandatory to either
> initialize the engine before using any one of his functions or use one
> of the bare helpers which only perform the calculations. As there is no
> actual need for a proper ECC initialization, let's just use the bare
> helper instead of the rawnand one.
> 
> Fixes: 19b2ce184b9f ("mtd: nand: ecc-hamming: Stop using raw NAND structures")
> Cc: stable@vger.kernel.org
> Reported-by: Trevor Woerner <twoerner@gmail.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Tested-by: Trevor Woerner <twoerner@gmail.com>

> ---
>  drivers/mtd/nand/raw/lpc32xx_slc.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c
> index 6b7269cfb7d8..65663f5ba54f 100644
> --- a/drivers/mtd/nand/raw/lpc32xx_slc.c
> +++ b/drivers/mtd/nand/raw/lpc32xx_slc.c
> @@ -27,6 +27,7 @@
>  #include <linux/of.h>
>  #include <linux/of_gpio.h>
>  #include <linux/mtd/lpc32xx_slc.h>
> +#include <linux/mtd/nand-ecc-sw-hamming.h>
>  
>  #define LPC32XX_MODNAME		"lpc32xx-nand"
>  
> @@ -344,6 +345,18 @@ static int lpc32xx_nand_ecc_calculate(struct nand_chip *chip,
>  	return 0;
>  }
>  
> +/*
> + * Corrects the data
> + */
> +static int lpc32xx_nand_ecc_correct(struct nand_chip *chip,
> +				    unsigned char *buf,
> +				    unsigned char *read_ecc,
> +				    unsigned char *calc_ecc)
> +{
> +	return ecc_sw_hamming_correct(buf, read_ecc, calc_ecc,
> +				      chip->ecc.size, false);
> +}
> +
>  /*
>   * Read a single byte from NAND device
>   */
> @@ -802,7 +815,7 @@ static int lpc32xx_nand_attach_chip(struct nand_chip *chip)
>  	chip->ecc.write_oob = lpc32xx_nand_write_oob_syndrome;
>  	chip->ecc.read_oob = lpc32xx_nand_read_oob_syndrome;
>  	chip->ecc.calculate = lpc32xx_nand_ecc_calculate;
> -	chip->ecc.correct = rawnand_sw_hamming_correct;
> +	chip->ecc.correct = lpc32xx_nand_ecc_correct;
>  	chip->ecc.hwctl = lpc32xx_nand_ecc_enable;
>  
>  	/*
> @@ -819,8 +832,14 @@ static int lpc32xx_nand_attach_chip(struct nand_chip *chip)
>  	return 0;
>  }
>  
> +static void lpc32xx_nand_detach_chip(struct nand_chip *chip)
> +{
> +	rawnand_sw_hamming_cleanup(chip);
> +}
> +
>  static const struct nand_controller_ops lpc32xx_nand_controller_ops = {
>  	.attach_chip = lpc32xx_nand_attach_chip,
> +	.detach_chip = lpc32xx_nand_detach_chip,
>  };
>  
>  /*
> -- 
> 2.27.0
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Trevor Woerner <twoerner@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	linux-mtd@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: lpc32xx_slc: Fix external use of SW Hamming ECC helper
Date: Tue, 13 Apr 2021 08:51:48 -0400	[thread overview]
Message-ID: <20210413125148.GB34377@localhost> (raw)
In-Reply-To: <20210413095916.330405-1-miquel.raynal@bootlin.com>

On Tue 2021-04-13 @ 11:59:16 AM, Miquel Raynal wrote:
> Since the Hamming software ECC engine has been updated to become a
> proper and independent ECC engine, it is now mandatory to either
> initialize the engine before using any one of his functions or use one
> of the bare helpers which only perform the calculations. As there is no
> actual need for a proper ECC initialization, let's just use the bare
> helper instead of the rawnand one.
> 
> Fixes: 19b2ce184b9f ("mtd: nand: ecc-hamming: Stop using raw NAND structures")
> Cc: stable@vger.kernel.org
> Reported-by: Trevor Woerner <twoerner@gmail.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Tested-by: Trevor Woerner <twoerner@gmail.com>

> ---
>  drivers/mtd/nand/raw/lpc32xx_slc.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c
> index 6b7269cfb7d8..65663f5ba54f 100644
> --- a/drivers/mtd/nand/raw/lpc32xx_slc.c
> +++ b/drivers/mtd/nand/raw/lpc32xx_slc.c
> @@ -27,6 +27,7 @@
>  #include <linux/of.h>
>  #include <linux/of_gpio.h>
>  #include <linux/mtd/lpc32xx_slc.h>
> +#include <linux/mtd/nand-ecc-sw-hamming.h>
>  
>  #define LPC32XX_MODNAME		"lpc32xx-nand"
>  
> @@ -344,6 +345,18 @@ static int lpc32xx_nand_ecc_calculate(struct nand_chip *chip,
>  	return 0;
>  }
>  
> +/*
> + * Corrects the data
> + */
> +static int lpc32xx_nand_ecc_correct(struct nand_chip *chip,
> +				    unsigned char *buf,
> +				    unsigned char *read_ecc,
> +				    unsigned char *calc_ecc)
> +{
> +	return ecc_sw_hamming_correct(buf, read_ecc, calc_ecc,
> +				      chip->ecc.size, false);
> +}
> +
>  /*
>   * Read a single byte from NAND device
>   */
> @@ -802,7 +815,7 @@ static int lpc32xx_nand_attach_chip(struct nand_chip *chip)
>  	chip->ecc.write_oob = lpc32xx_nand_write_oob_syndrome;
>  	chip->ecc.read_oob = lpc32xx_nand_read_oob_syndrome;
>  	chip->ecc.calculate = lpc32xx_nand_ecc_calculate;
> -	chip->ecc.correct = rawnand_sw_hamming_correct;
> +	chip->ecc.correct = lpc32xx_nand_ecc_correct;
>  	chip->ecc.hwctl = lpc32xx_nand_ecc_enable;
>  
>  	/*
> @@ -819,8 +832,14 @@ static int lpc32xx_nand_attach_chip(struct nand_chip *chip)
>  	return 0;
>  }
>  
> +static void lpc32xx_nand_detach_chip(struct nand_chip *chip)
> +{
> +	rawnand_sw_hamming_cleanup(chip);
> +}
> +
>  static const struct nand_controller_ops lpc32xx_nand_controller_ops = {
>  	.attach_chip = lpc32xx_nand_attach_chip,
> +	.detach_chip = lpc32xx_nand_detach_chip,
>  };
>  
>  /*
> -- 
> 2.27.0
> 

  reply	other threads:[~2021-04-13 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13  9:59 [PATCH v2] mtd: rawnand: lpc32xx_slc: Fix external use of SW Hamming ECC helper Miquel Raynal
2021-04-13  9:59 ` Miquel Raynal
2021-04-13 12:51 ` Trevor Woerner [this message]
2021-04-13 12:51   ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210413125148.GB34377@localhost \
    --to=twoerner@gmail.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.