Re: [PATCH 1/2] iommu/sva: Tighten SVA bind API with explicit flags

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2679 bytes --]

Hi Jacob,

I love your patch! Yet something to improve:

[auto build test ERROR on vkoul-dmaengine/next]
[also build test ERROR on char-misc/char-misc-testing v5.12-rc7]
[cannot apply to iommu/next next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jacob-Pan/iommu-sva-Tighten-SVA-bind-API-with-explicit-flags/20210409-094521
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: x86_64-randconfig-a016-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/3b009446e2f451c401cff7a6d4766424acbcc890
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jacob-Pan/iommu-sva-Tighten-SVA-bind-API-with-explicit-flags/20210409-094521
        git checkout 3b009446e2f451c401cff7a6d4766424acbcc890
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/dma/idxd/init.c: In function 'idxd_enable_system_pasid':
>> drivers/dma/idxd/init.c:307:10: error: 'IOMMU_SVA_BIND_SUPERVISOR' undeclared (first use in this function)
     307 |  flags = IOMMU_SVA_BIND_SUPERVISOR;
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/dma/idxd/init.c:307:10: note: each undeclared identifier is reported only once for each function it appears in


vim +/IOMMU_SVA_BIND_SUPERVISOR +307 drivers/dma/idxd/init.c

   300	
   301	static int idxd_enable_system_pasid(struct idxd_device *idxd)
   302	{
   303		unsigned int flags;
   304		unsigned int pasid;
   305		struct iommu_sva *sva;
   306	
 > 307		flags = IOMMU_SVA_BIND_SUPERVISOR;
   308	
   309		sva = iommu_sva_bind_device(&idxd->pdev->dev, NULL, flags);
   310		if (IS_ERR(sva)) {
   311			dev_warn(&idxd->pdev->dev,
   312				 "iommu sva bind failed: %ld\n", PTR_ERR(sva));
   313			return PTR_ERR(sva);
   314		}
   315	
   316		pasid = iommu_sva_get_pasid(sva);
   317		if (pasid == IOMMU_PASID_INVALID) {
   318			iommu_sva_unbind_device(sva);
   319			return -ENODEV;
   320		}
   321	
   322		idxd->sva = sva;
   323		idxd->pasid = pasid;
   324		dev_dbg(&idxd->pdev->dev, "system pasid: %u\n", pasid);
   325		return 0;
   326	}
   327	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37534 bytes --]

[-- Attachment #3: Type: text/plain, Size: 156 bytes --]

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu