From: Oscar Salvador <osalvador@suse.de>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Alexander Duyck <alexanderduyck@fb.com>,
Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.com>,
David Hildenbrand <david@redhat.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 resend] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove
Date: Wed, 14 Apr 2021 09:18:02 +0200 [thread overview]
Message-ID: <20210414071756.GA20401@linux> (raw)
In-Reply-To: <20210412120842.GY3697@techsingularity.net>
On Mon, Apr 12, 2021 at 01:08:42PM +0100, Mel Gorman wrote:
> zone_pcp_reset allegedly protects against a race with drain_pages
> using local_irq_save but this is bogus. local_irq_save only operates
> on the local CPU. If memory hotplug is running on CPU A and drain_pages
> is running on CPU B, disabling IRQs on CPU A does not affect CPU B and
> offers no protection.
>
> This patch deletes IRQ disable/enable on the grounds that IRQs protect
> nothing and assumes the existing hotplug paths guarantees the PCP cannot be
> used after zone_pcp_enable(). That should be the case already because all
> the pages have been freed and there is no page to put on the PCP lists.
>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2021-04-14 7:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 12:08 [PATCH v2 resend] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove Mel Gorman
2021-04-12 12:12 ` David Hildenbrand
2021-04-12 12:40 ` Vlastimil Babka
2021-04-12 14:08 ` Mel Gorman
2021-04-12 14:12 ` David Hildenbrand
2021-04-12 15:27 ` Mel Gorman
2021-04-12 16:02 ` David Hildenbrand
2021-04-13 9:36 ` Vlastimil Babka
2021-04-13 9:49 ` Mel Gorman
2021-04-13 10:16 ` Michal Hocko
2021-04-13 6:44 ` Michal Hocko
2021-04-13 6:40 ` Michal Hocko
2021-04-14 7:18 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414071756.GA20401@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alexanderduyck@fb.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mst@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.