All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Pu Lehui <pulehui@huawei.com>
Cc: michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	yangjihong1@huawei.com, zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer()
Date: Wed, 14 Apr 2021 09:57:30 +0200	[thread overview]
Message-ID: <20210414075730.GD2180@ninjato> (raw)
In-Reply-To: <20210408112352.211173-1-pulehui@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On Thu, Apr 08, 2021 at 07:23:52PM +0800, Pu Lehui wrote:
> pm_runtime_get_sync() will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get() to keep usage
> counter balanced.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Thanks, yet I applied this series now:

http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Pu Lehui <pulehui@huawei.com>
Cc: michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	yangjihong1@huawei.com, zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer()
Date: Wed, 14 Apr 2021 09:57:30 +0200	[thread overview]
Message-ID: <20210414075730.GD2180@ninjato> (raw)
In-Reply-To: <20210408112352.211173-1-pulehui@huawei.com>


[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]

On Thu, Apr 08, 2021 at 07:23:52PM +0800, Pu Lehui wrote:
> pm_runtime_get_sync() will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get() to keep usage
> counter balanced.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Thanks, yet I applied this series now:

http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-04-14  7:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 11:23 [PATCH -next] i2c: cadence: Fix PM reference leak in cdns_i2c_master_xfer() Pu Lehui
2021-04-08 11:23 ` Pu Lehui
2021-04-08 11:30 ` Michal Simek
2021-04-08 11:30   ` Michal Simek
2021-04-14  7:57 ` Wolfram Sang [this message]
2021-04-14  7:57   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414075730.GD2180@ninjato \
    --to=wsa@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=pulehui@huawei.com \
    --cc=yangjihong1@huawei.com \
    --cc=zhangjinhao2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.