All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Ye Weihua <yeweihua4@huawei.com>
Cc: linux@rempel-privat.de, kernel@pengutronix.de,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	linux-imx@nxp.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, yangjihong1@huawei.com,
	zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] i2c: imx: Fix PM reference leak in i2c_imx_reg_slave()
Date: Wed, 14 Apr 2021 10:04:12 +0200	[thread overview]
Message-ID: <20210414080412.GI2180@ninjato> (raw)
In-Reply-To: <20210408110638.200761-1-yeweihua4@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

On Thu, Apr 08, 2021 at 07:06:38PM +0800, Ye Weihua wrote:
> The PM reference count is not expected to be incremented on return in
> these functions.
> 
> However, pm_runtime_get_sync() will increment the PM reference count
> even on failure. forgetting to put the reference again will result in
> a leak.
> 
> Replace it with pm_runtime_resume_and_get() to keep the usage counter
> balanced.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Weihua <yeweihua4@huawei.com>

After rebasing, only one hunk was left:

> @@ -801,7 +801,7 @@ static int i2c_imx_reg_slave(struct i2c_client *client)
>  	i2c_imx->last_slave_event = I2C_SLAVE_STOP;
>  
>  	/* Resume */
> -	ret = pm_runtime_get_sync(i2c_imx->adapter.dev.parent);
> +	ret = pm_runtime_resume_and_get(i2c_imx->adapter.dev.parent);
>  	if (ret < 0) {
>  		dev_err(&i2c_imx->adapter.dev, "failed to resume i2c controller");
>  		return ret;

I applied this to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Ye Weihua <yeweihua4@huawei.com>
Cc: linux@rempel-privat.de, kernel@pengutronix.de,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	linux-imx@nxp.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, yangjihong1@huawei.com,
	zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] i2c: imx: Fix PM reference leak in i2c_imx_reg_slave()
Date: Wed, 14 Apr 2021 10:04:12 +0200	[thread overview]
Message-ID: <20210414080412.GI2180@ninjato> (raw)
In-Reply-To: <20210408110638.200761-1-yeweihua4@huawei.com>


[-- Attachment #1.1: Type: text/plain, Size: 981 bytes --]

On Thu, Apr 08, 2021 at 07:06:38PM +0800, Ye Weihua wrote:
> The PM reference count is not expected to be incremented on return in
> these functions.
> 
> However, pm_runtime_get_sync() will increment the PM reference count
> even on failure. forgetting to put the reference again will result in
> a leak.
> 
> Replace it with pm_runtime_resume_and_get() to keep the usage counter
> balanced.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Weihua <yeweihua4@huawei.com>

After rebasing, only one hunk was left:

> @@ -801,7 +801,7 @@ static int i2c_imx_reg_slave(struct i2c_client *client)
>  	i2c_imx->last_slave_event = I2C_SLAVE_STOP;
>  
>  	/* Resume */
> -	ret = pm_runtime_get_sync(i2c_imx->adapter.dev.parent);
> +	ret = pm_runtime_resume_and_get(i2c_imx->adapter.dev.parent);
>  	if (ret < 0) {
>  		dev_err(&i2c_imx->adapter.dev, "failed to resume i2c controller");
>  		return ret;

I applied this to for-next, thanks!


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-14  8:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 11:06 [PATCH -next] i2c: imx: Fix PM reference leak in i2c_imx_reg_slave() Ye Weihua
2021-04-08 11:06 ` Ye Weihua
2021-04-14  8:04 ` Wolfram Sang [this message]
2021-04-14  8:04   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414080412.GI2180@ninjato \
    --to=wsa@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=yangjihong1@huawei.com \
    --cc=yeweihua4@huawei.com \
    --cc=zhangjinhao2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.