[PATCH] mfd: abx500: Remove repeated struct declaration

[PATCH] mfd: abx500: Remove repeated struct declaration

[Wan Jiabing]

struct ab8500_fg is declared twice. The blew one at 457th line
is closer to user. Remove the duplicate here.
Move "Forward declaration" annotation to the suitable place.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 include/linux/mfd/abx500/ab8500-bm.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/mfd/abx500/ab8500-bm.h b/include/linux/mfd/abx500/ab8500-bm.h
index 903e94c189d8..0b88eddcc5af 100644
--- a/include/linux/mfd/abx500/ab8500-bm.h
+++ b/include/linux/mfd/abx500/ab8500-bm.h
@@ -296,9 +296,6 @@ struct batres_vs_temp {
 	int resist;
 };
 
-/* Forward declaration */
-struct ab8500_fg;
-
 /**
  * struct ab8500_fg_parameters - Fuel gauge algorithm parameters, in seconds
  * if not specified
@@ -452,6 +449,7 @@ struct ab8500_bm_data {
 	const struct ab8500_fg_parameters *fg_params;
 };
 
+/* Forward declaration */
 struct ab8500_btemp;
 struct ab8500_gpadc;
 struct ab8500_fg;
-- 
2.25.1

Re: [PATCH] mfd: abx500: Remove repeated struct declaration

[Lee Jones]

On Thu, 01 Apr 2021, Wan Jiabing wrote:

> struct ab8500_fg is declared twice. The blew one at 457th line
> is closer to user. Remove the duplicate here.
> Move "Forward declaration" annotation to the suitable place.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  include/linux/mfd/abx500/ab8500-bm.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Please check, but I don't think this patch is valid anymore.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH] mfd: abx500: Remove repeated struct declaration

[Wan Jiabing]

struct ab8500_fg is declared twice. The blew one at 457th line
is closer to user. Remove the duplicate here.
Move "Forward declaration" annotation to the suitable place.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 include/linux/mfd/abx500/ab8500-bm.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/mfd/abx500/ab8500-bm.h b/include/linux/mfd/abx500/ab8500-bm.h
index 903e94c189d8..0b88eddcc5af 100644
--- a/include/linux/mfd/abx500/ab8500-bm.h
+++ b/include/linux/mfd/abx500/ab8500-bm.h
@@ -296,9 +296,6 @@ struct batres_vs_temp {
 	int resist;
 };
 
-/* Forward declaration */
-struct ab8500_fg;
-
 /**
  * struct ab8500_fg_parameters - Fuel gauge algorithm parameters, in seconds
  * if not specified
@@ -452,6 +449,7 @@ struct ab8500_bm_data {
 	const struct ab8500_fg_parameters *fg_params;
 };
 
+/* Forward declaration */
 struct ab8500_btemp;
 struct ab8500_gpadc;
 struct ab8500_fg;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel