All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option
Date: Thu, 15 Apr 2021 23:09:35 +0200	[thread overview]
Message-ID: <20210415210935.GI359705@scaer> (raw)
In-Reply-To: <20210415111957.27459-1-tolvupostur@gmail.com>

Einar, All,

On 2021-04-15 13:19 +0200, Einar Jon Gunnarsson spake thusly:
> Add a flag to enable gobject-introspection
> 
> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>

I've dropped the config option, to instead directly rely on the GOI
package to be enabled, and applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/modem-manager/Config.in        | 7 +++++++
>  package/modem-manager/modem-manager.mk | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index c4c723776d..67c4bf167c 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -25,6 +25,13 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
>  	select BR2_PACKAGE_LIBQMI
>  	help
>  	  This option enables support for QMI protocol
> +
> +config BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION
> +	bool "introspection support"
> +	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
> +	select BR2_PACKAGE_GOBJECT_INTROSPECTION
> +	help
> +	  This option enables support for GObject introspection
>  endif
>  
>  comment "modemmanager needs a toolchain w/ wchar, threads"
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index 2cc45d266b..cc8c49625f 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -34,6 +34,13 @@ else
>  MODEM_MANAGER_CONF_OPTS += --without-mbim
>  endif
>  
> +ifeq ($(BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION),y)
> +MODEM_MANAGER_DEPENDENCIES += gobject-introspection
> +MODEM_MANAGER_CONF_OPTS += --enable-introspection
> +else
> +MODEM_MANAGER_CONF_OPTS += --disable-introspection
> +endif
> +
>  define MODEM_MANAGER_INSTALL_INIT_SYSV
>  	$(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager \
>  		$(TARGET_DIR)/etc/init.d/S44modem-manager
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2021-04-15 21:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 11:19 [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option Einar Jon Gunnarsson
2021-04-15 12:58 ` Aleksander Morgado
2021-04-15 21:09 ` Yann E. MORIN [this message]
2021-04-25  7:42   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210415210935.GI359705@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.