* [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option
@ 2021-04-15 11:19 Einar Jon Gunnarsson
2021-04-15 12:58 ` Aleksander Morgado
2021-04-15 21:09 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Einar Jon Gunnarsson @ 2021-04-15 11:19 UTC (permalink / raw)
To: buildroot
Add a flag to enable gobject-introspection
Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
---
package/modem-manager/Config.in | 7 +++++++
package/modem-manager/modem-manager.mk | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index c4c723776d..67c4bf167c 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -25,6 +25,13 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
select BR2_PACKAGE_LIBQMI
help
This option enables support for QMI protocol
+
+config BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION
+ bool "introspection support"
+ depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
+ select BR2_PACKAGE_GOBJECT_INTROSPECTION
+ help
+ This option enables support for GObject introspection
endif
comment "modemmanager needs a toolchain w/ wchar, threads"
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index 2cc45d266b..cc8c49625f 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -34,6 +34,13 @@ else
MODEM_MANAGER_CONF_OPTS += --without-mbim
endif
+ifeq ($(BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION),y)
+MODEM_MANAGER_DEPENDENCIES += gobject-introspection
+MODEM_MANAGER_CONF_OPTS += --enable-introspection
+else
+MODEM_MANAGER_CONF_OPTS += --disable-introspection
+endif
+
define MODEM_MANAGER_INSTALL_INIT_SYSV
$(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager \
$(TARGET_DIR)/etc/init.d/S44modem-manager
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option
2021-04-15 11:19 [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option Einar Jon Gunnarsson
@ 2021-04-15 12:58 ` Aleksander Morgado
2021-04-15 21:09 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Aleksander Morgado @ 2021-04-15 12:58 UTC (permalink / raw)
To: buildroot
On Thu, Apr 15, 2021 at 1:20 PM Einar Jon Gunnarsson
<tolvupostur@gmail.com> wrote:
>
> Add a flag to enable gobject-introspection
>
> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
Nice!
Acked-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
> package/modem-manager/Config.in | 7 +++++++
> package/modem-manager/modem-manager.mk | 7 +++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index c4c723776d..67c4bf167c 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -25,6 +25,13 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
> select BR2_PACKAGE_LIBQMI
> help
> This option enables support for QMI protocol
> +
> +config BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION
> + bool "introspection support"
> + depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
> + select BR2_PACKAGE_GOBJECT_INTROSPECTION
> + help
> + This option enables support for GObject introspection
> endif
>
> comment "modemmanager needs a toolchain w/ wchar, threads"
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index 2cc45d266b..cc8c49625f 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -34,6 +34,13 @@ else
> MODEM_MANAGER_CONF_OPTS += --without-mbim
> endif
>
> +ifeq ($(BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION),y)
> +MODEM_MANAGER_DEPENDENCIES += gobject-introspection
> +MODEM_MANAGER_CONF_OPTS += --enable-introspection
> +else
> +MODEM_MANAGER_CONF_OPTS += --disable-introspection
> +endif
> +
> define MODEM_MANAGER_INSTALL_INIT_SYSV
> $(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager \
> $(TARGET_DIR)/etc/init.d/S44modem-manager
> --
> 2.17.1
>
--
Aleksander
https://aleksander.es
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option
2021-04-15 11:19 [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option Einar Jon Gunnarsson
2021-04-15 12:58 ` Aleksander Morgado
@ 2021-04-15 21:09 ` Yann E. MORIN
2021-04-25 7:42 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2021-04-15 21:09 UTC (permalink / raw)
To: buildroot
Einar, All,
On 2021-04-15 13:19 +0200, Einar Jon Gunnarsson spake thusly:
> Add a flag to enable gobject-introspection
>
> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
I've dropped the config option, to instead directly rely on the GOI
package to be enabled, and applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/modem-manager/Config.in | 7 +++++++
> package/modem-manager/modem-manager.mk | 7 +++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index c4c723776d..67c4bf167c 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -25,6 +25,13 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
> select BR2_PACKAGE_LIBQMI
> help
> This option enables support for QMI protocol
> +
> +config BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION
> + bool "introspection support"
> + depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
> + select BR2_PACKAGE_GOBJECT_INTROSPECTION
> + help
> + This option enables support for GObject introspection
> endif
>
> comment "modemmanager needs a toolchain w/ wchar, threads"
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index 2cc45d266b..cc8c49625f 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -34,6 +34,13 @@ else
> MODEM_MANAGER_CONF_OPTS += --without-mbim
> endif
>
> +ifeq ($(BR2_PACKAGE_MODEM_MANAGER_INTROSPECTION),y)
> +MODEM_MANAGER_DEPENDENCIES += gobject-introspection
> +MODEM_MANAGER_CONF_OPTS += --enable-introspection
> +else
> +MODEM_MANAGER_CONF_OPTS += --disable-introspection
> +endif
> +
> define MODEM_MANAGER_INSTALL_INIT_SYSV
> $(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager \
> $(TARGET_DIR)/etc/init.d/S44modem-manager
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option
2021-04-15 21:09 ` Yann E. MORIN
@ 2021-04-25 7:42 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2021-04-25 7:42 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Einar, All,
> On 2021-04-15 13:19 +0200, Einar Jon Gunnarsson spake thusly:
>> Add a flag to enable gobject-introspection
>>
>> Signed-off-by: Einar Jon Gunnarsson <tolvupostur@gmail.com>
> I've dropped the config option, to instead directly rely on the GOI
> package to be enabled, and applied to master, thanks.
Committed to 2021.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-25 7:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-15 11:19 [Buildroot] [PATCH 1/1] package/modem-manager: add introspection option Einar Jon Gunnarsson
2021-04-15 12:58 ` Aleksander Morgado
2021-04-15 21:09 ` Yann E. MORIN
2021-04-25 7:42 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.