From: Rob Herring <robh@kernel.org>
To: Rajeev Nandan <rajeevny@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, robdclark@gmail.com,
dianders@chromium.org, mkrishn@codeaurora.org,
kalyan_t@codeaurora.org, hoegsberg@chromium.org,
abhinavk@codeaurora.org, seanpaul@chromium.org
Subject: Re: [v1 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Document use-aux-backlight
Date: Thu, 15 Apr 2021 17:04:16 -0500 [thread overview]
Message-ID: <20210415220416.GA1954887@robh.at.kernel.org> (raw)
In-Reply-To: <1618418390-15055-3-git-send-email-rajeevny@codeaurora.org>
On Wed, Apr 14, 2021 at 10:09:49PM +0530, Rajeev Nandan wrote:
> If the panel connected to the bridge supports backlight control
> using DPCD registers on the DisplayPort aux channel, setting
> "use-aux-backlight" property in the bridge node will enable the
> registration of a DP aux backlight device from the bridge driver.
>
> Signed-off-by: Rajeev Nandan <rajeevny@codeaurora.org>
> ---
> .../devicetree/bindings/display/bridge/ti,sn65dsi86.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> index 26932d2..c8d8c00 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> @@ -58,6 +58,12 @@ properties:
> clock-names:
> const: refclk
>
> + use-aux-backlight:
use-dp-aux-backlight perhaps.
> + type: boolean
> + description:
> + The panel backlight to be controlled using DPCD registers on
> + the DP aux channel.
Sounds like a property of the panel, not the bridge. So it should be in
the panel node.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Rajeev Nandan <rajeevny@codeaurora.org>
Cc: devicetree@vger.kernel.org, mkrishn@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, dianders@chromium.org,
seanpaul@chromium.org, abhinavk@codeaurora.org,
kalyan_t@codeaurora.org, hoegsberg@chromium.org,
freedreno@lists.freedesktop.org
Subject: Re: [v1 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Document use-aux-backlight
Date: Thu, 15 Apr 2021 17:04:16 -0500 [thread overview]
Message-ID: <20210415220416.GA1954887@robh.at.kernel.org> (raw)
In-Reply-To: <1618418390-15055-3-git-send-email-rajeevny@codeaurora.org>
On Wed, Apr 14, 2021 at 10:09:49PM +0530, Rajeev Nandan wrote:
> If the panel connected to the bridge supports backlight control
> using DPCD registers on the DisplayPort aux channel, setting
> "use-aux-backlight" property in the bridge node will enable the
> registration of a DP aux backlight device from the bridge driver.
>
> Signed-off-by: Rajeev Nandan <rajeevny@codeaurora.org>
> ---
> .../devicetree/bindings/display/bridge/ti,sn65dsi86.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> index 26932d2..c8d8c00 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> @@ -58,6 +58,12 @@ properties:
> clock-names:
> const: refclk
>
> + use-aux-backlight:
use-dp-aux-backlight perhaps.
> + type: boolean
> + description:
> + The panel backlight to be controlled using DPCD registers on
> + the DP aux channel.
Sounds like a property of the panel, not the bridge. So it should be in
the panel node.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-15 22:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 16:39 [v1 0/3] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge Rajeev Nandan
2021-04-14 16:39 ` Rajeev Nandan
2021-04-14 16:39 ` [v1 1/3] drm/dp: Add DisplayPort aux backlight control support Rajeev Nandan
2021-04-14 16:39 ` Rajeev Nandan
2021-04-14 16:39 ` [v1 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Document use-aux-backlight Rajeev Nandan
2021-04-14 16:39 ` Rajeev Nandan
2021-04-15 22:04 ` Rob Herring [this message]
2021-04-15 22:04 ` Rob Herring
2021-04-14 16:39 ` [v1 3/3] drm/bridge: ti-sn65dsi86: Add DisplayPort aux backlight support Rajeev Nandan
2021-04-14 16:39 ` Rajeev Nandan
2021-04-16 23:02 ` [v1 0/3] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge Doug Anderson
2021-04-16 23:02 ` Doug Anderson
2021-04-20 8:14 ` Jani Nikula
2021-04-20 8:14 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415220416.GA1954887@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=abhinavk@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hoegsberg@chromium.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=rajeevny@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.