From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-nvme@lists.infradead.org
Subject: Re: [dm-devel] nvme: Return BLK_STS_TARGET if the DNR bit is set
Date: Thu, 15 Apr 2021 19:18:15 -0400 [thread overview]
Message-ID: <20210415231815.GA16047@redhat.com> (raw)
In-Reply-To: <20210415231126.8746-1-snitzer@redhat.com>
Sorry, emailed from wrong terminal... have since emailed correct v2
On Thu, Apr 15 2021 at 7:11pm -0400,
Mike Snitzer <snitzer@redhat.com> wrote:
> BZ: 1948690
> Upstream Status: RHEL-only
>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> rhel-8.git commit ef4ab90c12db5e0e50800ec323736b95be7a6ff5
> Author: Mike Snitzer <snitzer@redhat.com>
> Date: Tue Aug 25 21:52:45 2020 -0400
>
> [nvme] nvme: Return BLK_STS_TARGET if the DNR bit is set
>
> Message-id: <20200825215248.2291-8-snitzer@redhat.com>
> Patchwork-id: 325178
> Patchwork-instance: patchwork
> O-Subject: [RHEL8.3 PATCH 07/10] nvme: Return BLK_STS_TARGET if the DNR bit is set
> Bugzilla: 1843515
> RH-Acked-by: David Milburn <dmilburn@redhat.com>
> RH-Acked-by: Gopal Tiwari <gtiwari@redhat.com>
> RH-Acked-by: Ewan Milne <emilne@redhat.com>
>
> BZ: 1843515
> Upstream Status: RHEL-only
>
> If the DNR bit is set we should not retry the command, even if
> the standard status evaluation indicates so.
>
> SUSE is carrying this patch in their kernel:
> https://lwn.net/Articles/800370/
>
> Based on patch posted for upstream inclusion but rejected:
> v1: https://lore.kernel.org/linux-nvme/20190806111036.113233-1-hare@suse.de/
> v2: https://lore.kernel.org/linux-nvme/20190807071208.101882-1-hare@suse.de/
> v2-keith: https://lore.kernel.org/linux-nvme/20190807144725.GB25621@localhost.localdomain/
> v3: https://lore.kernel.org/linux-nvme/20190812075147.79598-1-hare@suse.de/
> v3-keith: https://lore.kernel.org/linux-nvme/20190813141510.GB32686@localhost.localdomain/
>
> This commit's change is basically "v3-keith".
>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>
>
> ---
> drivers/nvme/host/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-rhel9/drivers/nvme/host/core.c
> ===================================================================
> --- linux-rhel9.orig/drivers/nvme/host/core.c
> +++ linux-rhel9/drivers/nvme/host/core.c
> @@ -237,6 +237,9 @@ static void nvme_delete_ctrl_sync(struct
>
> static blk_status_t nvme_error_status(u16 status)
> {
> + if (unlikely(status & NVME_SC_DNR))
> + return BLK_STS_TARGET;
> +
> switch (status & 0x7ff) {
> case NVME_SC_SUCCESS:
> return BLK_STS_OK;
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: nvme: Return BLK_STS_TARGET if the DNR bit is set
Date: Thu, 15 Apr 2021 19:18:15 -0400 [thread overview]
Message-ID: <20210415231815.GA16047@redhat.com> (raw)
In-Reply-To: <20210415231126.8746-1-snitzer@redhat.com>
Sorry, emailed from wrong terminal... have since emailed correct v2
On Thu, Apr 15 2021 at 7:11pm -0400,
Mike Snitzer <snitzer@redhat.com> wrote:
> BZ: 1948690
> Upstream Status: RHEL-only
>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> rhel-8.git commit ef4ab90c12db5e0e50800ec323736b95be7a6ff5
> Author: Mike Snitzer <snitzer@redhat.com>
> Date: Tue Aug 25 21:52:45 2020 -0400
>
> [nvme] nvme: Return BLK_STS_TARGET if the DNR bit is set
>
> Message-id: <20200825215248.2291-8-snitzer@redhat.com>
> Patchwork-id: 325178
> Patchwork-instance: patchwork
> O-Subject: [RHEL8.3 PATCH 07/10] nvme: Return BLK_STS_TARGET if the DNR bit is set
> Bugzilla: 1843515
> RH-Acked-by: David Milburn <dmilburn@redhat.com>
> RH-Acked-by: Gopal Tiwari <gtiwari@redhat.com>
> RH-Acked-by: Ewan Milne <emilne@redhat.com>
>
> BZ: 1843515
> Upstream Status: RHEL-only
>
> If the DNR bit is set we should not retry the command, even if
> the standard status evaluation indicates so.
>
> SUSE is carrying this patch in their kernel:
> https://lwn.net/Articles/800370/
>
> Based on patch posted for upstream inclusion but rejected:
> v1: https://lore.kernel.org/linux-nvme/20190806111036.113233-1-hare@suse.de/
> v2: https://lore.kernel.org/linux-nvme/20190807071208.101882-1-hare@suse.de/
> v2-keith: https://lore.kernel.org/linux-nvme/20190807144725.GB25621@localhost.localdomain/
> v3: https://lore.kernel.org/linux-nvme/20190812075147.79598-1-hare@suse.de/
> v3-keith: https://lore.kernel.org/linux-nvme/20190813141510.GB32686@localhost.localdomain/
>
> This commit's change is basically "v3-keith".
>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>
>
> ---
> drivers/nvme/host/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-rhel9/drivers/nvme/host/core.c
> ===================================================================
> --- linux-rhel9.orig/drivers/nvme/host/core.c
> +++ linux-rhel9/drivers/nvme/host/core.c
> @@ -237,6 +237,9 @@ static void nvme_delete_ctrl_sync(struct
>
> static blk_status_t nvme_error_status(u16 status)
> {
> + if (unlikely(status & NVME_SC_DNR))
> + return BLK_STS_TARGET;
> +
> switch (status & 0x7ff) {
> case NVME_SC_SUCCESS:
> return BLK_STS_OK;
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: nvme: Return BLK_STS_TARGET if the DNR bit is set
Date: Thu, 15 Apr 2021 19:18:15 -0400 [thread overview]
Message-ID: <20210415231815.GA16047@redhat.com> (raw)
In-Reply-To: <20210415231126.8746-1-snitzer@redhat.com>
Sorry, emailed from wrong terminal... have since emailed correct v2
On Thu, Apr 15 2021 at 7:11pm -0400,
Mike Snitzer <snitzer@redhat.com> wrote:
> BZ: 1948690
> Upstream Status: RHEL-only
>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> rhel-8.git commit ef4ab90c12db5e0e50800ec323736b95be7a6ff5
> Author: Mike Snitzer <snitzer@redhat.com>
> Date: Tue Aug 25 21:52:45 2020 -0400
>
> [nvme] nvme: Return BLK_STS_TARGET if the DNR bit is set
>
> Message-id: <20200825215248.2291-8-snitzer@redhat.com>
> Patchwork-id: 325178
> Patchwork-instance: patchwork
> O-Subject: [RHEL8.3 PATCH 07/10] nvme: Return BLK_STS_TARGET if the DNR bit is set
> Bugzilla: 1843515
> RH-Acked-by: David Milburn <dmilburn@redhat.com>
> RH-Acked-by: Gopal Tiwari <gtiwari@redhat.com>
> RH-Acked-by: Ewan Milne <emilne@redhat.com>
>
> BZ: 1843515
> Upstream Status: RHEL-only
>
> If the DNR bit is set we should not retry the command, even if
> the standard status evaluation indicates so.
>
> SUSE is carrying this patch in their kernel:
> https://lwn.net/Articles/800370/
>
> Based on patch posted for upstream inclusion but rejected:
> v1: https://lore.kernel.org/linux-nvme/20190806111036.113233-1-hare@suse.de/
> v2: https://lore.kernel.org/linux-nvme/20190807071208.101882-1-hare@suse.de/
> v2-keith: https://lore.kernel.org/linux-nvme/20190807144725.GB25621@localhost.localdomain/
> v3: https://lore.kernel.org/linux-nvme/20190812075147.79598-1-hare@suse.de/
> v3-keith: https://lore.kernel.org/linux-nvme/20190813141510.GB32686@localhost.localdomain/
>
> This commit's change is basically "v3-keith".
>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> Signed-off-by: Frantisek Hrbata <fhrbata@redhat.com>
>
> ---
> drivers/nvme/host/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-rhel9/drivers/nvme/host/core.c
> ===================================================================
> --- linux-rhel9.orig/drivers/nvme/host/core.c
> +++ linux-rhel9/drivers/nvme/host/core.c
> @@ -237,6 +237,9 @@ static void nvme_delete_ctrl_sync(struct
>
> static blk_status_t nvme_error_status(u16 status)
> {
> + if (unlikely(status & NVME_SC_DNR))
> + return BLK_STS_TARGET;
> +
> switch (status & 0x7ff) {
> case NVME_SC_SUCCESS:
> return BLK_STS_OK;
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-15 23:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 23:11 [dm-devel] nvme: Return BLK_STS_TARGET if the DNR bit is set Mike Snitzer
2021-04-15 23:11 ` Mike Snitzer
2021-04-15 23:11 ` Mike Snitzer
2021-04-15 23:11 ` [dm-devel] nvme: update failover handling to work with REQ_FAILFAST_TRANSPORT Mike Snitzer
2021-04-15 23:11 ` Mike Snitzer
2021-04-15 23:11 ` [dm-devel] nvme: decouple basic ANA log page re-read support from native multipathing Mike Snitzer
2021-04-15 23:11 ` Mike Snitzer
2021-04-15 23:11 ` [dm-devel] nvme: allow retry for requests with REQ_FAILFAST_TRANSPORT set Mike Snitzer
2021-04-15 23:11 ` Mike Snitzer
2021-04-15 23:18 ` Mike Snitzer [this message]
2021-04-15 23:18 ` nvme: Return BLK_STS_TARGET if the DNR bit is set Mike Snitzer
2021-04-15 23:18 ` Mike Snitzer
2021-04-16 5:58 ` [dm-devel] " Hannes Reinecke
2021-04-16 5:58 ` Hannes Reinecke
2021-04-16 5:58 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415231815.GA16047@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.