From: Tao Ren <rentao.bupt@gmail.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2] watchdog: aspeed: fix integer overflow in set_timeout handler
Date: Fri, 16 Apr 2021 11:25:59 -0700 [thread overview]
Message-ID: <20210416182558.GA4816@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <2771f72a-cc3c-54a5-cc2c-715ea61be6b7@roeck-us.net>
On Thu, Apr 15, 2021 at 10:07:32PM -0700, Guenter Roeck wrote:
> On 4/15/21 7:13 PM, rentao.bupt at gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> >
> > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout
> > handler to avoid potential integer overflow when the supplied timeout is
> > greater than aspeed's maximum allowed timeout (4294 seconds).
> >
>
> I think this is the wrong focus: What this fixes is the wrong hardware
> timeout calculation. Again, I think that the wrong calculation leads to
> the overflow should not be the focus of this patch, though it can of
> course be mentioned.
>
> I'll leave it up to Wim to decide if he wants to apply the patch with the
> current explanation.
>
> Thanks,
> Guenter
Sorry I didn't get your point correctly, and I guess it was because of
my lack of knowledge in timeout/max_hw_heartbeat_ms/worker (hopefully
my understanding is correct now :))
Let me drop this patch and send a new one with different subject and
description soon.
Cheers,
Tao
WARNING: multiple messages have this Message-ID (diff)
From: Tao Ren <rentao.bupt@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, Tao Ren <taoren@fb.com>,
Amithash Prasad <amithash@fb.com>
Subject: Re: [PATCH v2] watchdog: aspeed: fix integer overflow in set_timeout handler
Date: Fri, 16 Apr 2021 11:25:59 -0700 [thread overview]
Message-ID: <20210416182558.GA4816@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <2771f72a-cc3c-54a5-cc2c-715ea61be6b7@roeck-us.net>
On Thu, Apr 15, 2021 at 10:07:32PM -0700, Guenter Roeck wrote:
> On 4/15/21 7:13 PM, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> >
> > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout
> > handler to avoid potential integer overflow when the supplied timeout is
> > greater than aspeed's maximum allowed timeout (4294 seconds).
> >
>
> I think this is the wrong focus: What this fixes is the wrong hardware
> timeout calculation. Again, I think that the wrong calculation leads to
> the overflow should not be the focus of this patch, though it can of
> course be mentioned.
>
> I'll leave it up to Wim to decide if he wants to apply the patch with the
> current explanation.
>
> Thanks,
> Guenter
Sorry I didn't get your point correctly, and I guess it was because of
my lack of knowledge in timeout/max_hw_heartbeat_ms/worker (hopefully
my understanding is correct now :))
Let me drop this patch and send a new one with different subject and
description soon.
Cheers,
Tao
WARNING: multiple messages have this Message-ID (diff)
From: Tao Ren <rentao.bupt@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>, Tao Ren <taoren@fb.com>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Amithash Prasad <amithash@fb.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] watchdog: aspeed: fix integer overflow in set_timeout handler
Date: Fri, 16 Apr 2021 11:25:59 -0700 [thread overview]
Message-ID: <20210416182558.GA4816@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <2771f72a-cc3c-54a5-cc2c-715ea61be6b7@roeck-us.net>
On Thu, Apr 15, 2021 at 10:07:32PM -0700, Guenter Roeck wrote:
> On 4/15/21 7:13 PM, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> >
> > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout
> > handler to avoid potential integer overflow when the supplied timeout is
> > greater than aspeed's maximum allowed timeout (4294 seconds).
> >
>
> I think this is the wrong focus: What this fixes is the wrong hardware
> timeout calculation. Again, I think that the wrong calculation leads to
> the overflow should not be the focus of this patch, though it can of
> course be mentioned.
>
> I'll leave it up to Wim to decide if he wants to apply the patch with the
> current explanation.
>
> Thanks,
> Guenter
Sorry I didn't get your point correctly, and I guess it was because of
my lack of knowledge in timeout/max_hw_heartbeat_ms/worker (hopefully
my understanding is correct now :))
Let me drop this patch and send a new one with different subject and
description soon.
Cheers,
Tao
WARNING: multiple messages have this Message-ID (diff)
From: Tao Ren <rentao.bupt@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, Tao Ren <taoren@fb.com>,
Amithash Prasad <amithash@fb.com>
Subject: Re: [PATCH v2] watchdog: aspeed: fix integer overflow in set_timeout handler
Date: Fri, 16 Apr 2021 11:25:59 -0700 [thread overview]
Message-ID: <20210416182558.GA4816@taoren-ubuntu-R90MNF91> (raw)
In-Reply-To: <2771f72a-cc3c-54a5-cc2c-715ea61be6b7@roeck-us.net>
On Thu, Apr 15, 2021 at 10:07:32PM -0700, Guenter Roeck wrote:
> On 4/15/21 7:13 PM, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> >
> > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout
> > handler to avoid potential integer overflow when the supplied timeout is
> > greater than aspeed's maximum allowed timeout (4294 seconds).
> >
>
> I think this is the wrong focus: What this fixes is the wrong hardware
> timeout calculation. Again, I think that the wrong calculation leads to
> the overflow should not be the focus of this patch, though it can of
> course be mentioned.
>
> I'll leave it up to Wim to decide if he wants to apply the patch with the
> current explanation.
>
> Thanks,
> Guenter
Sorry I didn't get your point correctly, and I guess it was because of
my lack of knowledge in timeout/max_hw_heartbeat_ms/worker (hopefully
my understanding is correct now :))
Let me drop this patch and send a new one with different subject and
description soon.
Cheers,
Tao
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-16 18:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 2:13 [PATCH v2] watchdog: aspeed: fix integer overflow in set_timeout handler rentao.bupt
2021-04-16 2:13 ` rentao.bupt
2021-04-16 2:13 ` rentao.bupt
2021-04-16 5:07 ` Guenter Roeck
2021-04-16 5:07 ` Guenter Roeck
2021-04-16 5:07 ` Guenter Roeck
2021-04-16 18:25 ` Tao Ren [this message]
2021-04-16 18:25 ` Tao Ren
2021-04-16 18:25 ` Tao Ren
2021-04-16 18:25 ` Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416182558.GA4816@taoren-ubuntu-R90MNF91 \
--to=rentao.bupt@gmail.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.