All of lore.kernel.org
 help / color / mirror / Atom feed
* [sashal-linux-stable:queue-5.4 24/25] drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
@ 2021-04-16 16:41 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-16 16:41 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5953 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head:   e53f5c1fde5c006e28ef2ee0ac0afa3a940b51be
commit: 2a2346e9fb9df53fb793af8ded6e727f0677601d [24/25] scsi: qla2xxx: Add a shadow variable to hold disc_state history of fcport
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/commit/?id=2a2346e9fb9df53fb793af8ded6e727f0677601d
        git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
        git fetch --no-tags sashal-linux-stable queue-5.4
        git checkout 2a2346e9fb9df53fb793af8ded6e727f0677601d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
     156 | static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
         |            ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/scsi/qla2xxx/qla_def.h:4861,
                    from drivers/scsi/qla2xxx/qla_init.c:7:
   drivers/scsi/qla2xxx/qla_gbl.h:83:12: note: previous declaration of 'qla24xx_async_abort_cmd' was here
      83 | extern int qla24xx_async_abort_cmd(srb_t *, bool);
         |            ^~~~~~~~~~~~~~~~~~~~~~~


vim +/qla24xx_async_abort_cmd +156 drivers/scsi/qla2xxx/qla_init.c

1956eee58872e6 Bart Van Assche 2019-04-17  155  
1956eee58872e6 Bart Van Assche 2019-04-17 @156  static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
1956eee58872e6 Bart Van Assche 2019-04-17  157  {
1956eee58872e6 Bart Van Assche 2019-04-17  158  	scsi_qla_host_t *vha = cmd_sp->vha;
1956eee58872e6 Bart Van Assche 2019-04-17  159  	struct srb_iocb *abt_iocb;
1956eee58872e6 Bart Van Assche 2019-04-17  160  	srb_t *sp;
1956eee58872e6 Bart Van Assche 2019-04-17  161  	int rval = QLA_FUNCTION_FAILED;
1956eee58872e6 Bart Van Assche 2019-04-17  162  
1956eee58872e6 Bart Van Assche 2019-04-17  163  	sp = qla2xxx_get_qpair_sp(cmd_sp->vha, cmd_sp->qpair, cmd_sp->fcport,
1956eee58872e6 Bart Van Assche 2019-04-17  164  				  GFP_ATOMIC);
1956eee58872e6 Bart Van Assche 2019-04-17  165  	if (!sp)
fe6b52c9adbcce Bart Van Assche 2019-08-08  166  		return rval;
1956eee58872e6 Bart Van Assche 2019-04-17  167  
1956eee58872e6 Bart Van Assche 2019-04-17  168  	abt_iocb = &sp->u.iocb_cmd;
1956eee58872e6 Bart Van Assche 2019-04-17  169  	sp->type = SRB_ABT_CMD;
1956eee58872e6 Bart Van Assche 2019-04-17  170  	sp->name = "abort";
1956eee58872e6 Bart Van Assche 2019-04-17  171  	sp->qpair = cmd_sp->qpair;
b7abcc7df5e131 Quinn Tran      2019-11-05  172  	sp->cmd_sp = cmd_sp;
1956eee58872e6 Bart Van Assche 2019-04-17  173  	if (wait)
1956eee58872e6 Bart Van Assche 2019-04-17  174  		sp->flags = SRB_WAKEUP_ON_COMP;
1956eee58872e6 Bart Van Assche 2019-04-17  175  
1956eee58872e6 Bart Van Assche 2019-04-17  176  	abt_iocb->timeout = qla24xx_abort_iocb_timeout;
1956eee58872e6 Bart Van Assche 2019-04-17  177  	init_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17  178  	/* FW can send 2 x ABTS's timeout/20s */
1956eee58872e6 Bart Van Assche 2019-04-17  179  	qla2x00_init_timer(sp, 42);
1956eee58872e6 Bart Van Assche 2019-04-17  180  
1956eee58872e6 Bart Van Assche 2019-04-17  181  	abt_iocb->u.abt.cmd_hndl = cmd_sp->handle;
1956eee58872e6 Bart Van Assche 2019-04-17  182  	abt_iocb->u.abt.req_que_no = cpu_to_le16(cmd_sp->qpair->req->id);
1956eee58872e6 Bart Van Assche 2019-04-17  183  
1956eee58872e6 Bart Van Assche 2019-04-17  184  	sp->done = qla24xx_abort_sp_done;
1956eee58872e6 Bart Van Assche 2019-04-17  185  
1956eee58872e6 Bart Van Assche 2019-04-17  186  	ql_dbg(ql_dbg_async, vha, 0x507c,
1956eee58872e6 Bart Van Assche 2019-04-17  187  	       "Abort command issued - hdl=%x, type=%x\n", cmd_sp->handle,
1956eee58872e6 Bart Van Assche 2019-04-17  188  	       cmd_sp->type);
1956eee58872e6 Bart Van Assche 2019-04-17  189  
1956eee58872e6 Bart Van Assche 2019-04-17  190  	rval = qla2x00_start_sp(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08  191  	if (rval != QLA_SUCCESS) {
fe6b52c9adbcce Bart Van Assche 2019-08-08  192  		sp->free(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08  193  		return rval;
fe6b52c9adbcce Bart Van Assche 2019-08-08  194  	}
1956eee58872e6 Bart Van Assche 2019-04-17  195  
1956eee58872e6 Bart Van Assche 2019-04-17  196  	if (wait) {
1956eee58872e6 Bart Van Assche 2019-04-17  197  		wait_for_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17  198  		rval = abt_iocb->u.abt.comp_status == CS_COMPLETE ?
1956eee58872e6 Bart Van Assche 2019-04-17  199  			QLA_SUCCESS : QLA_FUNCTION_FAILED;
fe6b52c9adbcce Bart Van Assche 2019-08-08  200  		sp->free(sp);
1956eee58872e6 Bart Van Assche 2019-04-17  201  	}
1956eee58872e6 Bart Van Assche 2019-04-17  202  
1956eee58872e6 Bart Van Assche 2019-04-17  203  	return rval;
1956eee58872e6 Bart Van Assche 2019-04-17  204  }
1956eee58872e6 Bart Van Assche 2019-04-17  205  

:::::: The code at line 156 was first introduced by commit
:::::: 1956eee58872e622cfe03f060a5d8a20d24afe47 scsi: qla2xxx: Make qla24xx_async_abort_cmd() static

:::::: TO: Bart Van Assche <bvanassche@acm.org>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68127 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [sashal-linux-stable:queue-5.4 24/25] drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
@ 2021-04-16 18:56 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-16 18:56 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5943 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head:   e53f5c1fde5c006e28ef2ee0ac0afa3a940b51be
commit: 2a2346e9fb9df53fb793af8ded6e727f0677601d [24/25] scsi: qla2xxx: Add a shadow variable to hold disc_state history of fcport
config: x86_64-randconfig-a002-20210416 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/commit/?id=2a2346e9fb9df53fb793af8ded6e727f0677601d
        git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
        git fetch --no-tags sashal-linux-stable queue-5.4
        git checkout 2a2346e9fb9df53fb793af8ded6e727f0677601d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
   static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
              ^
   drivers/scsi/qla2xxx/qla_gbl.h:83:12: note: previous declaration is here
   extern int qla24xx_async_abort_cmd(srb_t *, bool);
              ^
   1 error generated.


vim +/qla24xx_async_abort_cmd +156 drivers/scsi/qla2xxx/qla_init.c

1956eee58872e6 Bart Van Assche 2019-04-17  155  
1956eee58872e6 Bart Van Assche 2019-04-17 @156  static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
1956eee58872e6 Bart Van Assche 2019-04-17  157  {
1956eee58872e6 Bart Van Assche 2019-04-17  158  	scsi_qla_host_t *vha = cmd_sp->vha;
1956eee58872e6 Bart Van Assche 2019-04-17  159  	struct srb_iocb *abt_iocb;
1956eee58872e6 Bart Van Assche 2019-04-17  160  	srb_t *sp;
1956eee58872e6 Bart Van Assche 2019-04-17  161  	int rval = QLA_FUNCTION_FAILED;
1956eee58872e6 Bart Van Assche 2019-04-17  162  
1956eee58872e6 Bart Van Assche 2019-04-17  163  	sp = qla2xxx_get_qpair_sp(cmd_sp->vha, cmd_sp->qpair, cmd_sp->fcport,
1956eee58872e6 Bart Van Assche 2019-04-17  164  				  GFP_ATOMIC);
1956eee58872e6 Bart Van Assche 2019-04-17  165  	if (!sp)
fe6b52c9adbcce Bart Van Assche 2019-08-08  166  		return rval;
1956eee58872e6 Bart Van Assche 2019-04-17  167  
1956eee58872e6 Bart Van Assche 2019-04-17  168  	abt_iocb = &sp->u.iocb_cmd;
1956eee58872e6 Bart Van Assche 2019-04-17  169  	sp->type = SRB_ABT_CMD;
1956eee58872e6 Bart Van Assche 2019-04-17  170  	sp->name = "abort";
1956eee58872e6 Bart Van Assche 2019-04-17  171  	sp->qpair = cmd_sp->qpair;
b7abcc7df5e131 Quinn Tran      2019-11-05  172  	sp->cmd_sp = cmd_sp;
1956eee58872e6 Bart Van Assche 2019-04-17  173  	if (wait)
1956eee58872e6 Bart Van Assche 2019-04-17  174  		sp->flags = SRB_WAKEUP_ON_COMP;
1956eee58872e6 Bart Van Assche 2019-04-17  175  
1956eee58872e6 Bart Van Assche 2019-04-17  176  	abt_iocb->timeout = qla24xx_abort_iocb_timeout;
1956eee58872e6 Bart Van Assche 2019-04-17  177  	init_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17  178  	/* FW can send 2 x ABTS's timeout/20s */
1956eee58872e6 Bart Van Assche 2019-04-17  179  	qla2x00_init_timer(sp, 42);
1956eee58872e6 Bart Van Assche 2019-04-17  180  
1956eee58872e6 Bart Van Assche 2019-04-17  181  	abt_iocb->u.abt.cmd_hndl = cmd_sp->handle;
1956eee58872e6 Bart Van Assche 2019-04-17  182  	abt_iocb->u.abt.req_que_no = cpu_to_le16(cmd_sp->qpair->req->id);
1956eee58872e6 Bart Van Assche 2019-04-17  183  
1956eee58872e6 Bart Van Assche 2019-04-17  184  	sp->done = qla24xx_abort_sp_done;
1956eee58872e6 Bart Van Assche 2019-04-17  185  
1956eee58872e6 Bart Van Assche 2019-04-17  186  	ql_dbg(ql_dbg_async, vha, 0x507c,
1956eee58872e6 Bart Van Assche 2019-04-17  187  	       "Abort command issued - hdl=%x, type=%x\n", cmd_sp->handle,
1956eee58872e6 Bart Van Assche 2019-04-17  188  	       cmd_sp->type);
1956eee58872e6 Bart Van Assche 2019-04-17  189  
1956eee58872e6 Bart Van Assche 2019-04-17  190  	rval = qla2x00_start_sp(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08  191  	if (rval != QLA_SUCCESS) {
fe6b52c9adbcce Bart Van Assche 2019-08-08  192  		sp->free(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08  193  		return rval;
fe6b52c9adbcce Bart Van Assche 2019-08-08  194  	}
1956eee58872e6 Bart Van Assche 2019-04-17  195  
1956eee58872e6 Bart Van Assche 2019-04-17  196  	if (wait) {
1956eee58872e6 Bart Van Assche 2019-04-17  197  		wait_for_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17  198  		rval = abt_iocb->u.abt.comp_status == CS_COMPLETE ?
1956eee58872e6 Bart Van Assche 2019-04-17  199  			QLA_SUCCESS : QLA_FUNCTION_FAILED;
fe6b52c9adbcce Bart Van Assche 2019-08-08  200  		sp->free(sp);
1956eee58872e6 Bart Van Assche 2019-04-17  201  	}
1956eee58872e6 Bart Van Assche 2019-04-17  202  
1956eee58872e6 Bart Van Assche 2019-04-17  203  	return rval;
1956eee58872e6 Bart Van Assche 2019-04-17  204  }
1956eee58872e6 Bart Van Assche 2019-04-17  205  

:::::: The code at line 156 was first introduced by commit
:::::: 1956eee58872e622cfe03f060a5d8a20d24afe47 scsi: qla2xxx: Make qla24xx_async_abort_cmd() static

:::::: TO: Bart Van Assche <bvanassche@acm.org>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34634 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-16 18:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-16 18:56 [sashal-linux-stable:queue-5.4 24/25] drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2021-04-16 16:41 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.