From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/2] powerpc: add ALTIVEC support to lib/ when PPC_FPU not set
Date: Mon, 19 Apr 2021 08:57:14 -0500 [thread overview]
Message-ID: <20210419135714.GS26583@gate.crashing.org> (raw)
In-Reply-To: <4f5aea37-f638-3fde-0680-ec456ad91141@csgroup.eu>
On Mon, Apr 19, 2021 at 03:38:02PM +0200, Christophe Leroy wrote:
> Le 19/04/2021 à 15:32, Segher Boessenkool a écrit :
> >On Sun, Apr 18, 2021 at 01:17:26PM -0700, Randy Dunlap wrote:
> >>Add ldstfp.o to the Makefile for CONFIG_ALTIVEC and add
> >>externs for get_vr() and put_vr() in lib/sstep.c to fix the
> >>build errors.
> >
> >> obj-$(CONFIG_PPC_FPU) += ldstfp.o
> >>+obj-$(CONFIG_ALTIVEC) += ldstfp.o
> >
> >It is probably a good idea to split ldstfp.S into two, one for each of
> >the two configuration options?
> >
>
> Or we can build it all the time and #ifdef the FPU part.
>
> Because it contains FPU, ALTIVEC and VSX stuff.
So it becomes an empty object file if none of the options are selected?
Good idea :-)
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] powerpc: add ALTIVEC support to lib/ when PPC_FPU not set
Date: Mon, 19 Apr 2021 08:57:14 -0500 [thread overview]
Message-ID: <20210419135714.GS26583@gate.crashing.org> (raw)
In-Reply-To: <4f5aea37-f638-3fde-0680-ec456ad91141@csgroup.eu>
On Mon, Apr 19, 2021 at 03:38:02PM +0200, Christophe Leroy wrote:
> Le 19/04/2021 à 15:32, Segher Boessenkool a écrit :
> >On Sun, Apr 18, 2021 at 01:17:26PM -0700, Randy Dunlap wrote:
> >>Add ldstfp.o to the Makefile for CONFIG_ALTIVEC and add
> >>externs for get_vr() and put_vr() in lib/sstep.c to fix the
> >>build errors.
> >
> >> obj-$(CONFIG_PPC_FPU) += ldstfp.o
> >>+obj-$(CONFIG_ALTIVEC) += ldstfp.o
> >
> >It is probably a good idea to split ldstfp.S into two, one for each of
> >the two configuration options?
> >
>
> Or we can build it all the time and #ifdef the FPU part.
>
> Because it contains FPU, ALTIVEC and VSX stuff.
So it becomes an empty object file if none of the options are selected?
Good idea :-)
Segher
next prev parent reply other threads:[~2021-04-19 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 20:17 [PATCH 1/2] powerpc: add enable_kernel_fp() stub for ALTIVEC without PPC_FPU Randy Dunlap
2021-04-18 20:17 ` Randy Dunlap
2021-04-18 20:17 ` [PATCH 2/2] powerpc: add ALTIVEC support to lib/ when PPC_FPU not set Randy Dunlap
2021-04-18 20:17 ` Randy Dunlap
2021-04-19 13:32 ` Segher Boessenkool
2021-04-19 13:32 ` Segher Boessenkool
2021-04-19 13:38 ` Christophe Leroy
2021-04-19 13:38 ` Christophe Leroy
2021-04-19 13:57 ` Segher Boessenkool [this message]
2021-04-19 13:57 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419135714.GS26583@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.