[dunfell/master PATCH] ti-test: fix build errors with nested conditional operation

[dunfell/master PATCH] ti-test: fix build errors with nested conditional operation

[praneeth]

From: Praneeth Bajjuri <praneeth@ti.com>

nested conditional operation like this
${@oe.utils.conditional(<condition>, ${@bb.utils.contains()}

is causing build issues on some of the older build machines like this.

Missing or unbuildable dependency chain was: ['tisdk-default-image', 'ti-test', "'',"]
ERROR: Nothing RPROVIDES ''omapdrmtest',' (but <>/ti-test.bb RDEPENDS on or otherwise requires it)
NOTE: Runtime target ''omapdrmtest',' is unbuildable, removing...
Missing or unbuildable dependency chain was: ["'omapdrmtest',"]
ERROR: Nothing RPROVIDES ''mmip',' (but <>/ti-test.bb RDEPENDS on or otherwise requires it)
NOTE: Runtime target ''mmip',' is unbuildable, removing...
Missing or unbuildable dependency chain was: ["'mmip',"]

This patch fixes such build issue.

Suggested-by: Denys Dmytriyenko <denis@denix.org>
Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
---
 meta-arago-distro/recipes-core/packagegroups/ti-test.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
index cbc246d5..219b43b6 100644
--- a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
@@ -66,12 +66,14 @@ ARAGO_TI_TEST_append_ti43x = " \
     ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', 'cmem-test', d)} \
 "
 
+NOT_MAINLINE_MMIP_DEPS = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)}"
+
 ARAGO_TI_TEST_append_omap-a15 = " \
     omapconf \
     ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', " \
         ti-ipc-test \
-        ${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)} \
         cmem-test \
+	${NOT_MAINLINE_MMIP_DEPS} \
     ", d)} \
 "
 
-- 
2.17.1

Re: [dunfell/master PATCH] ti-test: fix build errors with nested conditional operation

[Tammana, Gowtham]

>-----Original Message-----
>From: Bajjuri, Praneeth
>Sent: Friday, April 23, 2021 7:19 PM
>To: Bajjuri, Praneeth <praneeth@ti.com>
>Cc: Denys Dmytriyenko <denis@denix.org>; Tammana, Gowtham <g-
>tammana@ti.com>; meta-arago@arago-project.org
>Subject: [dunfell/master PATCH] ti-test: fix build errors with nested
>conditional operation
>
>From: Praneeth Bajjuri <praneeth@ti.com>
>
>nested conditional operation like this
>${@oe.utils.conditional(<condition>, ${@bb.utils.contains()}
>
>is causing build issues on some of the older build machines like this.
>
>Missing or unbuildable dependency chain was: ['tisdk-default-image', 'ti-
>test', "'',"]
>ERROR: Nothing RPROVIDES ''omapdrmtest',' (but <>/ti-test.bb RDEPENDS on
>or otherwise requires it)
>NOTE: Runtime target ''omapdrmtest',' is unbuildable, removing...
>Missing or unbuildable dependency chain was: ["'omapdrmtest',"]
>ERROR: Nothing RPROVIDES ''mmip',' (but <>/ti-test.bb RDEPENDS on or
>otherwise requires it)
>NOTE: Runtime target ''mmip',' is unbuildable, removing...
>Missing or unbuildable dependency chain was: ["'mmip',"]
>
>This patch fixes such build issue.
>
>Suggested-by: Denys Dmytriyenko <denis@denix.org>
>Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>

Reviewed-by: Gowtham Tammana <g-tammana@ti.com>

>---
> meta-arago-distro/recipes-core/packagegroups/ti-test.bb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
>b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
>index cbc246d5..219b43b6 100644
>--- a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
>+++ b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
>@@ -66,12 +66,14 @@ ARAGO_TI_TEST_append_ti43x = " \
>     ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', 'cmem-test',
>d)} \
> "
>
>+NOT_MAINLINE_MMIP_DEPS = "${@bb.utils.contains('MACHINE_FEATURES',
>'mmip', 'omapdrmtest', '', d)}"
>+
> ARAGO_TI_TEST_append_omap-a15 = " \
>     omapconf \
>     ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', " \
>         ti-ipc-test \
>-        ${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest',
>'', d)} \
>         cmem-test \
>+	${NOT_MAINLINE_MMIP_DEPS} \
>     ", d)} \
> "
>
>--
>2.17.1