[linux-next:master 602/15065] drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1046 vop_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 1027)

All of lore.kernel.org
 help / color / mirror / Atom feed

* [linux-next:master 602/15065] drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1046 vop_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 1027)
@ 2021-04-29 11:38 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-27  6:44 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3996 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Maxime Ripard <maxime@cerno.tech>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   3f1fee3e7237347f09a2c7fa538119e6d9ea4b84
commit: 5ddb0bd4ddc35d9c9376d109398f84277bb8d25e [602/15065] drm/atomic: Pass the full state to planes async atomic check and update
:::::: branch date: 24 hours ago
:::::: commit date: 9 weeks ago
config: ia64-randconfig-m031-20210426 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1046 vop_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 1027)

vim +/state +1046 drivers/gpu/drm/rockchip/rockchip_drm_vop.c

2048e3286f347d Mark Yao               2014-08-22  1023  
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1024  static int vop_plane_atomic_async_check(struct drm_plane *plane,
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1025  					struct drm_atomic_state *state)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1026  {
5ddb0bd4ddc35d Maxime Ripard          2021-02-19 @1027  	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1028  										 plane);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1029  	struct vop_win *vop_win = to_vop_win(plane);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1030  	const struct vop_win_data *win = vop_win->data;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1031  	int min_scale = win->phy->scl ? FRAC_16_16(1, 8) :
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1032  					DRM_PLANE_HELPER_NO_SCALING;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1033  	int max_scale = win->phy->scl ? FRAC_16_16(8, 1) :
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1034  					DRM_PLANE_HELPER_NO_SCALING;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1035  	struct drm_crtc_state *crtc_state;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1036  
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1037  	if (plane != new_plane_state->crtc->cursor)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1038  		return -EINVAL;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1039  
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1040  	if (!plane->state)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1041  		return -EINVAL;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1042  
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1043  	if (!plane->state->fb)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1044  		return -EINVAL;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1045  
5ddb0bd4ddc35d Maxime Ripard          2021-02-19 @1046  	if (state)
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1047  		crtc_state = drm_atomic_get_existing_crtc_state(state,
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1048  								new_plane_state->crtc);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1049  	else /* Special case for asynchronous cursor updates. */
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1050  		crtc_state = plane->crtc->state;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1051  
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1052  	return drm_atomic_helper_check_plane_state(plane->state, crtc_state,
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1053  						   min_scale, max_scale,
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1054  						   true, true);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1055  }
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1056  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29129 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [linux-next:master 602/15065] drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1046 vop_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 1027)
@ 2021-04-29 11:38 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-04-29 11:38 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4048 bytes --]

[ This patch is from Feb 19 and why was mm on the CC list? Plus it's
  602/15065...  -dan ]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   3f1fee3e7237347f09a2c7fa538119e6d9ea4b84
commit: 5ddb0bd4ddc35d9c9376d109398f84277bb8d25e [602/15065] drm/atomic: Pass the full state to planes async atomic check and update
config: ia64-randconfig-m031-20210426 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1046 vop_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 1027)

vim +/state +1046 drivers/gpu/drm/rockchip/rockchip_drm_vop.c

15609559a834a5 Enric Balletbo i Serra 2018-12-05  1024  static int vop_plane_atomic_async_check(struct drm_plane *plane,
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1025  					struct drm_atomic_state *state)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1026  {
5ddb0bd4ddc35d Maxime Ripard          2021-02-19 @1027  	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
                                                                                                                                         ^^^^^
Unchecked dereference.

5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1028  										 plane);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1029  	struct vop_win *vop_win = to_vop_win(plane);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1030  	const struct vop_win_data *win = vop_win->data;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1031  	int min_scale = win->phy->scl ? FRAC_16_16(1, 8) :
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1032  					DRM_PLANE_HELPER_NO_SCALING;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1033  	int max_scale = win->phy->scl ? FRAC_16_16(8, 1) :
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1034  					DRM_PLANE_HELPER_NO_SCALING;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1035  	struct drm_crtc_state *crtc_state;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1036  
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1037  	if (plane != new_plane_state->crtc->cursor)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1038  		return -EINVAL;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1039  
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1040  	if (!plane->state)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1041  		return -EINVAL;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1042  
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1043  	if (!plane->state->fb)
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1044  		return -EINVAL;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1045  
5ddb0bd4ddc35d Maxime Ripard          2021-02-19 @1046  	if (state)
                                                                    ^^^^^
Checked too late.

5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1047  		crtc_state = drm_atomic_get_existing_crtc_state(state,
5ddb0bd4ddc35d Maxime Ripard          2021-02-19  1048  								new_plane_state->crtc);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1049  	else /* Special case for asynchronous cursor updates. */
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1050  		crtc_state = plane->crtc->state;
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1051  
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1052  	return drm_atomic_helper_check_plane_state(plane->state, crtc_state,
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1053  						   min_scale, max_scale,
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1054  						   true, true);
15609559a834a5 Enric Balletbo i Serra 2018-12-05  1055  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-29 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-27  6:44 [linux-next:master 602/15065] drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1046 vop_plane_atomic_async_check() warn: variable dereferenced before check 'state' (see line 1027) kernel test robot
2021-04-29 11:38 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.