* [cifs:for-next 41/41] fs/cifs/smb2ops.c:2671:1: sparse: sparse: symbol 'smb2_query_info_compound_final' was not declared. Should it be static?
@ 2021-04-28 3:37 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-04-28 3:37 UTC (permalink / raw)
To: Shyam Prasad N
Cc: kbuild-all, linux-cifs, samba-technical, Steve French,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 3244 bytes --]
tree: git://git.samba.org/sfrench/cifs-2.6.git for-next
head: 20b184c6741b0e1d4ab569e87ec36b2c23b2298d
commit: 20b184c6741b0e1d4ab569e87ec36b2c23b2298d [41/41] cifs: when out of credits on one channel, retry on another.
config: x86_64-randconfig-s022-20210428 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
git remote add cifs git://git.samba.org/sfrench/cifs-2.6.git
git fetch --no-tags cifs for-next
git checkout 20b184c6741b0e1d4ab569e87ec36b2c23b2298d
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/cifs/smb2ops.c:2671:1: sparse: sparse: symbol 'smb2_query_info_compound_final' was not declared. Should it be static?
>> fs/cifs/smb2ops.c:3284:1: sparse: sparse: symbol 'smb2_query_reparse_tag_final' was not declared. Should it be static?
--
>> fs/cifs/smb2pdu.c:2478:5: sparse: sparse: symbol 'smb311_posix_mkdir_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:2842:1: sparse: sparse: symbol 'SMB2_open_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:3056:1: sparse: sparse: symbol 'SMB2_ioctl_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:3247:1: sparse: sparse: symbol '__SMB2_close_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:3641:1: sparse: sparse: symbol 'SMB2_change_notify_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:3870:1: sparse: sparse: symbol 'SMB2_flush_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:4118:1: sparse: sparse: symbol 'smb2_async_readv_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:4205:1: sparse: sparse: symbol 'SMB2_read_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:4388:1: sparse: sparse: symbol 'smb2_async_writev_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:4542:1: sparse: sparse: symbol 'SMB2_write_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:4946:1: sparse: sparse: symbol 'SMB2_query_directory_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:5200:1: sparse: sparse: symbol 'SMB2_oplock_break_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:5333:1: sparse: sparse: symbol 'SMB311_posix_qfs_info_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:5398:1: sparse: sparse: symbol 'SMB2_QFS_info_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:5463:1: sparse: sparse: symbol 'SMB2_QFS_attr_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:5562:1: sparse: sparse: symbol 'smb2_lockv_final' was not declared. Should it be static?
>> fs/cifs/smb2pdu.c:5654:1: sparse: sparse: symbol 'SMB2_lease_break_final' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31576 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [cifs:for-next 41/41] fs/cifs/smb2ops.c:2671:1: sparse: sparse: symbol 'smb2_query_info_compound_final' was not declared. Should it be static? @ 2021-04-28 3:37 ` kernel test robot 0 siblings, 0 replies; 4+ messages in thread From: kernel test robot @ 2021-04-28 3:37 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 3291 bytes --] tree: git://git.samba.org/sfrench/cifs-2.6.git for-next head: 20b184c6741b0e1d4ab569e87ec36b2c23b2298d commit: 20b184c6741b0e1d4ab569e87ec36b2c23b2298d [41/41] cifs: when out of credits on one channel, retry on another. config: x86_64-randconfig-s022-20210428 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty git remote add cifs git://git.samba.org/sfrench/cifs-2.6.git git fetch --no-tags cifs for-next git checkout 20b184c6741b0e1d4ab569e87ec36b2c23b2298d # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> fs/cifs/smb2ops.c:2671:1: sparse: sparse: symbol 'smb2_query_info_compound_final' was not declared. Should it be static? >> fs/cifs/smb2ops.c:3284:1: sparse: sparse: symbol 'smb2_query_reparse_tag_final' was not declared. Should it be static? -- >> fs/cifs/smb2pdu.c:2478:5: sparse: sparse: symbol 'smb311_posix_mkdir_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:2842:1: sparse: sparse: symbol 'SMB2_open_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:3056:1: sparse: sparse: symbol 'SMB2_ioctl_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:3247:1: sparse: sparse: symbol '__SMB2_close_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:3641:1: sparse: sparse: symbol 'SMB2_change_notify_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:3870:1: sparse: sparse: symbol 'SMB2_flush_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:4118:1: sparse: sparse: symbol 'smb2_async_readv_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:4205:1: sparse: sparse: symbol 'SMB2_read_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:4388:1: sparse: sparse: symbol 'smb2_async_writev_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:4542:1: sparse: sparse: symbol 'SMB2_write_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:4946:1: sparse: sparse: symbol 'SMB2_query_directory_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:5200:1: sparse: sparse: symbol 'SMB2_oplock_break_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:5333:1: sparse: sparse: symbol 'SMB311_posix_qfs_info_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:5398:1: sparse: sparse: symbol 'SMB2_QFS_info_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:5463:1: sparse: sparse: symbol 'SMB2_QFS_attr_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:5562:1: sparse: sparse: symbol 'smb2_lockv_final' was not declared. Should it be static? >> fs/cifs/smb2pdu.c:5654:1: sparse: sparse: symbol 'SMB2_lease_break_final' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 31576 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC PATCH cifs] cifs: smb2_query_info_compound_final can be static 2021-04-28 3:37 ` kernel test robot @ 2021-04-28 3:37 ` kernel test robot -1 siblings, 0 replies; 4+ messages in thread From: kernel test robot @ 2021-04-28 3:37 UTC (permalink / raw) To: Shyam Prasad N Cc: kbuild-all, linux-cifs, samba-technical, Steve French, linux-kernel fs/cifs/smb2ops.c:2671:1: warning: symbol 'smb2_query_info_compound_final' was not declared. Should it be static? fs/cifs/smb2ops.c:3284:1: warning: symbol 'smb2_query_reparse_tag_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:2478:5: warning: symbol 'smb311_posix_mkdir_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:2842:1: warning: symbol 'SMB2_open_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3056:1: warning: symbol 'SMB2_ioctl_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3247:1: warning: symbol '__SMB2_close_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3641:1: warning: symbol 'SMB2_change_notify_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3870:1: warning: symbol 'SMB2_flush_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4118:1: warning: symbol 'smb2_async_readv_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4205:1: warning: symbol 'SMB2_read_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4388:1: warning: symbol 'smb2_async_writev_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4542:1: warning: symbol 'SMB2_write_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4946:1: warning: symbol 'SMB2_query_directory_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5200:1: warning: symbol 'SMB2_oplock_break_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5333:1: warning: symbol 'SMB311_posix_qfs_info_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5398:1: warning: symbol 'SMB2_QFS_info_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5463:1: warning: symbol 'SMB2_QFS_attr_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5562:1: warning: symbol 'smb2_lockv_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5654:1: warning: symbol 'SMB2_lease_break_final' was not declared. Should it be static? Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- smb2ops.c | 4 ++-- smb2pdu.c | 34 +++++++++++++++++----------------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 19d2e746d7802..3a224f91fc87e 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2667,7 +2667,7 @@ smb2_set_next_command(struct cifs_tcon *tcon, struct smb_rqst *rqst) * Passes the query info response back to the caller on success. * Caller need to free this with free_rsp_buf(). */ -int +static int smb2_query_info_compound_final(const unsigned int xid, struct cifs_tcon *tcon, __le16 *utf16_path, u32 desired_access, u32 class, u32 type, u32 output_len, @@ -3280,7 +3280,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, return rc; } -int +static int smb2_query_reparse_tag_final(const unsigned int xid, struct cifs_tcon *tcon, struct cifs_sb_info *cifs_sb, const char *full_path, __u32 *tag) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index dbf679a5da6cf..992a2faedd652 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -2475,7 +2475,7 @@ alloc_path_with_tree_prefix(__le16 **out_path, int *out_size, int *out_len, return 0; } -int smb311_posix_mkdir_final(const unsigned int xid, struct inode *inode, +static int smb311_posix_mkdir_final(const unsigned int xid, struct inode *inode, umode_t mode, struct cifs_tcon *tcon, const char *full_path, struct cifs_sb_info *cifs_sb) @@ -2839,7 +2839,7 @@ SMB2_open_free(struct smb_rqst *rqst) } int -SMB2_open_final(const unsigned int xid, struct cifs_open_parms *oparms, __le16 *path, +static SMB2_open_final(const unsigned int xid, struct cifs_open_parms *oparms, __le16 *path, __u8 *oplock, struct smb2_file_all_info *buf, struct create_posix_rsp *posix, struct kvec *err_iov, int *buftype) @@ -3053,7 +3053,7 @@ SMB2_ioctl_free(struct smb_rqst *rqst) * SMB2 IOCTL is used for both IOCTLs and FSCTLs */ int -SMB2_ioctl_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, +static SMB2_ioctl_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, u32 opcode, bool is_fsctl, char *in_data, u32 indatalen, u32 max_out_data_len, char **out_data, u32 *plen /* returned data len */) @@ -3244,7 +3244,7 @@ SMB2_close_free(struct smb_rqst *rqst) } int -__SMB2_close_final(const unsigned int xid, struct cifs_tcon *tcon, +static __SMB2_close_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, struct smb2_file_network_open_info *pbuf) { @@ -3638,7 +3638,7 @@ SMB2_notify_init(const unsigned int xid, struct smb_rqst *rqst, } int -SMB2_change_notify_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_change_notify_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, bool watch_tree, u32 completion_filter) { @@ -3867,7 +3867,7 @@ SMB2_flush_init(const unsigned int xid, struct smb_rqst *rqst, } int -SMB2_flush_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, +static SMB2_flush_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid) { struct cifs_ses *ses = tcon->ses; @@ -4114,7 +4114,7 @@ smb2_readv_callback(struct mid_q_entry *mid) add_credits(server, &credits, 0); } -int +static int smb2_async_readv_final(struct cifs_readdata *rdata) { int rc, flags = 0; @@ -4202,7 +4202,7 @@ smb2_async_readv(struct cifs_readdata *rdata) } int -SMB2_read_final(const unsigned int xid, struct cifs_io_parms *io_parms, +static SMB2_read_final(const unsigned int xid, struct cifs_io_parms *io_parms, unsigned int *nbytes, char **buf, int *buf_type) { struct smb_rqst rqst; @@ -4384,7 +4384,7 @@ smb2_writev_callback(struct mid_q_entry *mid) add_credits(server, &credits, 0); } -int +static int smb2_async_writev_final(struct cifs_writedata *wdata, void (*release)(struct kref *kref)) { @@ -4539,7 +4539,7 @@ smb2_async_writev(struct cifs_writedata *wdata, } int -SMB2_write_final(const unsigned int xid, struct cifs_io_parms *io_parms, +static SMB2_write_final(const unsigned int xid, struct cifs_io_parms *io_parms, unsigned int *nbytes, struct kvec *iov, int n_vec) { struct smb_rqst rqst; @@ -4943,7 +4943,7 @@ smb2_parse_query_directory(struct cifs_tcon *tcon, } int -SMB2_query_directory_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_query_directory_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, int index, struct cifs_search_info *srch_inf) { @@ -5197,7 +5197,7 @@ SMB2_set_ea(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_oplock_break_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_oplock_break_final(const unsigned int xid, struct cifs_tcon *tcon, const u64 persistent_fid, const u64 volatile_fid, __u8 oplock_level) { @@ -5330,7 +5330,7 @@ build_qfs_info_req(struct kvec *iov, struct cifs_tcon *tcon, } int -SMB311_posix_qfs_info_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB311_posix_qfs_info_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, struct kstatfs *fsdata) { struct smb_rqst rqst; @@ -5395,7 +5395,7 @@ SMB311_posix_qfs_info(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_QFS_info_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_QFS_info_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, struct kstatfs *fsdata) { struct smb_rqst rqst; @@ -5460,7 +5460,7 @@ SMB2_QFS_info(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_QFS_attr_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_QFS_attr_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, int level) { struct smb_rqst rqst; @@ -5558,7 +5558,7 @@ SMB2_QFS_attr(const unsigned int xid, struct cifs_tcon *tcon, return rc; } -int +static int smb2_lockv_final(const unsigned int xid, struct cifs_tcon *tcon, const __u64 persist_fid, const __u64 volatile_fid, const __u32 pid, const __u32 num_lock, struct smb2_lock_element *buf) @@ -5651,7 +5651,7 @@ SMB2_lock(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_lease_break_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_lease_break_final(const unsigned int xid, struct cifs_tcon *tcon, __u8 *lease_key, const __le32 lease_state) { struct smb_rqst rqst; ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RFC PATCH cifs] cifs: smb2_query_info_compound_final can be static @ 2021-04-28 3:37 ` kernel test robot 0 siblings, 0 replies; 4+ messages in thread From: kernel test robot @ 2021-04-28 3:37 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 8985 bytes --] fs/cifs/smb2ops.c:2671:1: warning: symbol 'smb2_query_info_compound_final' was not declared. Should it be static? fs/cifs/smb2ops.c:3284:1: warning: symbol 'smb2_query_reparse_tag_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:2478:5: warning: symbol 'smb311_posix_mkdir_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:2842:1: warning: symbol 'SMB2_open_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3056:1: warning: symbol 'SMB2_ioctl_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3247:1: warning: symbol '__SMB2_close_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3641:1: warning: symbol 'SMB2_change_notify_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:3870:1: warning: symbol 'SMB2_flush_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4118:1: warning: symbol 'smb2_async_readv_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4205:1: warning: symbol 'SMB2_read_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4388:1: warning: symbol 'smb2_async_writev_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4542:1: warning: symbol 'SMB2_write_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:4946:1: warning: symbol 'SMB2_query_directory_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5200:1: warning: symbol 'SMB2_oplock_break_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5333:1: warning: symbol 'SMB311_posix_qfs_info_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5398:1: warning: symbol 'SMB2_QFS_info_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5463:1: warning: symbol 'SMB2_QFS_attr_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5562:1: warning: symbol 'smb2_lockv_final' was not declared. Should it be static? fs/cifs/smb2pdu.c:5654:1: warning: symbol 'SMB2_lease_break_final' was not declared. Should it be static? Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> --- smb2ops.c | 4 ++-- smb2pdu.c | 34 +++++++++++++++++----------------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 19d2e746d7802..3a224f91fc87e 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2667,7 +2667,7 @@ smb2_set_next_command(struct cifs_tcon *tcon, struct smb_rqst *rqst) * Passes the query info response back to the caller on success. * Caller need to free this with free_rsp_buf(). */ -int +static int smb2_query_info_compound_final(const unsigned int xid, struct cifs_tcon *tcon, __le16 *utf16_path, u32 desired_access, u32 class, u32 type, u32 output_len, @@ -3280,7 +3280,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, return rc; } -int +static int smb2_query_reparse_tag_final(const unsigned int xid, struct cifs_tcon *tcon, struct cifs_sb_info *cifs_sb, const char *full_path, __u32 *tag) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index dbf679a5da6cf..992a2faedd652 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -2475,7 +2475,7 @@ alloc_path_with_tree_prefix(__le16 **out_path, int *out_size, int *out_len, return 0; } -int smb311_posix_mkdir_final(const unsigned int xid, struct inode *inode, +static int smb311_posix_mkdir_final(const unsigned int xid, struct inode *inode, umode_t mode, struct cifs_tcon *tcon, const char *full_path, struct cifs_sb_info *cifs_sb) @@ -2839,7 +2839,7 @@ SMB2_open_free(struct smb_rqst *rqst) } int -SMB2_open_final(const unsigned int xid, struct cifs_open_parms *oparms, __le16 *path, +static SMB2_open_final(const unsigned int xid, struct cifs_open_parms *oparms, __le16 *path, __u8 *oplock, struct smb2_file_all_info *buf, struct create_posix_rsp *posix, struct kvec *err_iov, int *buftype) @@ -3053,7 +3053,7 @@ SMB2_ioctl_free(struct smb_rqst *rqst) * SMB2 IOCTL is used for both IOCTLs and FSCTLs */ int -SMB2_ioctl_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, +static SMB2_ioctl_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, u32 opcode, bool is_fsctl, char *in_data, u32 indatalen, u32 max_out_data_len, char **out_data, u32 *plen /* returned data len */) @@ -3244,7 +3244,7 @@ SMB2_close_free(struct smb_rqst *rqst) } int -__SMB2_close_final(const unsigned int xid, struct cifs_tcon *tcon, +static __SMB2_close_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, struct smb2_file_network_open_info *pbuf) { @@ -3638,7 +3638,7 @@ SMB2_notify_init(const unsigned int xid, struct smb_rqst *rqst, } int -SMB2_change_notify_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_change_notify_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, bool watch_tree, u32 completion_filter) { @@ -3867,7 +3867,7 @@ SMB2_flush_init(const unsigned int xid, struct smb_rqst *rqst, } int -SMB2_flush_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, +static SMB2_flush_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid) { struct cifs_ses *ses = tcon->ses; @@ -4114,7 +4114,7 @@ smb2_readv_callback(struct mid_q_entry *mid) add_credits(server, &credits, 0); } -int +static int smb2_async_readv_final(struct cifs_readdata *rdata) { int rc, flags = 0; @@ -4202,7 +4202,7 @@ smb2_async_readv(struct cifs_readdata *rdata) } int -SMB2_read_final(const unsigned int xid, struct cifs_io_parms *io_parms, +static SMB2_read_final(const unsigned int xid, struct cifs_io_parms *io_parms, unsigned int *nbytes, char **buf, int *buf_type) { struct smb_rqst rqst; @@ -4384,7 +4384,7 @@ smb2_writev_callback(struct mid_q_entry *mid) add_credits(server, &credits, 0); } -int +static int smb2_async_writev_final(struct cifs_writedata *wdata, void (*release)(struct kref *kref)) { @@ -4539,7 +4539,7 @@ smb2_async_writev(struct cifs_writedata *wdata, } int -SMB2_write_final(const unsigned int xid, struct cifs_io_parms *io_parms, +static SMB2_write_final(const unsigned int xid, struct cifs_io_parms *io_parms, unsigned int *nbytes, struct kvec *iov, int n_vec) { struct smb_rqst rqst; @@ -4943,7 +4943,7 @@ smb2_parse_query_directory(struct cifs_tcon *tcon, } int -SMB2_query_directory_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_query_directory_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, int index, struct cifs_search_info *srch_inf) { @@ -5197,7 +5197,7 @@ SMB2_set_ea(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_oplock_break_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_oplock_break_final(const unsigned int xid, struct cifs_tcon *tcon, const u64 persistent_fid, const u64 volatile_fid, __u8 oplock_level) { @@ -5330,7 +5330,7 @@ build_qfs_info_req(struct kvec *iov, struct cifs_tcon *tcon, } int -SMB311_posix_qfs_info_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB311_posix_qfs_info_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, struct kstatfs *fsdata) { struct smb_rqst rqst; @@ -5395,7 +5395,7 @@ SMB311_posix_qfs_info(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_QFS_info_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_QFS_info_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, struct kstatfs *fsdata) { struct smb_rqst rqst; @@ -5460,7 +5460,7 @@ SMB2_QFS_info(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_QFS_attr_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_QFS_attr_final(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid, int level) { struct smb_rqst rqst; @@ -5558,7 +5558,7 @@ SMB2_QFS_attr(const unsigned int xid, struct cifs_tcon *tcon, return rc; } -int +static int smb2_lockv_final(const unsigned int xid, struct cifs_tcon *tcon, const __u64 persist_fid, const __u64 volatile_fid, const __u32 pid, const __u32 num_lock, struct smb2_lock_element *buf) @@ -5651,7 +5651,7 @@ SMB2_lock(const unsigned int xid, struct cifs_tcon *tcon, } int -SMB2_lease_break_final(const unsigned int xid, struct cifs_tcon *tcon, +static SMB2_lease_break_final(const unsigned int xid, struct cifs_tcon *tcon, __u8 *lease_key, const __le32 lease_state) { struct smb_rqst rqst; ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-28 3:37 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-04-28 3:37 [cifs:for-next 41/41] fs/cifs/smb2ops.c:2671:1: sparse: sparse: symbol 'smb2_query_info_compound_final' was not declared. Should it be static? kernel test robot 2021-04-28 3:37 ` kernel test robot 2021-04-28 3:37 ` [RFC PATCH cifs] cifs: smb2_query_info_compound_final can be static kernel test robot 2021-04-28 3:37 ` kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.