All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <monstr@monstr.eu>
Subject: [xlnx:pr/142 11850/12170] drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock'
Date: Fri, 30 Apr 2021 14:01:40 +0800	[thread overview]
Message-ID: <202104301434.hPIcGVZ4-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4989 bytes --]

Hi Raviteja,

FYI, the error/warning still remains.

tree:   https://github.com/Xilinx/linux-xlnx pr/142
head:   d7991de841c2c41ac347bf1f519941fcaa15df04
commit: a6aea4afc0f41390d36b593f455902b6fdd75685 [11850/12170] regulator: da9121: Use core regulator lock
config: x86_64-randconfig-a015-20210429 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8f5a2a5836cc8e4c1def2bdeb022e7b496623439)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/Xilinx/linux-xlnx/commit/a6aea4afc0f41390d36b593f455902b6fdd75685
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx pr/142
        git checkout a6aea4afc0f41390d36b593f455902b6fdd75685
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock' [-Werror,-Wimplicit-function-declaration]
                   regulator_lock(rdev);
                   ^
>> drivers/regulator/da9121-regulator.c:750:3: error: implicit declaration of function 'regulator_unlock' [-Werror,-Wimplicit-function-declaration]
                   regulator_unlock(rdev);
                   ^
   drivers/regulator/da9121-regulator.c:750:3: note: did you mean 'regulator_lock'?
   drivers/regulator/da9121-regulator.c:748:3: note: 'regulator_lock' declared here
                   regulator_lock(rdev);
                   ^
   2 errors generated.


vim +/regulator_lock +748 drivers/regulator/da9121-regulator.c

   676	
   677	static inline int da9121_handle_notifier(
   678			struct da9121 *chip, struct regulator_dev *rdev,
   679			unsigned int event_bank, unsigned int event, unsigned int ebit)
   680	{
   681		enum { R0 = 0, R1, R2, REG_MAX_NUM };
   682		unsigned long notification = 0;
   683		int ret = 0;
   684	
   685		if (event & ebit) {
   686			switch (event_bank) {
   687			case DA9121_REG_SYS_EVENT_0:
   688				switch (event & ebit) {
   689				case DA9121_MASK_SYS_EVENT_0_E_TEMP_CRIT:
   690					chip->persistent[R0] |= DA9121_MASK_SYS_EVENT_0_E_TEMP_CRIT;
   691					notification |= REGULATOR_EVENT_OVER_TEMP |
   692							REGULATOR_EVENT_DISABLE;
   693					break;
   694				case DA9121_MASK_SYS_EVENT_0_E_TEMP_WARN:
   695					chip->persistent[R0] |= DA9121_MASK_SYS_EVENT_0_E_TEMP_WARN;
   696					notification |= REGULATOR_EVENT_OVER_TEMP;
   697					break;
   698				default:
   699					dev_warn(chip->dev,
   700						 "Unhandled event in bank0 0x%02x\n",
   701						 event & ebit);
   702					ret = -EINVAL;
   703					break;
   704				}
   705				break;
   706			case DA9121_REG_SYS_EVENT_1:
   707				switch (event & ebit) {
   708				case DA9121_MASK_SYS_EVENT_1_E_OV1:
   709					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_OV1;
   710					notification |= REGULATOR_EVENT_REGULATION_OUT;
   711					break;
   712				case DA9121_MASK_SYS_EVENT_1_E_UV1:
   713					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_UV1;
   714					notification |= REGULATOR_EVENT_UNDER_VOLTAGE;
   715					break;
   716				case DA9121_MASK_SYS_EVENT_1_E_OC1:
   717					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_OC1;
   718					notification |= REGULATOR_EVENT_OVER_CURRENT;
   719					break;
   720				case DA9xxx_MASK_SYS_EVENT_1_E_OV2:
   721					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_OV2;
   722					notification |= REGULATOR_EVENT_REGULATION_OUT;
   723					break;
   724				case DA9xxx_MASK_SYS_EVENT_1_E_UV2:
   725					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_UV2;
   726					notification |= REGULATOR_EVENT_UNDER_VOLTAGE;
   727					break;
   728				case DA9xxx_MASK_SYS_EVENT_1_E_OC2:
   729					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_OC2;
   730					notification |= REGULATOR_EVENT_OVER_CURRENT;
   731					break;
   732				default:
   733					dev_warn(chip->dev,
   734						 "Unhandled event in bank1 0x%02x\n",
   735						 event & ebit);
   736					ret = -EINVAL;
   737					break;
   738				}
   739				break;
   740			default:
   741				dev_warn(chip->dev,
   742					 "Unhandled event bank 0x%02x\n", event_bank);
   743				ret = -EINVAL;
   744				goto error;
   745				break;
   746			}
   747	
 > 748			regulator_lock(rdev);
   749			regulator_notifier_call_chain(rdev, notification, NULL);
 > 750			regulator_unlock(rdev);
   751		}
   752	
   753	error:
   754		return ret;
   755	}
   756	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32891 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [xlnx:pr/142 11850/12170] drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock'
Date: Fri, 30 Apr 2021 14:01:40 +0800	[thread overview]
Message-ID: <202104301434.hPIcGVZ4-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 5117 bytes --]

Hi Raviteja,

FYI, the error/warning still remains.

tree:   https://github.com/Xilinx/linux-xlnx pr/142
head:   d7991de841c2c41ac347bf1f519941fcaa15df04
commit: a6aea4afc0f41390d36b593f455902b6fdd75685 [11850/12170] regulator: da9121: Use core regulator lock
config: x86_64-randconfig-a015-20210429 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8f5a2a5836cc8e4c1def2bdeb022e7b496623439)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/Xilinx/linux-xlnx/commit/a6aea4afc0f41390d36b593f455902b6fdd75685
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx pr/142
        git checkout a6aea4afc0f41390d36b593f455902b6fdd75685
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock' [-Werror,-Wimplicit-function-declaration]
                   regulator_lock(rdev);
                   ^
>> drivers/regulator/da9121-regulator.c:750:3: error: implicit declaration of function 'regulator_unlock' [-Werror,-Wimplicit-function-declaration]
                   regulator_unlock(rdev);
                   ^
   drivers/regulator/da9121-regulator.c:750:3: note: did you mean 'regulator_lock'?
   drivers/regulator/da9121-regulator.c:748:3: note: 'regulator_lock' declared here
                   regulator_lock(rdev);
                   ^
   2 errors generated.


vim +/regulator_lock +748 drivers/regulator/da9121-regulator.c

   676	
   677	static inline int da9121_handle_notifier(
   678			struct da9121 *chip, struct regulator_dev *rdev,
   679			unsigned int event_bank, unsigned int event, unsigned int ebit)
   680	{
   681		enum { R0 = 0, R1, R2, REG_MAX_NUM };
   682		unsigned long notification = 0;
   683		int ret = 0;
   684	
   685		if (event & ebit) {
   686			switch (event_bank) {
   687			case DA9121_REG_SYS_EVENT_0:
   688				switch (event & ebit) {
   689				case DA9121_MASK_SYS_EVENT_0_E_TEMP_CRIT:
   690					chip->persistent[R0] |= DA9121_MASK_SYS_EVENT_0_E_TEMP_CRIT;
   691					notification |= REGULATOR_EVENT_OVER_TEMP |
   692							REGULATOR_EVENT_DISABLE;
   693					break;
   694				case DA9121_MASK_SYS_EVENT_0_E_TEMP_WARN:
   695					chip->persistent[R0] |= DA9121_MASK_SYS_EVENT_0_E_TEMP_WARN;
   696					notification |= REGULATOR_EVENT_OVER_TEMP;
   697					break;
   698				default:
   699					dev_warn(chip->dev,
   700						 "Unhandled event in bank0 0x%02x\n",
   701						 event & ebit);
   702					ret = -EINVAL;
   703					break;
   704				}
   705				break;
   706			case DA9121_REG_SYS_EVENT_1:
   707				switch (event & ebit) {
   708				case DA9121_MASK_SYS_EVENT_1_E_OV1:
   709					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_OV1;
   710					notification |= REGULATOR_EVENT_REGULATION_OUT;
   711					break;
   712				case DA9121_MASK_SYS_EVENT_1_E_UV1:
   713					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_UV1;
   714					notification |= REGULATOR_EVENT_UNDER_VOLTAGE;
   715					break;
   716				case DA9121_MASK_SYS_EVENT_1_E_OC1:
   717					chip->persistent[R1] |= DA9121_MASK_SYS_EVENT_1_E_OC1;
   718					notification |= REGULATOR_EVENT_OVER_CURRENT;
   719					break;
   720				case DA9xxx_MASK_SYS_EVENT_1_E_OV2:
   721					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_OV2;
   722					notification |= REGULATOR_EVENT_REGULATION_OUT;
   723					break;
   724				case DA9xxx_MASK_SYS_EVENT_1_E_UV2:
   725					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_UV2;
   726					notification |= REGULATOR_EVENT_UNDER_VOLTAGE;
   727					break;
   728				case DA9xxx_MASK_SYS_EVENT_1_E_OC2:
   729					chip->persistent[R1] |= DA9xxx_MASK_SYS_EVENT_1_E_OC2;
   730					notification |= REGULATOR_EVENT_OVER_CURRENT;
   731					break;
   732				default:
   733					dev_warn(chip->dev,
   734						 "Unhandled event in bank1 0x%02x\n",
   735						 event & ebit);
   736					ret = -EINVAL;
   737					break;
   738				}
   739				break;
   740			default:
   741				dev_warn(chip->dev,
   742					 "Unhandled event bank 0x%02x\n", event_bank);
   743				ret = -EINVAL;
   744				goto error;
   745				break;
   746			}
   747	
 > 748			regulator_lock(rdev);
   749			regulator_notifier_call_chain(rdev, notification, NULL);
 > 750			regulator_unlock(rdev);
   751		}
   752	
   753	error:
   754		return ret;
   755	}
   756	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32891 bytes --]

             reply	other threads:[~2021-04-30  6:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30  6:01 kernel test robot [this message]
2021-04-30  6:01 ` [xlnx:pr/142 11850/12170] drivers/regulator/da9121-regulator.c:748:3: error: implicit declaration of function 'regulator_lock' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104301434.hPIcGVZ4-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=monstr@monstr.eu \
    --cc=raviteja.narayanam@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.