From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: brouer@redhat.com, Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Sven Auhagen <sven.auhagen@voleatech.de>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
bpf@vger.kernel.org,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
Tyler S <tylerjstachecki@gmail.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: Re: [PATCH net v4] igb: Fix XDP with PTP enabled
Date: Tue, 4 May 2021 10:28:27 +0200 [thread overview]
Message-ID: <20210504102827.342f6302@carbon> (raw)
In-Reply-To: <20210503072800.79936-1-kurt@linutronix.de>
On Mon, 3 May 2021 09:28:00 +0200
Kurt Kanzenbach <kurt@linutronix.de> wrote:
> When using native XDP with the igb driver, the XDP frame data doesn't point to
> the beginning of the packet. It's off by 16 bytes. Everything works as expected
> with XDP skb mode.
>
> Actually these 16 bytes are used to store the packet timestamps. Therefore, pull
> the timestamp before executing any XDP operations and adjust all other code
> accordingly. The igc driver does it like that as well.
>
> Tested with Intel i210 card and AF_XDP sockets.
>
> Fixes: 9cbc948b5a20 ("igb: add XDP support")
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Thanks for fixing this!
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
I expect that we/I will (soon) play with getting this area that is
stored in front of the packet (the XDP data_meta area) described via
BTF. This way both xdp_frame and AF_XDP can get structured access (e.g.
to the PTP timestamp in this case).
I'll be adding my notes on this project here:
https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/
Looking forward to collaborate on this with you :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v4] igb: Fix XDP with PTP enabled
Date: Tue, 4 May 2021 10:28:27 +0200 [thread overview]
Message-ID: <20210504102827.342f6302@carbon> (raw)
In-Reply-To: <20210503072800.79936-1-kurt@linutronix.de>
On Mon, 3 May 2021 09:28:00 +0200
Kurt Kanzenbach <kurt@linutronix.de> wrote:
> When using native XDP with the igb driver, the XDP frame data doesn't point to
> the beginning of the packet. It's off by 16 bytes. Everything works as expected
> with XDP skb mode.
>
> Actually these 16 bytes are used to store the packet timestamps. Therefore, pull
> the timestamp before executing any XDP operations and adjust all other code
> accordingly. The igc driver does it like that as well.
>
> Tested with Intel i210 card and AF_XDP sockets.
>
> Fixes: 9cbc948b5a20 ("igb: add XDP support")
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Thanks for fixing this!
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
I expect that we/I will (soon) play with getting this area that is
stored in front of the packet (the XDP data_meta area) described via
BTF. This way both xdp_frame and AF_XDP can get structured access (e.g.
to the PTP timestamp in this case).
I'll be adding my notes on this project here:
https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/
Looking forward to collaborate on this with you :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2021-05-04 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 7:28 [PATCH net v4] igb: Fix XDP with PTP enabled Kurt Kanzenbach
2021-05-03 7:28 ` [Intel-wired-lan] " Kurt Kanzenbach
2021-05-04 8:28 ` Jesper Dangaard Brouer [this message]
2021-05-04 8:28 ` Jesper Dangaard Brouer
2021-05-19 13:34 ` Jesper Dangaard Brouer
2021-05-19 13:34 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2021-05-19 18:46 ` Nguyen, Anthony L
2021-05-19 18:46 ` [Intel-wired-lan] " Nguyen, Anthony L
2021-05-20 6:20 ` Kurt Kanzenbach
2021-05-20 6:20 ` [Intel-wired-lan] " Kurt Kanzenbach
2021-06-03 11:30 ` Penigalapati, Sandeep
2021-06-03 11:30 ` [Intel-wired-lan] " Penigalapati, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504102827.342f6302@carbon \
--to=brouer@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sven.auhagen@voleatech.de \
--cc=tylerjstachecki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.