From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC 1/2] ARM: dts: r8a7778: Correct internal delay for i2c[123]
Date: Wed, 5 May 2021 09:13:23 +0200 [thread overview]
Message-ID: <20210505071323.GA1009@ninjato> (raw)
In-Reply-To: <1eac63f15a776e492ff8a2d8447c5e1019982dd1.1620138979.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On Tue, May 04, 2021 at 04:41:24PM +0200, Geert Uytterhoeven wrote:
> According to the R-Car M1A Hardware User's Manual Rev. 1.00, the LSI
> internal delay for I2C instances 1 to 3 is 5 ns (typ.), which differs
> from the default 50 ns as specified for instance 0.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
I wonder if we shouldn't also specify the 50ns for IIC0 because it is
describing the HW instead of relying on the Linux-only default value in
the driver? Other than that:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-05 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:41 [PATCH/RFC 0/2] ARM: dts: rcar-gen1: Correct internal delay for i2c[123] Geert Uytterhoeven
2021-05-04 14:41 ` [PATCH/RFC 1/2] ARM: dts: r8a7778: " Geert Uytterhoeven
2021-05-05 7:13 ` Wolfram Sang [this message]
2021-05-05 7:41 ` Geert Uytterhoeven
2021-05-04 14:41 ` [PATCH/RFC 2/2] ARM: dts: r8a7779: " Geert Uytterhoeven
2021-05-05 7:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505071323.GA1009@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.