From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Maxime Ripard <maxime@cerno.tech>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Qinglang Miao <miaoqinglang@huawei.com>,
Hongbo Yao <yaohongbo@huawei.com>,
linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM
ADRENO GPU),
freedreno@lists.freedesktop.org (open list:DRM DRIVER FOR MSM
ADRENO GPU), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/2] drm/msm/dpu: Wire up needs_dirtyfb
Date: Sat, 8 May 2021 12:56:39 -0700 [thread overview]
Message-ID: <20210508195641.397198-3-robdclark@gmail.com> (raw)
In-Reply-To: <20210508195641.397198-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 5a74f93e29da..868ee6136438 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -143,6 +143,19 @@ static bool dpu_crtc_get_scanout_position(struct drm_crtc *crtc,
return true;
}
+static bool dpu_crtc_needs_dirtyfb(struct drm_crtc *crtc)
+{
+ struct drm_encoder *encoder;
+
+ drm_for_each_encoder_mask (encoder, crtc->dev, crtc->state->encoder_mask) {
+ if (dpu_encoder_get_intf_mode(encoder) == INTF_MODE_CMD) {
+ return true;
+ }
+ }
+
+ return false;
+}
+
static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer,
struct dpu_plane_state *pstate, struct dpu_format *format)
{
@@ -1343,6 +1356,7 @@ static const struct drm_crtc_helper_funcs dpu_crtc_helper_funcs = {
.atomic_begin = dpu_crtc_atomic_begin,
.atomic_flush = dpu_crtc_atomic_flush,
.get_scanout_position = dpu_crtc_get_scanout_position,
+ .needs_dirtyfb = dpu_crtc_needs_dirtyfb,
};
/* initialize crtc */
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<freedreno@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
Hongbo Yao <yaohongbo@huawei.com>,
open list <linux-kernel@vger.kernel.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Qinglang Miao <miaoqinglang@huawei.com>,
Maxime Ripard <maxime@cerno.tech>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Sean Paul <sean@poorly.run>
Subject: [PATCH 2/2] drm/msm/dpu: Wire up needs_dirtyfb
Date: Sat, 8 May 2021 12:56:39 -0700 [thread overview]
Message-ID: <20210508195641.397198-3-robdclark@gmail.com> (raw)
In-Reply-To: <20210508195641.397198-1-robdclark@gmail.com>
From: Rob Clark <robdclark@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 5a74f93e29da..868ee6136438 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -143,6 +143,19 @@ static bool dpu_crtc_get_scanout_position(struct drm_crtc *crtc,
return true;
}
+static bool dpu_crtc_needs_dirtyfb(struct drm_crtc *crtc)
+{
+ struct drm_encoder *encoder;
+
+ drm_for_each_encoder_mask (encoder, crtc->dev, crtc->state->encoder_mask) {
+ if (dpu_encoder_get_intf_mode(encoder) == INTF_MODE_CMD) {
+ return true;
+ }
+ }
+
+ return false;
+}
+
static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer,
struct dpu_plane_state *pstate, struct dpu_format *format)
{
@@ -1343,6 +1356,7 @@ static const struct drm_crtc_helper_funcs dpu_crtc_helper_funcs = {
.atomic_begin = dpu_crtc_atomic_begin,
.atomic_flush = dpu_crtc_atomic_flush,
.get_scanout_position = dpu_crtc_get_scanout_position,
+ .needs_dirtyfb = dpu_crtc_needs_dirtyfb,
};
/* initialize crtc */
--
2.30.2
next prev parent reply other threads:[~2021-05-08 19:53 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 19:56 [PATCH 0/2] drm: Fix atomic helper dirtyfb stalls Rob Clark
2021-05-08 19:56 ` Rob Clark
2021-05-08 19:56 ` [PATCH 1/2] drm: Fix " Rob Clark
2021-05-08 19:56 ` Rob Clark
2021-05-10 16:14 ` Daniel Vetter
2021-05-10 16:14 ` Daniel Vetter
2021-05-10 16:16 ` Daniel Vetter
2021-05-10 16:55 ` Rob Clark
2021-05-10 16:55 ` Rob Clark
2021-05-10 17:43 ` Daniel Vetter
2021-05-10 17:43 ` Daniel Vetter
2021-05-10 19:06 ` Rob Clark
2021-05-10 19:06 ` Rob Clark
2021-05-11 16:44 ` Daniel Vetter
2021-05-11 16:44 ` Daniel Vetter
2021-05-11 17:19 ` Rob Clark
2021-05-11 17:19 ` Rob Clark
2021-05-11 17:21 ` Daniel Vetter
2021-05-11 17:21 ` Daniel Vetter
2021-05-11 17:42 ` Rob Clark
2021-05-11 17:42 ` Rob Clark
2021-05-11 17:50 ` Daniel Vetter
2021-05-11 17:50 ` Daniel Vetter
2021-05-12 8:23 ` Pekka Paalanen
2021-05-12 8:23 ` Pekka Paalanen
2021-05-12 8:44 ` Daniel Vetter
2021-05-12 8:44 ` Daniel Vetter
2021-05-12 9:46 ` Pekka Paalanen
2021-05-12 9:46 ` Pekka Paalanen
2021-05-12 10:35 ` Daniel Vetter
2021-05-12 10:35 ` Daniel Vetter
2021-05-12 14:57 ` Rob Clark
2021-05-12 14:57 ` Rob Clark
2021-05-14 7:54 ` Pekka Paalanen
2021-05-14 7:54 ` Pekka Paalanen
2021-05-14 14:43 ` Rob Clark
2021-05-14 14:43 ` Rob Clark
2021-05-08 19:56 ` Rob Clark [this message]
2021-05-08 19:56 ` [PATCH 2/2] drm/msm/dpu: Wire up needs_dirtyfb Rob Clark
2021-05-09 15:38 ` Tested houdek.ryan
2021-05-09 15:38 ` Tested houdek.ryan
2021-05-10 15:26 ` Tested Alex Deucher
2021-05-10 15:26 ` Tested Alex Deucher
2021-05-09 16:28 ` [PATCH 2/2] drm/msm/dpu: Wire up needs_dirtyfb Rob Clark
2021-05-09 16:28 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210508195641.397198-3-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=miaoqinglang@huawei.com \
--cc=robdclark@chromium.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=yaohongbo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.