From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Ashish Vara <ashishvara89@yahoo.com>
Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
coiby.xu@gmail.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning
Date: Mon, 10 May 2021 16:55:14 +0200 [thread overview]
Message-ID: <20210510145513.GD4434@agape.jhs> (raw)
In-Reply-To: <eb4c5af2-2980-a0f1-4708-a48da9570225@yahoo.com>
Hi Ashish,
in your subject line there is one Subject: too many
On Mon, May 10, 2021 at 08:13:37PM +0530, Ashish Vara wrote:
> From: Ashish Vara <ashishvara89@yahoo.com>
>
> removed unnecessary out of memory message to fix coding style warning.
>
> Signed-off-by: Ashish Vara <ashishvara89@yahoo.com>
> ---
> drivers/staging/qlge/qlge_main.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index c9dc6a852af4..a9e0bccc52d0 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -2796,12 +2796,8 @@ static int qlge_init_bq(struct qlge_bq *bq)
>
> bq->base = dma_alloc_coherent(&qdev->pdev->dev, QLGE_BQ_SIZE,
> &bq->base_dma, GFP_ATOMIC);
> - if (!bq->base) {
> - netif_err(qdev, ifup, qdev->ndev,
> - "ring %u %s allocation failed.\n", rx_ring->cq_id,
> - bq_type_name[bq->type]);
> + if (!bq->base)
> return -ENOMEM;
> - }
>
> bq->queue = kmalloc_array(QLGE_BQ_LEN, sizeof(struct qlge_bq_desc),
> GFP_KERNEL);
> --
> 2.30.2
>
thank you,
fabio
prev parent reply other threads:[~2021-05-10 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <eb4c5af2-2980-a0f1-4708-a48da9570225.ref@yahoo.com>
2021-05-10 14:43 ` Subject: [PATCH] staging: qlge: removed unnecessary debug message to fix coding style warning Ashish Vara
2021-05-10 14:55 ` Fabio Aiuto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510145513.GD4434@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=ashishvara89@yahoo.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.