From: Olivier Matz <olivier.matz@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, ian.stokes@intel.com, ktraynor@redhat.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net: add endianness annotations to ethernet headers
Date: Tue, 11 May 2021 15:09:30 +0200 [thread overview]
Message-ID: <20210511130930.GH1726@platinum> (raw)
In-Reply-To: <20210506151426.28202-2-david.marchand@redhat.com>
On Thu, May 06, 2021 at 05:14:25PM +0200, David Marchand wrote:
> Spotted by sparse in OVS build:
>
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:789:27:
> error: incorrect type in initializer (different base types)
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:789:27:
> expected unsigned short [usertype] ether_type
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:789:27:
> got restricted ovs_be16 [usertype]
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:829:25:
> error: incorrect type in initializer (different base types)
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:829:25:
> expected unsigned short [usertype] vlan_tci
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:829:25:
> got restricted ovs_be16 [usertype]
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:830:26:
> error: incorrect type in initializer (different base types)
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:830:26:
> expected unsigned short [usertype] eth_proto
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h:830:26:
> got restricted ovs_be16 [usertype]
>
> This was not caught before as no code in headers was using those fields.
> This changed with commit 6f2168b69aee ("ethdev: reuse ethernet header
> definition in flow item") and commit a56a262e3408 ("ethdev: reuse VLAN
> header definition in flow item").
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
I was wondering if it wouldn't be safer to change the initializer
instead of the structure definition, to avoid any API breakage.
But after some off-list discussions, it appears that there is no API
breakage (rte_be16_t is a typedef to uint16_t), and this kind of changes
was already done in the past.
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2021-05-11 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 15:14 [dpdk-dev] [PATCH 0/2] 21.05 fixes for OVS David Marchand
2021-05-06 15:14 ` [dpdk-dev] [PATCH 1/2] net: add endianness annotations to ethernet headers David Marchand
2021-05-11 13:09 ` Olivier Matz [this message]
2021-05-06 15:14 ` [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD David Marchand
2021-05-06 22:23 ` Dmitry Kozlyuk
2021-05-07 9:06 ` David Marchand
2021-05-07 19:12 ` Ben Pfaff
2021-05-07 19:13 ` Ben Pfaff
2021-05-10 11:25 ` David Marchand
2021-05-11 13:09 ` Olivier Matz
2021-05-07 12:21 ` [dpdk-dev] [PATCH 0/2] 21.05 fixes for OVS David Marchand
2021-05-07 13:15 ` Aaron Conole
2021-05-11 13:40 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511130930.GH1726@platinum \
--to=olivier.matz@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.