From: Olivier Matz <olivier.matz@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, ian.stokes@intel.com, ktraynor@redhat.com,
Ranjit Menon <ranjit.menon@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD
Date: Tue, 11 May 2021 15:09:44 +0200 [thread overview]
Message-ID: <20210511130944.GI1726@platinum> (raw)
In-Reply-To: <20210506151426.28202-3-david.marchand@redhat.com>
On Thu, May 06, 2021 at 05:14:26PM +0200, David Marchand wrote:
> Spotted by sparse in OVS build:
> ../../lib/netdev-dpdk.c: note: in included file (through
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h,
> /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h, ...):
> ../../include/sparse/arpa/inet.h:22:2: error: "Must include
> <netinet/in.h> before <arpa/inet.h> for FreeBSD support"
>
> This is a check enforced by OVS itself.
> See [1] for some context.
>
> 1: https://github.com/openvswitch/ovs/commit/b2befd5bb2db
>
> Fixes: 89813a522e68 ("net: provide IP-related API on any OS")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2021-05-11 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 15:14 [dpdk-dev] [PATCH 0/2] 21.05 fixes for OVS David Marchand
2021-05-06 15:14 ` [dpdk-dev] [PATCH 1/2] net: add endianness annotations to ethernet headers David Marchand
2021-05-11 13:09 ` Olivier Matz
2021-05-06 15:14 ` [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD David Marchand
2021-05-06 22:23 ` Dmitry Kozlyuk
2021-05-07 9:06 ` David Marchand
2021-05-07 19:12 ` Ben Pfaff
2021-05-07 19:13 ` Ben Pfaff
2021-05-10 11:25 ` David Marchand
2021-05-11 13:09 ` Olivier Matz [this message]
2021-05-07 12:21 ` [dpdk-dev] [PATCH 0/2] 21.05 fixes for OVS David Marchand
2021-05-07 13:15 ` Aaron Conole
2021-05-11 13:40 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511130944.GI1726@platinum \
--to=olivier.matz@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ian.stokes@intel.com \
--cc=ktraynor@redhat.com \
--cc=ranjit.menon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.