From: Daniel Schaefer <git@danielschaefer.me>
To: opensbi@lists.infradead.org
Subject: [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly
Date: Wed, 12 May 2021 19:12:47 +0800 [thread overview]
Message-ID: <20210512111247.28416-1-git@danielschaefer.me> (raw)
From: Daniel Schaefer <daniel.schaefer@hpe.com>
This file uses `sbi_strncpy`, `sbi_strncmp` and `sbi_memset`, which are
defined in `sbi_strings.h`.
It should already be transitively included via `#include
<sbi/sbi_scratch.h>` but my toolchain doesn't do that for some reason.
Perhaps because the functions that refer to them are `static`?
Anyways, it would be good to directly reference the header here.
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Anup Patel <anup.patel@wdc.com>
Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
---
lib/utils/fdt/fdt_domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/utils/fdt/fdt_domain.c b/lib/utils/fdt/fdt_domain.c
index 95c195d65238..b2b5f6196a1a 100644
--- a/lib/utils/fdt/fdt_domain.c
+++ b/lib/utils/fdt/fdt_domain.c
@@ -13,6 +13,7 @@
#include <sbi/sbi_error.h>
#include <sbi/sbi_hartmask.h>
#include <sbi/sbi_scratch.h>
+#include <sbi/sbi_string.h>
#include <sbi_utils/fdt/fdt_domain.h>
#include <sbi_utils/fdt/fdt_helper.h>
--
2.30.1
next reply other threads:[~2021-05-12 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 11:12 Daniel Schaefer [this message]
2021-05-14 11:34 ` [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly Anup Patel
2021-05-15 18:13 ` Daniel Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512111247.28416-1-git@danielschaefer.me \
--to=git@danielschaefer.me \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.