* [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly
@ 2021-05-12 11:12 Daniel Schaefer
2021-05-14 11:34 ` Anup Patel
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Schaefer @ 2021-05-12 11:12 UTC (permalink / raw)
To: opensbi
From: Daniel Schaefer <daniel.schaefer@hpe.com>
This file uses `sbi_strncpy`, `sbi_strncmp` and `sbi_memset`, which are
defined in `sbi_strings.h`.
It should already be transitively included via `#include
<sbi/sbi_scratch.h>` but my toolchain doesn't do that for some reason.
Perhaps because the functions that refer to them are `static`?
Anyways, it would be good to directly reference the header here.
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Anup Patel <anup.patel@wdc.com>
Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
---
lib/utils/fdt/fdt_domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/utils/fdt/fdt_domain.c b/lib/utils/fdt/fdt_domain.c
index 95c195d65238..b2b5f6196a1a 100644
--- a/lib/utils/fdt/fdt_domain.c
+++ b/lib/utils/fdt/fdt_domain.c
@@ -13,6 +13,7 @@
#include <sbi/sbi_error.h>
#include <sbi/sbi_hartmask.h>
#include <sbi/sbi_scratch.h>
+#include <sbi/sbi_string.h>
#include <sbi_utils/fdt/fdt_domain.h>
#include <sbi_utils/fdt/fdt_helper.h>
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly
2021-05-12 11:12 [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly Daniel Schaefer
@ 2021-05-14 11:34 ` Anup Patel
2021-05-15 18:13 ` Daniel Schaefer
0 siblings, 1 reply; 3+ messages in thread
From: Anup Patel @ 2021-05-14 11:34 UTC (permalink / raw)
To: opensbi
> -----Original Message-----
> From: opensbi <opensbi-bounces@lists.infradead.org> On Behalf Of Daniel
> Schaefer
> Sent: 12 May 2021 16:43
> To: opensbi at lists.infradead.org
> Cc: Abner Chang <abner.chang@hpe.com>; Anup Patel
> <Anup.Patel@wdc.com>
> Subject: [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly
>
> From: Daniel Schaefer <daniel.schaefer@hpe.com>
>
> This file uses `sbi_strncpy`, `sbi_strncmp` and `sbi_memset`, which are
> defined in `sbi_strings.h`.
>
> It should already be transitively included via `#include <sbi/sbi_scratch.h>`
> but my toolchain doesn't do that for some reason.
> Perhaps because the functions that refer to them are `static`?
Can you try renaming __STRING_H__ to __SBI_STRING_H__ in sbi_string.h ?
Regards,
Anup
>
> Anyways, it would be good to directly reference the header here.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Anup Patel <anup.patel@wdc.com>
> Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
> ---
> lib/utils/fdt/fdt_domain.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/utils/fdt/fdt_domain.c b/lib/utils/fdt/fdt_domain.c index
> 95c195d65238..b2b5f6196a1a 100644
> --- a/lib/utils/fdt/fdt_domain.c
> +++ b/lib/utils/fdt/fdt_domain.c
> @@ -13,6 +13,7 @@
> #include <sbi/sbi_error.h>
> #include <sbi/sbi_hartmask.h>
> #include <sbi/sbi_scratch.h>
> +#include <sbi/sbi_string.h>
> #include <sbi_utils/fdt/fdt_domain.h>
> #include <sbi_utils/fdt/fdt_helper.h>
>
> --
> 2.30.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly
2021-05-14 11:34 ` Anup Patel
@ 2021-05-15 18:13 ` Daniel Schaefer
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Schaefer @ 2021-05-15 18:13 UTC (permalink / raw)
To: opensbi
On 5/14/21 7:34 PM, Anup Patel wrote:
>
>
>> -----Original Message-----
>> From: opensbi <opensbi-bounces@lists.infradead.org> On Behalf Of Daniel
>> Schaefer
>> Sent: 12 May 2021 16:43
>> To: opensbi at lists.infradead.org
>> Cc: Abner Chang <abner.chang@hpe.com>; Anup Patel
>> <Anup.Patel@wdc.com>
>> Subject: [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly
>>
>> From: Daniel Schaefer <daniel.schaefer@hpe.com>
>>
>> This file uses `sbi_strncpy`, `sbi_strncmp` and `sbi_memset`, which are
>> defined in `sbi_strings.h`.
>>
>> It should already be transitively included via `#include <sbi/sbi_scratch.h>`
>> but my toolchain doesn't do that for some reason.
>> Perhaps because the functions that refer to them are `static`?
>
> Can you try renaming __STRING_H__ to __SBI_STRING_H__ in sbi_string.h ?
That doesn't help, unfortunately.
>
> Regards,
> Anup
>
>>
>> Anyways, it would be good to directly reference the header here.
>>
>> Cc: Abner Chang <abner.chang@hpe.com>
>> Cc: Anup Patel <anup.patel@wdc.com>
>> Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
>> ---
>> lib/utils/fdt/fdt_domain.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/utils/fdt/fdt_domain.c b/lib/utils/fdt/fdt_domain.c index
>> 95c195d65238..b2b5f6196a1a 100644
>> --- a/lib/utils/fdt/fdt_domain.c
>> +++ b/lib/utils/fdt/fdt_domain.c
>> @@ -13,6 +13,7 @@
>> #include <sbi/sbi_error.h>
>> #include <sbi/sbi_hartmask.h>
>> #include <sbi/sbi_scratch.h>
>> +#include <sbi/sbi_string.h>
>> #include <sbi_utils/fdt/fdt_domain.h>
>> #include <sbi_utils/fdt/fdt_helper.h>
>>
>> --
>> 2.30.1
>>
>>
>> --
>> opensbi mailing list
>> opensbi at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/opensbi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-15 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-12 11:12 [PATCH v1 1/1] lib: utils: Include sbi_strings.h directly Daniel Schaefer
2021-05-14 11:34 ` Anup Patel
2021-05-15 18:13 ` Daniel Schaefer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.