All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Cc: eantoranz@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, fabioaiuto83@gmail.com,
	hdegoede@redhat.com, fmdefrancesco@gmail.com,
	marcocesati@gmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Larry.Finger@lwfinger.net
Subject: Re: [PATCH 7/7] Staging: rtl8723bs: fix block comment in HalBtc8723b1Ant.c
Date: Mon, 17 May 2021 13:13:02 +0300	[thread overview]
Message-ID: <20210517101302.GF1955@kadam> (raw)
In-Reply-To: <20210516122927.1132356-8-desmondcheongzx@gmail.com>

On Sun, May 16, 2021 at 08:29:27AM -0400, Desmond Cheong Zhi Xi wrote:
> This commit fixes the following checkpatch.pl warning:
> 
> WARNING: Block comments use * on subsequent lines
> +		/*
> +		CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \
> 
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> index cc7f558903ac..87156b2cd1f0 100644
> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> @@ -2511,10 +2511,10 @@ void EXhalbtc8723b1ant_DisplayCoexInfo(struct btc_coexist *pBtCoexist)
>  		CL_PRINTF(cliBuf);
>  
>  		/*
> -		CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \
> -			pCoexDm->errorCondition);
> -		CL_PRINTF(cliBuf);
> -		*/
> +		 *CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)",
> +		 *	pCoexDm->errorCondition);
> +		 *CL_PRINTF(cliBuf);
> +		 */
>  	}

Always just delete dead code.  Otherwise the patchset seems good.

regards,
dan carpenter

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Cc: gregkh@linuxfoundation.org, marcocesati@gmail.com,
	fabioaiuto83@gmail.com, fmdefrancesco@gmail.com,
	eantoranz@gmail.com, hdegoede@redhat.com,
	Larry.Finger@lwfinger.net, skhan@linuxfoundation.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 7/7] Staging: rtl8723bs: fix block comment in HalBtc8723b1Ant.c
Date: Mon, 17 May 2021 13:13:02 +0300	[thread overview]
Message-ID: <20210517101302.GF1955@kadam> (raw)
In-Reply-To: <20210516122927.1132356-8-desmondcheongzx@gmail.com>

On Sun, May 16, 2021 at 08:29:27AM -0400, Desmond Cheong Zhi Xi wrote:
> This commit fixes the following checkpatch.pl warning:
> 
> WARNING: Block comments use * on subsequent lines
> +		/*
> +		CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \
> 
> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> index cc7f558903ac..87156b2cd1f0 100644
> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> @@ -2511,10 +2511,10 @@ void EXhalbtc8723b1ant_DisplayCoexInfo(struct btc_coexist *pBtCoexist)
>  		CL_PRINTF(cliBuf);
>  
>  		/*
> -		CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \
> -			pCoexDm->errorCondition);
> -		CL_PRINTF(cliBuf);
> -		*/
> +		 *CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)",
> +		 *	pCoexDm->errorCondition);
> +		 *CL_PRINTF(cliBuf);
> +		 */
>  	}

Always just delete dead code.  Otherwise the patchset seems good.

regards,
dan carpenter


  reply	other threads:[~2021-05-17 10:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 12:29 [PATCH 0/7] Staging: rtl8723bs: fix warnings in HalBtc8723b1Ant.c Desmond Cheong Zhi Xi
2021-05-16 12:29 ` Desmond Cheong Zhi Xi
2021-05-16 12:29 ` [PATCH 1/7] Staging: rtl8723bs: remove unnecessary braces " Desmond Cheong Zhi Xi
2021-05-16 12:29   ` Desmond Cheong Zhi Xi
2021-05-16 12:29 ` [PATCH 2/7] Staging: rtl8723bs: fix spaces " Desmond Cheong Zhi Xi
2021-05-16 12:29   ` Desmond Cheong Zhi Xi
2021-05-16 12:29 ` [PATCH 3/7] Staging: rtl8723bs: fix indentation " Desmond Cheong Zhi Xi
2021-05-16 12:29   ` Desmond Cheong Zhi Xi
2021-05-16 12:29 ` [PATCH 4/7] Staging: rtl8723bs: fix comparison formatting " Desmond Cheong Zhi Xi
2021-05-16 12:29   ` Desmond Cheong Zhi Xi
2021-05-16 12:29 ` [PATCH 5/7] Staging: rtl8723bs: add missing blank line " Desmond Cheong Zhi Xi
2021-05-16 12:29   ` Desmond Cheong Zhi Xi
2021-05-16 12:29 ` [PATCH 6/7] Staging: rtl8723bs: fix line continuations " Desmond Cheong Zhi Xi
2021-05-16 12:29   ` Desmond Cheong Zhi Xi
2021-05-16 12:29 ` [PATCH 7/7] Staging: rtl8723bs: fix block comment " Desmond Cheong Zhi Xi
2021-05-16 12:29   ` Desmond Cheong Zhi Xi
2021-05-17 10:13   ` Dan Carpenter [this message]
2021-05-17 10:13     ` Dan Carpenter
2021-05-18  4:00     ` Desmond Cheong Zhi Xi
2021-05-18  4:00       ` Desmond Cheong Zhi Xi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517101302.GF1955@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=desmondcheongzx@gmail.com \
    --cc=eantoranz@gmail.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=marcocesati@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.