From: Lee Jones <lee.jones@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, heiko@sntech.de,
devicetree@vger.kernel.org, tiwai@suse.com, robh+dt@kernel.org,
lgirdwood@gmail.com, linux-rockchip@lists.infradead.org,
broonie@kernel.org, Chris Morgan <macromorgan@hotmail.com>,
jbx6244@gmail.com, maccraft123mc@gmail.com
Subject: Re: [PATCH v11 1/4] mfd: Add Rockchip rk817 audio CODEC support
Date: Wed, 19 May 2021 15:39:28 +0100 [thread overview]
Message-ID: <20210519143928.GG2415519@dell> (raw)
In-Reply-To: <20210515025749.11291-2-macroalpha82@gmail.com>
On Fri, 14 May 2021, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add rk817 codec support cell to rk808 mfd driver.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Tested-by: Maciej Matuszczyk <maccraft123mc@gmail.com>
> ---
> drivers/mfd/rk808.c | 83 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/rk808.h | 81 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 164 insertions(+)
>
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index ad923dd4e007..b94f805719a6 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -65,6 +65,7 @@ static bool rk817_is_volatile_reg(struct device *dev, unsigned int reg)
> switch (reg) {
> case RK817_SECONDS_REG ... RK817_WEEKS_REG:
> case RK817_RTC_STATUS_REG:
> + case RK817_CODEC_DTOP_LPT_SRST:
> case RK817_INT_STS_REG0:
> case RK817_INT_STS_REG1:
> case RK817_INT_STS_REG2:
> @@ -163,6 +164,9 @@ static const struct mfd_cell rk817s[] = {
> .num_resources = ARRAY_SIZE(rk817_rtc_resources),
> .resources = &rk817_rtc_resources[0],
> },
> + {
> + .name = "rk817-codec",
> + },
This should be on a single line please.
Once fixed, please apply my:
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
tiwai@suse.com, heiko@sntech.de, robh+dt@kernel.org,
perex@perex.cz, jbx6244@gmail.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, maccraft123mc@gmail.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v11 1/4] mfd: Add Rockchip rk817 audio CODEC support
Date: Wed, 19 May 2021 15:39:28 +0100 [thread overview]
Message-ID: <20210519143928.GG2415519@dell> (raw)
In-Reply-To: <20210515025749.11291-2-macroalpha82@gmail.com>
On Fri, 14 May 2021, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add rk817 codec support cell to rk808 mfd driver.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Tested-by: Maciej Matuszczyk <maccraft123mc@gmail.com>
> ---
> drivers/mfd/rk808.c | 83 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/rk808.h | 81 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 164 insertions(+)
>
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index ad923dd4e007..b94f805719a6 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -65,6 +65,7 @@ static bool rk817_is_volatile_reg(struct device *dev, unsigned int reg)
> switch (reg) {
> case RK817_SECONDS_REG ... RK817_WEEKS_REG:
> case RK817_RTC_STATUS_REG:
> + case RK817_CODEC_DTOP_LPT_SRST:
> case RK817_INT_STS_REG0:
> case RK817_INT_STS_REG1:
> case RK817_INT_STS_REG2:
> @@ -163,6 +164,9 @@ static const struct mfd_cell rk817s[] = {
> .num_resources = ARRAY_SIZE(rk817_rtc_resources),
> .resources = &rk817_rtc_resources[0],
> },
> + {
> + .name = "rk817-codec",
> + },
This should be on a single line please.
Once fixed, please apply my:
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
tiwai@suse.com, heiko@sntech.de, robh+dt@kernel.org,
perex@perex.cz, jbx6244@gmail.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, maccraft123mc@gmail.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v11 1/4] mfd: Add Rockchip rk817 audio CODEC support
Date: Wed, 19 May 2021 15:39:28 +0100 [thread overview]
Message-ID: <20210519143928.GG2415519@dell> (raw)
In-Reply-To: <20210515025749.11291-2-macroalpha82@gmail.com>
On Fri, 14 May 2021, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add rk817 codec support cell to rk808 mfd driver.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Tested-by: Maciej Matuszczyk <maccraft123mc@gmail.com>
> ---
> drivers/mfd/rk808.c | 83 +++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/rk808.h | 81 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 164 insertions(+)
>
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index ad923dd4e007..b94f805719a6 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -65,6 +65,7 @@ static bool rk817_is_volatile_reg(struct device *dev, unsigned int reg)
> switch (reg) {
> case RK817_SECONDS_REG ... RK817_WEEKS_REG:
> case RK817_RTC_STATUS_REG:
> + case RK817_CODEC_DTOP_LPT_SRST:
> case RK817_INT_STS_REG0:
> case RK817_INT_STS_REG1:
> case RK817_INT_STS_REG2:
> @@ -163,6 +164,9 @@ static const struct mfd_cell rk817s[] = {
> .num_resources = ARRAY_SIZE(rk817_rtc_resources),
> .resources = &rk817_rtc_resources[0],
> },
> + {
> + .name = "rk817-codec",
> + },
This should be on a single line please.
Once fixed, please apply my:
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-05-19 14:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 2:57 [PATCH v11 0/4] ASoC: codecs: add rk817 support Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-15 2:57 ` [PATCH v11 1/4] mfd: Add Rockchip rk817 audio CODEC support Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-19 14:39 ` Lee Jones [this message]
2021-05-19 14:39 ` Lee Jones
2021-05-19 14:39 ` Lee Jones
2021-05-15 2:57 ` [PATCH v11 2/4] ASoC: " Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-15 2:57 ` [PATCH v11 3/4] dt-bindings: " Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-19 14:39 ` Lee Jones
2021-05-19 14:39 ` Lee Jones
2021-05-19 14:39 ` Lee Jones
2021-05-15 2:57 ` [PATCH v11 4/4] arm64: dts: rockchip: add rk817 codec to Odroid Go Chris Morgan
2021-05-15 2:57 ` Chris Morgan
2021-05-15 2:57 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519143928.GG2415519@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.