All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [media-next:master 180/181] drivers/staging/media/hantro/hantro_drv.c:165:3: error: label 'err_cancel_job' used but not defined
Date: Wed, 19 May 2021 20:56:47 +0800	[thread overview]
Message-ID: <202105192044.UM4pvsch-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 9433 bytes --]

tree:   git://linuxtv.org/mchehab/media-next.git master
head:   c4fb2697f420b3c752230d8060801681bc486c04
commit: 9454974c75ddbe0ec82c1bb3f0b5d6f3ce65b8fd [180/181] media: hantro: use pm_runtime_resume_and_get()
config: ia64-randconfig-r002-20210519 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add media-next git://linuxtv.org/mchehab/media-next.git
        git fetch --no-tags media-next master
        git checkout 9454974c75ddbe0ec82c1bb3f0b5d6f3ce65b8fd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:154,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from include/linux/rcuwait.h:6,
                    from include/linux/percpu-rwsem.h:7,
                    from include/linux/fs.h:33,
                    from include/linux/poll.h:10,
                    from include/media/videobuf2-core.h:17,
                    from include/media/videobuf2-v4l2.h:16,
                    from include/media/v4l2-mem2mem.h:16,
                    from drivers/staging/media/hantro/hantro_drv.c:23:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |  unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                         ^~~~~~~
   drivers/staging/media/hantro/hantro_drv.c: In function 'device_run':
>> drivers/staging/media/hantro/hantro_drv.c:165:3: error: label 'err_cancel_job' used but not defined
     165 |   goto err_cancel_job;
         |   ^~~~
>> drivers/staging/media/hantro/hantro_drv.c:157:32: warning: variable 'dst' set but not used [-Wunused-but-set-variable]
     157 |  struct vb2_v4l2_buffer *src, *dst;
         |                                ^~~
>> drivers/staging/media/hantro/hantro_drv.c:157:26: warning: variable 'src' set but not used [-Wunused-but-set-variable]
     157 |  struct vb2_v4l2_buffer *src, *dst;
         |                          ^~~
   drivers/staging/media/hantro/hantro_drv.c: At top level:
>> drivers/staging/media/hantro/hantro_drv.c:168:2: warning: data definition has no type or storage class
     168 |  ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks);
         |  ^~~
>> drivers/staging/media/hantro/hantro_drv.c:168:2: error: type defaults to 'int' in declaration of 'ret' [-Werror=implicit-int]
>> drivers/staging/media/hantro/hantro_drv.c:168:24: error: 'ctx' undeclared here (not in a function)
     168 |  ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks);
         |                        ^~~
>> drivers/staging/media/hantro/hantro_drv.c:169:2: error: expected identifier or '(' before 'if'
     169 |  if (ret)
         |  ^~
   drivers/staging/media/hantro/hantro_drv.c:172:2: warning: data definition has no type or storage class
     172 |  v4l2_m2m_buf_copy_metadata(src, dst, true);
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/hantro/hantro_drv.c:172:2: error: type defaults to 'int' in declaration of 'v4l2_m2m_buf_copy_metadata' [-Werror=implicit-int]
>> drivers/staging/media/hantro/hantro_drv.c:172:2: warning: parameter names (without types) in function declaration
>> drivers/staging/media/hantro/hantro_drv.c:172:2: error: conflicting types for 'v4l2_m2m_buf_copy_metadata'
   In file included from drivers/staging/media/hantro/hantro_drv.c:23:
   include/media/v4l2-mem2mem.h:830:6: note: previous declaration of 'v4l2_m2m_buf_copy_metadata' was here
     830 | void v4l2_m2m_buf_copy_metadata(const struct vb2_v4l2_buffer *out_vb,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/hantro/hantro_drv.c:174:5: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
     174 |  ctx->codec_ops->run(ctx);
         |     ^~
>> drivers/staging/media/hantro/hantro_drv.c:175:2: error: expected identifier or '(' before 'return'
     175 |  return;
         |  ^~~~~~
>> drivers/staging/media/hantro/hantro_drv.c:177:15: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token
     177 | err_cancel_job:
         |               ^
>> drivers/staging/media/hantro/hantro_drv.c:179:1: error: expected identifier or '(' before '}' token
     179 | }
         | ^
   drivers/staging/media/hantro/hantro_drv.c:483:34: warning: 'of_hantro_match' defined but not used [-Wunused-const-variable=]
     483 | static const struct of_device_id of_hantro_match[] = {
         |                                  ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/err_cancel_job +165 drivers/staging/media/hantro/hantro_drv.c

932a9317ac492d drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-07-25  153  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  154  static void device_run(void *priv)
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  155  {
a29add8c9bb29d drivers/staging/media/hantro/hantro_drv.c             Philipp Zabel         2019-06-12  156  	struct hantro_ctx *ctx = priv;
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16 @157  	struct vb2_v4l2_buffer *src, *dst;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  158  	int ret;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  159  
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  160  	src = hantro_get_src_buf(ctx);
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  161  	dst = hantro_get_dst_buf(ctx);
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  162  
9454974c75ddbe drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-26  163  	ret = pm_runtime_resume_and_get(ctx->dev->dev);
9454974c75ddbe drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-26  164  	if (ret < 0)
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28 @165  		goto err_cancel_job;
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28  166  	}
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28  167  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @168  	ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks);
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @169  	if (ret)
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  170  		goto err_cancel_job;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  171  
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16 @172  	v4l2_m2m_buf_copy_metadata(src, dst, true);
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  173  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @174  	ctx->codec_ops->run(ctx);
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @175  	return;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  176  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @177  err_cancel_job:
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28  178  	hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR);
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @179  }
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  180  

:::::: The code at line 165 was first introduced by commit
:::::: 892bb6ecead9b834ba7ad1d07513e9eba1baa3a4 media: hantro: do a PM resume earlier

:::::: TO: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40279 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
	Ezequiel Garcia <ezequiel@collabora.com>
Subject: [media-next:master 180/181] drivers/staging/media/hantro/hantro_drv.c:165:3: error: label 'err_cancel_job' used but not defined
Date: Wed, 19 May 2021 20:56:47 +0800	[thread overview]
Message-ID: <202105192044.UM4pvsch-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 9305 bytes --]

tree:   git://linuxtv.org/mchehab/media-next.git master
head:   c4fb2697f420b3c752230d8060801681bc486c04
commit: 9454974c75ddbe0ec82c1bb3f0b5d6f3ce65b8fd [180/181] media: hantro: use pm_runtime_resume_and_get()
config: ia64-randconfig-r002-20210519 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add media-next git://linuxtv.org/mchehab/media-next.git
        git fetch --no-tags media-next master
        git checkout 9454974c75ddbe0ec82c1bb3f0b5d6f3ce65b8fd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:154,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from include/linux/rcuwait.h:6,
                    from include/linux/percpu-rwsem.h:7,
                    from include/linux/fs.h:33,
                    from include/linux/poll.h:10,
                    from include/media/videobuf2-core.h:17,
                    from include/media/videobuf2-v4l2.h:16,
                    from include/media/v4l2-mem2mem.h:16,
                    from drivers/staging/media/hantro/hantro_drv.c:23:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |  unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                         ^~~~~~~
   drivers/staging/media/hantro/hantro_drv.c: In function 'device_run':
>> drivers/staging/media/hantro/hantro_drv.c:165:3: error: label 'err_cancel_job' used but not defined
     165 |   goto err_cancel_job;
         |   ^~~~
>> drivers/staging/media/hantro/hantro_drv.c:157:32: warning: variable 'dst' set but not used [-Wunused-but-set-variable]
     157 |  struct vb2_v4l2_buffer *src, *dst;
         |                                ^~~
>> drivers/staging/media/hantro/hantro_drv.c:157:26: warning: variable 'src' set but not used [-Wunused-but-set-variable]
     157 |  struct vb2_v4l2_buffer *src, *dst;
         |                          ^~~
   drivers/staging/media/hantro/hantro_drv.c: At top level:
>> drivers/staging/media/hantro/hantro_drv.c:168:2: warning: data definition has no type or storage class
     168 |  ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks);
         |  ^~~
>> drivers/staging/media/hantro/hantro_drv.c:168:2: error: type defaults to 'int' in declaration of 'ret' [-Werror=implicit-int]
>> drivers/staging/media/hantro/hantro_drv.c:168:24: error: 'ctx' undeclared here (not in a function)
     168 |  ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks);
         |                        ^~~
>> drivers/staging/media/hantro/hantro_drv.c:169:2: error: expected identifier or '(' before 'if'
     169 |  if (ret)
         |  ^~
   drivers/staging/media/hantro/hantro_drv.c:172:2: warning: data definition has no type or storage class
     172 |  v4l2_m2m_buf_copy_metadata(src, dst, true);
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/hantro/hantro_drv.c:172:2: error: type defaults to 'int' in declaration of 'v4l2_m2m_buf_copy_metadata' [-Werror=implicit-int]
>> drivers/staging/media/hantro/hantro_drv.c:172:2: warning: parameter names (without types) in function declaration
>> drivers/staging/media/hantro/hantro_drv.c:172:2: error: conflicting types for 'v4l2_m2m_buf_copy_metadata'
   In file included from drivers/staging/media/hantro/hantro_drv.c:23:
   include/media/v4l2-mem2mem.h:830:6: note: previous declaration of 'v4l2_m2m_buf_copy_metadata' was here
     830 | void v4l2_m2m_buf_copy_metadata(const struct vb2_v4l2_buffer *out_vb,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/media/hantro/hantro_drv.c:174:5: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
     174 |  ctx->codec_ops->run(ctx);
         |     ^~
>> drivers/staging/media/hantro/hantro_drv.c:175:2: error: expected identifier or '(' before 'return'
     175 |  return;
         |  ^~~~~~
>> drivers/staging/media/hantro/hantro_drv.c:177:15: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token
     177 | err_cancel_job:
         |               ^
>> drivers/staging/media/hantro/hantro_drv.c:179:1: error: expected identifier or '(' before '}' token
     179 | }
         | ^
   drivers/staging/media/hantro/hantro_drv.c:483:34: warning: 'of_hantro_match' defined but not used [-Wunused-const-variable=]
     483 | static const struct of_device_id of_hantro_match[] = {
         |                                  ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/err_cancel_job +165 drivers/staging/media/hantro/hantro_drv.c

932a9317ac492d drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-07-25  153  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  154  static void device_run(void *priv)
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  155  {
a29add8c9bb29d drivers/staging/media/hantro/hantro_drv.c             Philipp Zabel         2019-06-12  156  	struct hantro_ctx *ctx = priv;
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16 @157  	struct vb2_v4l2_buffer *src, *dst;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  158  	int ret;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  159  
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  160  	src = hantro_get_src_buf(ctx);
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  161  	dst = hantro_get_dst_buf(ctx);
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  162  
9454974c75ddbe drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-26  163  	ret = pm_runtime_resume_and_get(ctx->dev->dev);
9454974c75ddbe drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-26  164  	if (ret < 0)
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28 @165  		goto err_cancel_job;
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28  166  	}
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28  167  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @168  	ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks);
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @169  	if (ret)
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  170  		goto err_cancel_job;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  171  
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16 @172  	v4l2_m2m_buf_copy_metadata(src, dst, true);
6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c             Boris Brezillon       2019-08-16  173  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @174  	ctx->codec_ops->run(ctx);
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @175  	return;
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  176  
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @177  err_cancel_job:
892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c             Mauro Carvalho Chehab 2021-04-28  178  	hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR);
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05 @179  }
775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia       2018-12-05  180  

:::::: The code at line 165 was first introduced by commit
:::::: 892bb6ecead9b834ba7ad1d07513e9eba1baa3a4 media: hantro: do a PM resume earlier

:::::: TO: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40279 bytes --]

             reply	other threads:[~2021-05-19 12:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 12:56 kernel test robot [this message]
2021-05-19 12:56 ` [media-next:master 180/181] drivers/staging/media/hantro/hantro_drv.c:165:3: error: label 'err_cancel_job' used but not defined kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202105192044.UM4pvsch-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.