From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-arch <linux-arch@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
Date: Thu, 20 May 2021 07:19:51 +0200 [thread overview]
Message-ID: <20210520051951.GA21165@lst.de> (raw)
In-Reply-To: <CAK8P3a3ytGKfRftRqC5OaGTxNfxX5-qpbXdGG9AYHcRJFMB-RA@mail.gmail.com>
On Wed, May 19, 2021 at 10:33:08PM +0200, Arnd Bergmann wrote:
> static bool ethtool_translate_compat(void)
> {
> -#ifdef CONFIG_X86_64
> +#if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
> /* On x86, translation is needed for i386 but not x32 */
> return in_ia32_syscall();
> #else
Please just use compat_need_64bit_alignment_fixup() instead.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: kbuild-all@lists.01.org
Subject: Re: [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'?
Date: Thu, 20 May 2021 07:19:51 +0200 [thread overview]
Message-ID: <20210520051951.GA21165@lst.de> (raw)
In-Reply-To: <CAK8P3a3ytGKfRftRqC5OaGTxNfxX5-qpbXdGG9AYHcRJFMB-RA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On Wed, May 19, 2021 at 10:33:08PM +0200, Arnd Bergmann wrote:
> static bool ethtool_translate_compat(void)
> {
> -#ifdef CONFIG_X86_64
> +#if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
> /* On x86, translation is needed for i386 but not x32 */
> return in_ia32_syscall();
> #else
Please just use compat_need_64bit_alignment_fixup() instead.
next prev parent reply other threads:[~2021-05-20 5:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 20:08 [asm-generic:compat-alloc-user-space-9 6/41] net/ethtool/ioctl.c:815:9: error: implicit declaration of function 'in_ia32_syscall'; did you mean 'in_compat_syscall'? kernel test robot
2021-05-19 20:08 ` kernel test robot
2021-05-19 20:33 ` Arnd Bergmann
2021-05-19 20:33 ` Arnd Bergmann
2021-05-19 20:39 ` Arnd Bergmann
2021-05-19 20:39 ` Arnd Bergmann
2021-05-20 5:19 ` Christoph Hellwig [this message]
2021-05-20 5:19 ` Christoph Hellwig
2021-05-20 7:30 ` Arnd Bergmann
2021-05-20 7:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520051951.GA21165@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-arch@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.