From: Christoph Hellwig <hch@lst.de>
To: Koba Ko <koba.ko@canonical.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Henrik Juul Hansen <hjhansen2020@gmail.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss.
Date: Tue, 25 May 2021 09:44:26 +0200 [thread overview]
Message-ID: <20210525074426.GA14916@lst.de> (raw)
In-Reply-To: <20210520033315.490584-1-koba.ko@canonical.com>
On Thu, May 20, 2021 at 11:33:15AM +0800, Koba Ko wrote:
> After resume, host can't change power state of the closed controller
> from D3cold to D0.
Why?
> For these devices, just avoid to go deeper than d3hot.
What are "these devices"?
> @@ -2958,6 +2959,15 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>
> dev_info(dev->ctrl.device, "pci function %s\n", dev_name(&pdev->dev));
>
> + if (pm_suspend_via_firmware() || !dev->ctrl.npss ||
> + !pcie_aspm_enabled(pdev) ||
> + dev->nr_host_mem_descs ||
> + (dev->ctrl.quirks & NVME_QUIRK_SIMPLE_SUSPEND)) {
Before we start open coding this in even more places we really want a
little helper function for these checks, which should be accomodated with
the comment near the existing copy of the checks.
> + pdev->d3cold_allowed = false;
> + pci_d3cold_disable(pdev);
> + pm_runtime_resume(&pdev->dev);
Why do we need to both set d3cold_allowed and call pci_d3cold_disable?
What is the pm_runtime_resume doing here?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Koba Ko <koba.ko@canonical.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Henrik Juul Hansen <hjhansen2020@gmail.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss.
Date: Tue, 25 May 2021 09:44:26 +0200 [thread overview]
Message-ID: <20210525074426.GA14916@lst.de> (raw)
In-Reply-To: <20210520033315.490584-1-koba.ko@canonical.com>
On Thu, May 20, 2021 at 11:33:15AM +0800, Koba Ko wrote:
> After resume, host can't change power state of the closed controller
> from D3cold to D0.
Why?
> For these devices, just avoid to go deeper than d3hot.
What are "these devices"?
> @@ -2958,6 +2959,15 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>
> dev_info(dev->ctrl.device, "pci function %s\n", dev_name(&pdev->dev));
>
> + if (pm_suspend_via_firmware() || !dev->ctrl.npss ||
> + !pcie_aspm_enabled(pdev) ||
> + dev->nr_host_mem_descs ||
> + (dev->ctrl.quirks & NVME_QUIRK_SIMPLE_SUSPEND)) {
Before we start open coding this in even more places we really want a
little helper function for these checks, which should be accomodated with
the comment near the existing copy of the checks.
> + pdev->d3cold_allowed = false;
> + pci_d3cold_disable(pdev);
> + pm_runtime_resume(&pdev->dev);
Why do we need to both set d3cold_allowed and call pci_d3cold_disable?
What is the pm_runtime_resume doing here?
next prev parent reply other threads:[~2021-05-25 7:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 3:33 [PATCH] nvme-pci: Avoid to go into d3cold if device can't use npss Koba Ko
2021-05-20 3:33 ` Koba Ko
2021-05-25 7:44 ` Christoph Hellwig [this message]
2021-05-25 7:44 ` Christoph Hellwig
2021-05-25 16:49 ` Kai-Heng Feng
2021-05-25 16:49 ` Kai-Heng Feng
2021-05-25 20:14 ` Bjorn Helgaas
2021-05-25 20:14 ` Bjorn Helgaas
2021-05-26 2:02 ` Koba Ko
2021-05-26 2:02 ` Koba Ko
2021-05-26 2:49 ` Keith Busch
2021-05-26 2:49 ` Keith Busch
2021-05-26 12:11 ` Kai-Heng Feng
2021-05-26 12:11 ` Kai-Heng Feng
2021-05-26 12:59 ` Christoph Hellwig
2021-05-26 12:59 ` Christoph Hellwig
2021-05-26 14:21 ` Kai-Heng Feng
2021-05-26 14:21 ` Kai-Heng Feng
2021-05-26 14:28 ` Christoph Hellwig
2021-05-26 14:28 ` Christoph Hellwig
2021-05-26 14:47 ` Kai-Heng Feng
2021-05-26 14:47 ` Kai-Heng Feng
2021-05-26 15:06 ` Bjorn Helgaas
2021-05-26 15:06 ` Bjorn Helgaas
2021-05-26 16:24 ` Kai-Heng Feng
2021-05-26 16:24 ` Kai-Heng Feng
2021-05-27 11:40 ` Christoph Hellwig
2021-05-27 11:40 ` Christoph Hellwig
2021-05-27 12:08 ` Kai-Heng Feng
2021-05-27 12:08 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525074426.GA14916@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=hjhansen2020@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=kbusch@kernel.org \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.