* [PATCH 1/1] Update kernel headers
@ 2021-05-25 22:32 Zhu Yanjun
2021-05-25 6:20 ` Zhu Yanjun
2021-05-25 13:18 ` Jason Gunthorpe
0 siblings, 2 replies; 5+ messages in thread
From: Zhu Yanjun @ 2021-05-25 22:32 UTC (permalink / raw)
To: linux-rdma, zyjzyj2000, jgg, dledford, leonro
From: Zhu Yanjun <zyjzyj2000@gmail.com>
After the patches "RDMA/rxe: Implement memory windows", the kernel headers
are changed. This causes about 17 errors and 1 failure when running
"run_test.py" with rxe.
This commit will fix these errors and failures.
Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
---
| 11 +++++++++++
1 file changed, 11 insertions(+)
--git a/kernel-headers/rdma/rdma_user_rxe.h b/kernel-headers/rdma/rdma_user_rxe.h
index 068433e2..90ea477f 100644
--- a/kernel-headers/rdma/rdma_user_rxe.h
+++ b/kernel-headers/rdma/rdma_user_rxe.h
@@ -99,7 +99,17 @@ struct rxe_send_wr {
__u32 remote_qkey;
__u16 pkey_index;
} ud;
+ struct {
+ __aligned_u64 addr;
+ __aligned_u64 length;
+ __u32 mr_lkey;
+ __u32 mw_rkey;
+ __u32 rkey;
+ __u32 access;
+ __u32 flags;
+ } mw;
/* reg is only used by the kernel and is not part of the uapi */
+#ifdef __KERNEL__
struct {
union {
struct ib_mr *mr;
@@ -108,6 +118,7 @@ struct rxe_send_wr {
__u32 key;
__u32 access;
} reg;
+#endif
} wr;
};
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Update kernel headers
2021-05-25 22:32 [PATCH 1/1] Update kernel headers Zhu Yanjun
@ 2021-05-25 6:20 ` Zhu Yanjun
2021-05-25 13:18 ` Jason Gunthorpe
1 sibling, 0 replies; 5+ messages in thread
From: Zhu Yanjun @ 2021-05-25 6:20 UTC (permalink / raw)
To: Zhu Yanjun
Cc: RDMA mailing list, Jason Gunthorpe, Doug Ledford, Leon Romanovsky
On Tue, May 25, 2021 at 2:07 PM Zhu Yanjun <yanjun.zhu@intel.com> wrote:
>
> From: Zhu Yanjun <zyjzyj2000@gmail.com>
>
> After the patches "RDMA/rxe: Implement memory windows", the kernel headers
> are changed. This causes about 17 errors and 1 failure when running
> "run_test.py" with rxe.
> This commit will fix these errors and failures.
This commit is for rdma-core.
https://github.com/linux-rdma/rdma-core.git
Zhu Yanjun
>
> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> ---
> kernel-headers/rdma/rdma_user_rxe.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/kernel-headers/rdma/rdma_user_rxe.h b/kernel-headers/rdma/rdma_user_rxe.h
> index 068433e2..90ea477f 100644
> --- a/kernel-headers/rdma/rdma_user_rxe.h
> +++ b/kernel-headers/rdma/rdma_user_rxe.h
> @@ -99,7 +99,17 @@ struct rxe_send_wr {
> __u32 remote_qkey;
> __u16 pkey_index;
> } ud;
> + struct {
> + __aligned_u64 addr;
> + __aligned_u64 length;
> + __u32 mr_lkey;
> + __u32 mw_rkey;
> + __u32 rkey;
> + __u32 access;
> + __u32 flags;
> + } mw;
> /* reg is only used by the kernel and is not part of the uapi */
> +#ifdef __KERNEL__
> struct {
> union {
> struct ib_mr *mr;
> @@ -108,6 +118,7 @@ struct rxe_send_wr {
> __u32 key;
> __u32 access;
> } reg;
> +#endif
> } wr;
> };
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Update kernel headers
2021-05-25 22:32 [PATCH 1/1] Update kernel headers Zhu Yanjun
2021-05-25 6:20 ` Zhu Yanjun
@ 2021-05-25 13:18 ` Jason Gunthorpe
2021-05-25 13:56 ` Zhu Yanjun
1 sibling, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2021-05-25 13:18 UTC (permalink / raw)
To: Zhu Yanjun; +Cc: linux-rdma, zyjzyj2000, dledford, leonro
On Tue, May 25, 2021 at 06:32:22PM -0400, Zhu Yanjun wrote:
> From: Zhu Yanjun <zyjzyj2000@gmail.com>
>
> After the patches "RDMA/rxe: Implement memory windows", the kernel headers
> are changed. This causes about 17 errors and 1 failure when running
> "run_test.py" with rxe.
> This commit will fix these errors and failures.
>
> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> ---
> kernel-headers/rdma/rdma_user_rxe.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Huh? Bob? You can't break the rxe uapi??
> diff --git a/kernel-headers/rdma/rdma_user_rxe.h b/kernel-headers/rdma/rdma_user_rxe.h
> index 068433e2..90ea477f 100644
> --- a/kernel-headers/rdma/rdma_user_rxe.h
> +++ b/kernel-headers/rdma/rdma_user_rxe.h
> @@ -99,7 +99,17 @@ struct rxe_send_wr {
> __u32 remote_qkey;
> __u16 pkey_index;
> } ud;
> + struct {
> + __aligned_u64 addr;
> + __aligned_u64 length;
> + __u32 mr_lkey;
> + __u32 mw_rkey;
> + __u32 rkey;
> + __u32 access;
> + __u32 flags;
> + } mw;
There is room for 4 u64's in 'reg' and this has 5, so it is a no-go
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Update kernel headers
2021-05-25 13:18 ` Jason Gunthorpe
@ 2021-05-25 13:56 ` Zhu Yanjun
2021-05-25 14:46 ` Zhu Yanjun
0 siblings, 1 reply; 5+ messages in thread
From: Zhu Yanjun @ 2021-05-25 13:56 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Zhu Yanjun, RDMA mailing list, Doug Ledford, Leon Romanovsky
On Tue, May 25, 2021 at 9:18 PM Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> On Tue, May 25, 2021 at 06:32:22PM -0400, Zhu Yanjun wrote:
> > From: Zhu Yanjun <zyjzyj2000@gmail.com>
> >
> > After the patches "RDMA/rxe: Implement memory windows", the kernel headers
> > are changed. This causes about 17 errors and 1 failure when running
> > "run_test.py" with rxe.
> > This commit will fix these errors and failures.
> >
> > Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> > ---
> > kernel-headers/rdma/rdma_user_rxe.h | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
>
> Huh? Bob? You can't break the rxe uapi??
>
> > diff --git a/kernel-headers/rdma/rdma_user_rxe.h b/kernel-headers/rdma/rdma_user_rxe.h
> > index 068433e2..90ea477f 100644
> > --- a/kernel-headers/rdma/rdma_user_rxe.h
> > +++ b/kernel-headers/rdma/rdma_user_rxe.h
> > @@ -99,7 +99,17 @@ struct rxe_send_wr {
> > __u32 remote_qkey;
> > __u16 pkey_index;
> > } ud;
> > + struct {
> > + __aligned_u64 addr;
>
> > + __aligned_u64 length;
>
> > + __u32 mr_lkey;
> > + __u32 mw_rkey;
>
> > + __u32 rkey;
> > + __u32 access;
>
> > + __u32 flags;
> > + } mw;
>
> There is room for 4 u64's in 'reg' and this has 5, so it is a no-go
What is 'reg'? Where is the definition of this 'reg'? What protocol
has the definition of this 'reg'?
Zhu Yanjun
>
> Jason
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] Update kernel headers
2021-05-25 13:56 ` Zhu Yanjun
@ 2021-05-25 14:46 ` Zhu Yanjun
0 siblings, 0 replies; 5+ messages in thread
From: Zhu Yanjun @ 2021-05-25 14:46 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Zhu Yanjun, RDMA mailing list, Doug Ledford, Leon Romanovsky
On Tue, May 25, 2021 at 9:56 PM Zhu Yanjun <zyjzyj2000@gmail.com> wrote:
>
> On Tue, May 25, 2021 at 9:18 PM Jason Gunthorpe <jgg@nvidia.com> wrote:
> >
> > On Tue, May 25, 2021 at 06:32:22PM -0400, Zhu Yanjun wrote:
> > > From: Zhu Yanjun <zyjzyj2000@gmail.com>
> > >
> > > After the patches "RDMA/rxe: Implement memory windows", the kernel headers
> > > are changed. This causes about 17 errors and 1 failure when running
> > > "run_test.py" with rxe.
> > > This commit will fix these errors and failures.
> > >
> > > Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> > > ---
> > > kernel-headers/rdma/rdma_user_rxe.h | 11 +++++++++++
> > > 1 file changed, 11 insertions(+)
> >
> > Huh? Bob? You can't break the rxe uapi??
> >
> > > diff --git a/kernel-headers/rdma/rdma_user_rxe.h b/kernel-headers/rdma/rdma_user_rxe.h
> > > index 068433e2..90ea477f 100644
> > > --- a/kernel-headers/rdma/rdma_user_rxe.h
> > > +++ b/kernel-headers/rdma/rdma_user_rxe.h
> > > @@ -99,7 +99,17 @@ struct rxe_send_wr {
> > > __u32 remote_qkey;
> > > __u16 pkey_index;
> > > } ud;
> > > + struct {
> > > + __aligned_u64 addr;
> >
> > > + __aligned_u64 length;
> >
> > > + __u32 mr_lkey;
> > > + __u32 mw_rkey;
> >
> > > + __u32 rkey;
> > > + __u32 access;
> >
> > > + __u32 flags;
> > > + } mw;
> >
> > There is room for 4 u64's in 'reg' and this has 5, so it is a no-go
>
> What is 'reg'? Where is the definition of this 'reg'? What protocol
> has the definition of this 'reg'?
Got it. Please ignore my comments.
Zhu Yanjun
>
> Zhu Yanjun
>
> >
> > Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-25 14:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-25 22:32 [PATCH 1/1] Update kernel headers Zhu Yanjun
2021-05-25 6:20 ` Zhu Yanjun
2021-05-25 13:18 ` Jason Gunthorpe
2021-05-25 13:56 ` Zhu Yanjun
2021-05-25 14:46 ` Zhu Yanjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.