Re: [PATCH 2/2 v2] f2fs: support RO feature

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4797 bytes --]

Hi Jaegeuk,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.13-rc3]
[cannot apply to f2fs/dev-test next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jaegeuk-Kim/Re-PATCH-2-2-v2-f2fs-support-RO-feature/20210526-220009
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47
config: powerpc-randconfig-r013-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/0day-ci/linux/commit/7c8442f8e27347c3c91ad75db2961cd58b7c8c62
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jaegeuk-Kim/Re-PATCH-2-2-v2-f2fs-support-RO-feature/20210526-220009
        git checkout 7c8442f8e27347c3c91ad75db2961cd58b7c8c62
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> fs/f2fs/super.c:1168:3: error: use of undeclared identifier 'err'
                   err = -EINVAL;
                   ^
>> fs/f2fs/super.c:1169:8: error: use of undeclared label 'free_options'
                   goto free_options;
                        ^
>> fs/f2fs/super.c:3163:43: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Wparentheses]
                           F2FS_HAS_FEATURE(sbi, F2FS_FEATURE_RO) ? 1 : 0;
                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
   fs/f2fs/super.c:3163:43: note: place parentheses around the '+' expression to silence this warning
                           F2FS_HAS_FEATURE(sbi, F2FS_FEATURE_RO) ? 1 : 0;
                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
   fs/f2fs/super.c:3163:43: note: place parentheses around the '?:' expression to evaluate it first
                           F2FS_HAS_FEATURE(sbi, F2FS_FEATURE_RO) ? 1 : 0;
                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
   1 warning and 2 errors generated.


vim +/err +1168 fs/f2fs/super.c

  1124	
  1125		if (F2FS_IO_SIZE_BITS(sbi) && !f2fs_lfs_mode(sbi)) {
  1126			f2fs_err(sbi, "Should set mode=lfs with %uKB-sized IO",
  1127				 F2FS_IO_SIZE_KB(sbi));
  1128			return -EINVAL;
  1129		}
  1130	
  1131		if (test_opt(sbi, INLINE_XATTR_SIZE)) {
  1132			int min_size, max_size;
  1133	
  1134			if (!f2fs_sb_has_extra_attr(sbi) ||
  1135				!f2fs_sb_has_flexible_inline_xattr(sbi)) {
  1136				f2fs_err(sbi, "extra_attr or flexible_inline_xattr feature is off");
  1137				return -EINVAL;
  1138			}
  1139			if (!test_opt(sbi, INLINE_XATTR)) {
  1140				f2fs_err(sbi, "inline_xattr_size option should be set with inline_xattr option");
  1141				return -EINVAL;
  1142			}
  1143	
  1144			min_size = sizeof(struct f2fs_xattr_header) / sizeof(__le32);
  1145			max_size = MAX_INLINE_XATTR_SIZE;
  1146	
  1147			if (F2FS_OPTION(sbi).inline_xattr_size < min_size ||
  1148					F2FS_OPTION(sbi).inline_xattr_size > max_size) {
  1149				f2fs_err(sbi, "inline xattr size is out of range: %d ~ %d",
  1150					 min_size, max_size);
  1151				return -EINVAL;
  1152			}
  1153		}
  1154	
  1155		if (test_opt(sbi, DISABLE_CHECKPOINT) && f2fs_lfs_mode(sbi)) {
  1156			f2fs_err(sbi, "LFS not compatible with checkpoint=disable\n");
  1157			return -EINVAL;
  1158		}
  1159	
  1160		/* Not pass down write hints if the number of active logs is lesser
  1161		 * than NR_CURSEG_PERSIST_TYPE.
  1162		 */
  1163		if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
  1164			F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
  1165	
  1166		if (F2FS_HAS_FEATURE(sbi, F2FS_FEATURE_RO) && !f2fs_readonly(sbi->sb)) {
  1167			f2fs_info(sbi, "Allow to mount readonly mode only");
> 1168			err = -EINVAL;
> 1169			goto free_options;
  1170		}
  1171		return 0;
  1172	}
  1173	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29912 bytes --]