* [PATCH][next] r8169: Fix fall-through warning for Clang
@ 2021-05-28 20:23 Gustavo A. R. Silva
2021-05-28 20:37 ` Heiner Kallweit
[not found] ` <162224100360.24905.9240842444695928219.git-patchwork-notify@kernel.org>
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-28 20:23 UTC (permalink / raw)
To: Heiner Kallweit, David S. Miller, Jakub Kicinski
Cc: nic_swsd, netdev, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
JFYI: We had thousands of these sorts of warnings and now we are down
to just 25 in linux-next. This is one of those last remaining
warnings.
drivers/net/ethernet/realtek/r8169_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 1663e0486496..64f94a3fe646 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4115,6 +4115,7 @@ static unsigned int rtl_quirk_packet_padto(struct rtl8169_private *tp,
case RTL_GIGA_MAC_VER_61:
case RTL_GIGA_MAC_VER_63:
padto = max_t(unsigned int, padto, ETH_ZLEN);
+ break;
default:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] r8169: Fix fall-through warning for Clang
2021-05-28 20:23 [PATCH][next] r8169: Fix fall-through warning for Clang Gustavo A. R. Silva
@ 2021-05-28 20:37 ` Heiner Kallweit
[not found] ` <162224100360.24905.9240842444695928219.git-patchwork-notify@kernel.org>
1 sibling, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2021-05-28 20:37 UTC (permalink / raw)
To: Gustavo A. R. Silva, David S. Miller, Jakub Kicinski
Cc: nic_swsd, netdev, linux-kernel, linux-hardening
On 28.05.2021 22:23, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> JFYI: We had thousands of these sorts of warnings and now we are down
> to just 25 in linux-next. This is one of those last remaining
> warnings.
>
> drivers/net/ethernet/realtek/r8169_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Heiner Kallweit <hkallweit1@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] r8169: Fix fall-through warning for Clang
[not found] ` <162224100360.24905.9240842444695928219.git-patchwork-notify@kernel.org>
@ 2021-05-28 23:49 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-28 23:49 UTC (permalink / raw)
To: patchwork-bot+netdevbpf, Gustavo A. R. Silva
Cc: hkallweit1, davem, kuba, nic_swsd, netdev, linux-kernel,
linux-hardening
On 5/28/21 17:30, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net-next.git (refs/heads/master):
>
> On Fri, 28 May 2021 15:23:27 -0500 you wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>>
>> [...]
>
> Here is the summary with links:
> - [next] r8169: Fix fall-through warning for Clang
> https://git.kernel.org/netdev/net-next/c/ffb35c679842
Awesome. :)
Thanks Heiner and Jakub.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-29 0:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-28 20:23 [PATCH][next] r8169: Fix fall-through warning for Clang Gustavo A. R. Silva
2021-05-28 20:37 ` Heiner Kallweit
[not found] ` <162224100360.24905.9240842444695928219.git-patchwork-notify@kernel.org>
2021-05-28 23:49 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.