All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Felix Kuehling <felix.kuehling@gmail.com>
Cc: Alex Sierra <alex.sierra@amd.com>,
	felix.kuehling@amd.com, dri-devel@lists.freedesktop.org,
	linux-mm@kvack.org, jglisse@redhat.com,
	amd-gfx@lists.freedesktop.org, jgg@nvidia.com,
	akpm@linux-foundation.org, hch@lst.de
Subject: Re: [RFC PATCH 1/5] drm/amdkfd: add SPM support for SVM
Date: Sat, 29 May 2021 08:38:28 +0200	[thread overview]
Message-ID: <20210529063828.GA15834@lst.de> (raw)
In-Reply-To: <20210527230809.3701-2-Felix.Kuehling@amd.com>

On Thu, May 27, 2021 at 07:08:05PM -0400, Felix Kuehling wrote:
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 627e61b0c124..da137553b83e 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -783,7 +783,7 @@ struct resource *lookup_resource(struct resource *root, resource_size_t start)
>  
>  	return res;
>  }
> -
> +EXPORT_SYMBOL(lookup_resource);

NAK on hiding random exports in a driver patch.  This needs to be a proper
patch with a proper rationale, a kerneldoc comment and use
EXPORT_SYMBOL_GPL.  And even then it smells rather fishy, but I'll wait
for the rationale.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Felix Kuehling <felix.kuehling@gmail.com>
Cc: felix.kuehling@amd.com, akpm@linux-foundation.org,
	linux-mm@kvack.org, hch@lst.de, jglisse@redhat.com,
	jgg@nvidia.com, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, Alex Sierra <alex.sierra@amd.com>
Subject: Re: [RFC PATCH 1/5] drm/amdkfd: add SPM support for SVM
Date: Sat, 29 May 2021 08:38:28 +0200	[thread overview]
Message-ID: <20210529063828.GA15834@lst.de> (raw)
In-Reply-To: <20210527230809.3701-2-Felix.Kuehling@amd.com>

On Thu, May 27, 2021 at 07:08:05PM -0400, Felix Kuehling wrote:
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 627e61b0c124..da137553b83e 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -783,7 +783,7 @@ struct resource *lookup_resource(struct resource *root, resource_size_t start)
>  
>  	return res;
>  }
> -
> +EXPORT_SYMBOL(lookup_resource);

NAK on hiding random exports in a driver patch.  This needs to be a proper
patch with a proper rationale, a kerneldoc comment and use
EXPORT_SYMBOL_GPL.  And even then it smells rather fishy, but I'll wait
for the rationale.


  reply	other threads:[~2021-05-29 10:20 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 23:08 [RFC PATCH 0/5] Support DEVICE_GENERIC memory in migrate_vma_* Felix Kuehling
2021-05-27 23:08 ` Felix Kuehling
2021-05-27 23:08 ` Felix Kuehling
2021-05-27 23:08 ` [RFC PATCH 1/5] drm/amdkfd: add SPM support for SVM Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-29  6:38   ` Christoph Hellwig [this message]
2021-05-29  6:38     ` Christoph Hellwig
2021-05-29 18:42     ` Felix Kuehling
2021-05-29 18:42       ` Felix Kuehling
2021-05-29 18:42       ` Felix Kuehling
2021-05-27 23:08 ` [RFC PATCH 2/5] drm/amdkfd: generic type as sys mem on migration to ram Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-27 23:08 ` [RFC PATCH 3/5] include/linux/mm.h: helper to check zone device generic type Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-27 23:08 ` [RFC PATCH 4/5] mm: add generic type support for device zone page migration Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-29  6:40   ` Christoph Hellwig
2021-05-29  6:40     ` Christoph Hellwig
2021-05-27 23:08 ` [RFC PATCH 5/5] mm: changes to unref pages with Generic type Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-27 23:08   ` Felix Kuehling
2021-05-29  6:42   ` Christoph Hellwig
2021-05-29  6:42     ` Christoph Hellwig
2021-05-29 18:44     ` Felix Kuehling
2021-05-29 18:44       ` Felix Kuehling
2021-05-29 18:44       ` Felix Kuehling
2021-05-28 13:08 ` [RFC PATCH 0/5] Support DEVICE_GENERIC memory in migrate_vma_* Jason Gunthorpe
2021-05-28 13:08   ` Jason Gunthorpe
2021-05-28 13:08   ` Jason Gunthorpe
2021-05-28 15:56   ` Felix Kuehling
2021-05-28 15:56     ` Felix Kuehling
2021-05-28 15:56     ` Felix Kuehling
2021-05-29  6:41     ` Christoph Hellwig
2021-05-29  6:41       ` Christoph Hellwig
2021-05-29 18:37       ` Felix Kuehling
2021-05-29 18:37         ` Felix Kuehling
2021-05-29 18:37         ` Felix Kuehling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210529063828.GA15834@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=alex.sierra@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felix.kuehling@amd.com \
    --cc=felix.kuehling@gmail.com \
    --cc=jgg@nvidia.com \
    --cc=jglisse@redhat.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.