From: Christoph Hellwig <hch@lst.de>
To: palmerdabbelt@google.com
Cc: Christoph Hellwig <hch@lst.de>,
guoren@kernel.org, Anup Patel <Anup.Patel@wdc.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-sunxi@lists.linux.dev,
guoren@linux.alibaba.com
Subject: Re: [PATCH V4 2/2] riscv: Use use_asid_allocator flush TLB
Date: Mon, 31 May 2021 08:36:58 +0200 [thread overview]
Message-ID: <20210531063658.GB1143@lst.de> (raw)
In-Reply-To: <mhng-cfb5a043-4b59-4698-b732-5cf5ceb49114@palmerdabbelt-glaptop>
On Sat, May 29, 2021 at 04:42:37PM -0700, palmerdabbelt@google.com wrote:
>>
>> Also the non-ASID code switches to a global flush once flushing more
>> than a single page. It might be worth documenting the tradeoff in the
>> code.
>
> For some reason I thought we'd written this down in the commentary of teh
> ISA manual as the suggested huersitic here, but I can't find it so maybe
> I'm wrong. If it's actually there it would be good to point that out,
> otherwise some documentation seems fine as it'll probably become a tunable
> at some point anyway.
The real question is why is the heuristic different for the ASID vs
non-ASID case? I think that really need a comment.
> LGTM. I took the first one as IMO they're really distnict issues, LMK if
> you want to re-spin this one or if I should just take what's here.
What distinct issue? The fact that the new code is buggy and uses rather
non-optimal calling conventions?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: palmerdabbelt@google.com
Cc: Christoph Hellwig <hch@lst.de>,
guoren@kernel.org, Anup Patel <Anup.Patel@wdc.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-sunxi@lists.linux.dev,
guoren@linux.alibaba.com
Subject: Re: [PATCH V4 2/2] riscv: Use use_asid_allocator flush TLB
Date: Mon, 31 May 2021 08:36:58 +0200 [thread overview]
Message-ID: <20210531063658.GB1143@lst.de> (raw)
In-Reply-To: <mhng-cfb5a043-4b59-4698-b732-5cf5ceb49114@palmerdabbelt-glaptop>
On Sat, May 29, 2021 at 04:42:37PM -0700, palmerdabbelt@google.com wrote:
>>
>> Also the non-ASID code switches to a global flush once flushing more
>> than a single page. It might be worth documenting the tradeoff in the
>> code.
>
> For some reason I thought we'd written this down in the commentary of teh
> ISA manual as the suggested huersitic here, but I can't find it so maybe
> I'm wrong. If it's actually there it would be good to point that out,
> otherwise some documentation seems fine as it'll probably become a tunable
> at some point anyway.
The real question is why is the heuristic different for the ASID vs
non-ASID case? I think that really need a comment.
> LGTM. I took the first one as IMO they're really distnict issues, LMK if
> you want to re-spin this one or if I should just take what's here.
What distinct issue? The fact that the new code is buggy and uses rather
non-optimal calling conventions?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-05-31 6:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 5:49 [PATCH V4 0/2] riscv: Fixup asid_allocator remaining issues guoren
2021-05-26 5:49 ` guoren
2021-05-26 5:49 ` [PATCH V4 1/2] riscv: Fixup _PAGE_GLOBAL in _PAGE_KERNEL guoren
2021-05-26 5:49 ` guoren
2021-05-29 23:42 ` palmerdabbelt
2021-05-29 23:42 ` palmerdabbelt
2021-05-30 5:33 ` Guo Ren
2021-05-30 5:33 ` Guo Ren
2021-05-26 5:49 ` [PATCH V4 2/2] riscv: Use use_asid_allocator flush TLB guoren
2021-05-26 5:49 ` guoren
2021-05-27 7:09 ` Christoph Hellwig
2021-05-27 7:09 ` Christoph Hellwig
2021-05-29 23:42 ` palmerdabbelt
2021-05-29 23:42 ` palmerdabbelt
2021-05-30 0:51 ` Guo Ren
2021-05-30 0:51 ` Guo Ren
2021-05-31 6:36 ` Christoph Hellwig [this message]
2021-05-31 6:36 ` Christoph Hellwig
2021-05-30 0:39 ` Guo Ren
2021-05-30 0:39 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531063658.GB1143@lst.de \
--to=hch@lst.de \
--cc=Anup.Patel@wdc.com \
--cc=arnd@arndb.de \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmerdabbelt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.