From: Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
To: Vitaly Wool <vitaly.wool@konsulko.com>
Cc: linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmerdabbelt@google.com>,
Jisheng Zhang <jszhang@kernel.org>
Subject: Re: [PATCH] riscv: fix typo in init.c
Date: Mon, 31 May 2021 08:11:40 +0800 [thread overview]
Message-ID: <20210531081140.4e8b409e@xhacker> (raw)
In-Reply-To: <20210530132217.7851-1-vitaly.wool@konsulko.com>
On Sun, 30 May 2021 16:22:17 +0300
Vitaly Wool <vitaly.wool@konsulko.com> wrote:
> Commit 010623568222 introduced a typo in "__initdata" spelling
> which led to build breakage for XIP. Fix that.
oops, nice catch! Sorry for that.
>
> Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676
This "Fixes" tag seems not correct.Should be
Fixes: 010623568222 ("riscv: mm: init: Consolidate vars, functions")
After this change,
Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
> Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com>
> ---
> arch/riscv/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index ae32f78207f0..e7b136abf90c 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata;
> #endif
>
> #ifdef CONFIG_XIP_KERNEL
> -static uintptr_t xiprom __inidata;
> +static uintptr_t xiprom __initdata;
> static uintptr_t xiprom_sz __initdata;
> #define xiprom_sz (*((uintptr_t *)XIP_FIXUP(&xiprom_sz)))
> #define xiprom (*((uintptr_t *)XIP_FIXUP(&xiprom)))
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-05-31 0:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 13:22 [PATCH] riscv: fix typo in init.c Vitaly Wool
2021-05-31 0:11 ` Jisheng Zhang [this message]
2021-06-08 7:56 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531081140.4e8b409e@xhacker \
--to=jszhang3@mail.ustc.edu.cn \
--cc=jszhang@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmerdabbelt@google.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.