Re: [PATCH] riscv: fix typo in init.c

From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
Cc: Vitaly Wool <vitaly.wool@konsulko.com>,
	linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	Jisheng Zhang <jszhang@kernel.org>
Subject: Re: [PATCH] riscv: fix typo in init.c
Date: Tue, 8 Jun 2021 15:56:09 +0800	[thread overview]
Message-ID: <20210608155609.27da406a@xhacker.debian> (raw)
In-Reply-To: <20210531081140.4e8b409e@xhacker>

On Mon, 31 May 2021 08:11:40 +0800
Jisheng Zhang <jszhang3@mail.ustc.edu.cn> wrote:

> 
> 
> On Sun, 30 May 2021 16:22:17 +0300
> Vitaly Wool <vitaly.wool@konsulko.com> wrote:
> 
> > Commit 010623568222 introduced a typo in "__initdata" spelling
> > which led to build breakage for XIP. Fix that.  
> 
> oops, nice catch! Sorry for that.
> 
> >
> > Fixes: 010623568222bd144eb73aa9f3b46c79b63d7676  
> 
> This "Fixes" tag seems not correct.Should be
> Fixes: 010623568222 ("riscv: mm: init: Consolidate vars, functions")

Hi Vitaly,

Could you plz send a v2 for this?

Regards

> 
> After this change,
> Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
> 
> > Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com>
> > ---
> >  arch/riscv/mm/init.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> > index ae32f78207f0..e7b136abf90c 100644
> > --- a/arch/riscv/mm/init.c
> > +++ b/arch/riscv/mm/init.c
> > @@ -451,7 +451,7 @@ static uintptr_t load_sz __initdata;
> >  #endif
> >
> >  #ifdef CONFIG_XIP_KERNEL
> > -static uintptr_t xiprom __inidata;
> > +static uintptr_t xiprom __initdata;
> >  static uintptr_t xiprom_sz __initdata;
> >  #define xiprom_sz      (*((uintptr_t *)XIP_FIXUP(&xiprom_sz)))
> >  #define xiprom         (*((uintptr_t *)XIP_FIXUP(&xiprom)))  
> 
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv