From: Cornelia Huck <cohuck@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com
Subject: Re: [PATCH RESEND 1/2] virtio: update virtio id table, add transitional ids
Date: Mon, 31 May 2021 09:58:04 +0200 [thread overview]
Message-ID: <20210531095804.47629646.cohuck@redhat.com> (raw)
In-Reply-To: <20210531072743.363171-2-lingshan.zhu@intel.com>
On Mon, 31 May 2021 15:27:42 +0800
Zhu Lingshan <lingshan.zhu@intel.com> wrote:
> This commit updates virtio id table by adding transitional device
> ids
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> ---
> include/uapi/linux/virtio_ids.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
> index f0c35ce8628c..fcc9ec6a73c1 100644
> --- a/include/uapi/linux/virtio_ids.h
> +++ b/include/uapi/linux/virtio_ids.h
> @@ -57,4 +57,16 @@
> #define VIRTIO_ID_BT 28 /* virtio bluetooth */
> #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */
>
> +/*
> + * Virtio Transitional IDs
> + */
> +
> +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */
> +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */
> +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */
> +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */
> +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */
> +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */
> +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */
> +
> #endif /* _LINUX_VIRTIO_IDS_H */
Isn't this a purely virtio-pci concept? (The spec lists the virtio ids
in the common section, and those transitional ids in the pci section.)
IOW, is there a better, virtio-pci specific, header for this?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: jasowang@redhat.com, mst@redhat.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH RESEND 1/2] virtio: update virtio id table, add transitional ids
Date: Mon, 31 May 2021 09:58:04 +0200 [thread overview]
Message-ID: <20210531095804.47629646.cohuck@redhat.com> (raw)
In-Reply-To: <20210531072743.363171-2-lingshan.zhu@intel.com>
On Mon, 31 May 2021 15:27:42 +0800
Zhu Lingshan <lingshan.zhu@intel.com> wrote:
> This commit updates virtio id table by adding transitional device
> ids
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> ---
> include/uapi/linux/virtio_ids.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h
> index f0c35ce8628c..fcc9ec6a73c1 100644
> --- a/include/uapi/linux/virtio_ids.h
> +++ b/include/uapi/linux/virtio_ids.h
> @@ -57,4 +57,16 @@
> #define VIRTIO_ID_BT 28 /* virtio bluetooth */
> #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */
>
> +/*
> + * Virtio Transitional IDs
> + */
> +
> +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */
> +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */
> +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */
> +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */
> +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */
> +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */
> +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */
> +
> #endif /* _LINUX_VIRTIO_IDS_H */
Isn't this a purely virtio-pci concept? (The spec lists the virtio ids
in the common section, and those transitional ids in the pci section.)
IOW, is there a better, virtio-pci specific, header for this?
next prev parent reply other threads:[~2021-05-31 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:27 [PATCH RESEND 0/2] update virtio id table Zhu Lingshan
2021-05-31 7:27 ` [PATCH RESEND 1/2] virtio: update virtio id table, add transitional ids Zhu Lingshan
2021-05-31 7:58 ` Cornelia Huck [this message]
2021-05-31 7:58 ` Cornelia Huck
2021-05-31 9:57 ` Zhu, Lingshan
2021-05-31 10:20 ` Michael S. Tsirkin
2021-05-31 10:20 ` Michael S. Tsirkin
2021-05-31 7:27 ` [PATCH RESEND 2/2] vDPA/ifcvf: reuse pre-defined macros for device ids and vendor ids Zhu Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531095804.47629646.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.