From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
virtualization@lists.linux-foundation.org, bpf@vger.kernel.org
Subject: Re: [PATCH net v2 0/2] virtio-net: fix for build_skb()
Date: Tue, 1 Jun 2021 07:06:43 -0400 [thread overview]
Message-ID: <20210601070610-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210601064000.66909-1-xuanzhuo@linux.alibaba.com>
On Tue, Jun 01, 2021 at 02:39:58PM +0800, Xuan Zhuo wrote:
> #1 Fixed a serious error.
> #2 Fixed a logical error, but this error did not cause any serious consequences.
>
> The logic of this piece is really messy. Fortunately, my refactored patch can be
> completed with a small amount of testing.
Looks good, thanks!
Also needed for stable I think.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Thanks.
>
> Xuan Zhuo (2):
> virtio-net: fix for unable to handle page fault for address
> virtio_net: get build_skb() buf by data ptr
>
> drivers/net/virtio_net.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> --
> 2.31.0
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
virtualization@lists.linux-foundation.org,
Jakub Kicinski <kuba@kernel.org>,
bpf@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v2 0/2] virtio-net: fix for build_skb()
Date: Tue, 1 Jun 2021 07:06:43 -0400 [thread overview]
Message-ID: <20210601070610-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210601064000.66909-1-xuanzhuo@linux.alibaba.com>
On Tue, Jun 01, 2021 at 02:39:58PM +0800, Xuan Zhuo wrote:
> #1 Fixed a serious error.
> #2 Fixed a logical error, but this error did not cause any serious consequences.
>
> The logic of this piece is really messy. Fortunately, my refactored patch can be
> completed with a small amount of testing.
Looks good, thanks!
Also needed for stable I think.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Thanks.
>
> Xuan Zhuo (2):
> virtio-net: fix for unable to handle page fault for address
> virtio_net: get build_skb() buf by data ptr
>
> drivers/net/virtio_net.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> --
> 2.31.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-06-01 11:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 6:39 [PATCH net v2 0/2] virtio-net: fix for build_skb() Xuan Zhuo
2021-06-01 6:39 ` Xuan Zhuo
2021-06-01 6:39 ` [PATCH net v2 1/2] virtio-net: fix for unable to handle page fault for address Xuan Zhuo
2021-06-01 6:39 ` Xuan Zhuo
2021-06-01 8:53 ` Jason Wang
2021-06-01 8:53 ` Jason Wang
2021-06-01 6:40 ` [PATCH net v2 2/2] virtio_net: get build_skb() buf by data ptr Xuan Zhuo
2021-06-01 6:40 ` Xuan Zhuo
2021-06-01 8:55 ` Jason Wang
2021-06-01 8:55 ` Jason Wang
2021-06-01 11:06 ` Michael S. Tsirkin [this message]
2021-06-01 11:06 ` [PATCH net v2 0/2] virtio-net: fix for build_skb() Michael S. Tsirkin
2021-07-30 12:16 ` Jakub Kicinski
2021-08-02 4:45 ` Jason Wang
2021-08-02 4:45 ` Jason Wang
2021-08-02 16:58 ` Michael S. Tsirkin
2021-08-02 16:58 ` Michael S. Tsirkin
2021-06-01 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601070610-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.