Re: [linux-next:master 5596/5886] arch/x86/include/asm/fixmap.h:103:48: error: use of undeclared identifier 'NR_CPUS'

[Mel Gorman <mgorman@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 2324 bytes --]

On Mon, May 31, 2021 at 03:05:54PM -0700, Andrew Morton wrote:
> On Mon, 31 May 2021 10:39:17 +0100 Mel Gorman <mgorman@suse.de> wrote:
> 
> > On Sun, May 30, 2021 at 07:58:14PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > > head:   3e029760e6f8ce90c122c267a039ae73b3f1f5a4
> > > commit: 366e9aec4a22d77b869f1b7641a74fdd96f02b4c [5596/5886] mm/early_ioremap: add prototype for early_memremap_pgprot_adjust
> > > config: x86_64-randconfig-a006-20210530 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # install x86_64 cross compiling tool for clang build
> > >         # apt-get install binutils-x86-64-linux-gnu
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> > >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > >         git fetch --no-tags linux-next master
> > >         git checkout 366e9aec4a22d77b869f1b7641a74fdd96f02b4c
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> > > 
> > 
> > Hi Andrew,
> > 
> > Can you please drop the patch
> > mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust.patch?
> 
> Didn't I fix this with
> mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch?
> 
> This fix is lame - x86's fixmap.h should be standalone.  But this gets us
> moving ahead with the MM changes for now.
> 

I think you did fix it but I was surprised by the level
of fallout from this patch and then there were objections
to adding header dependencies unnecessarily such as this
https://lore.kernel.org/lkml/YK3vrIB7cWop+UIW(a)gmail.com/ .  That was
specific to modifying the x86 headers so your fix should not hit the same
objection but still, as you said, x86 fixmap should be standalone.

-- 
Mel Gorman
SUSE Labs