From: Lee Jones <lee.jones@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, heiko@sntech.de,
devicetree@vger.kernel.org, tiwai@suse.com, robh+dt@kernel.org,
lgirdwood@gmail.com, linux-rockchip@lists.infradead.org,
broonie@kernel.org, Chris Morgan <macromorgan@hotmail.com>,
jbx6244@gmail.com, maccraft123mc@gmail.com
Subject: Re: [PATCH] ASoC: rk817: fix a warning in rk817_probe()
Date: Wed, 2 Jun 2021 08:02:20 +0100 [thread overview]
Message-ID: <20210602070220.GC2173308@dell> (raw)
In-Reply-To: <20210601214424.23432-1-macroalpha82@gmail.com>
On Tue, 01 Jun 2021, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The return value of snd_soc_component_write() is stored but not
> evaluated and this results in a warning when W=1 is set. Stop storing
> the return value to be consistent with all other calls of
> snd_soc_component_write() and to remove the warning.
>
> Fixes: 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> sound/soc/codecs/rk817_codec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
Mark, I'll send out another PR shortly.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
tiwai@suse.com, heiko@sntech.de, robh+dt@kernel.org,
perex@perex.cz, jbx6244@gmail.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, maccraft123mc@gmail.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH] ASoC: rk817: fix a warning in rk817_probe()
Date: Wed, 2 Jun 2021 08:02:20 +0100 [thread overview]
Message-ID: <20210602070220.GC2173308@dell> (raw)
In-Reply-To: <20210601214424.23432-1-macroalpha82@gmail.com>
On Tue, 01 Jun 2021, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The return value of snd_soc_component_write() is stored but not
> evaluated and this results in a warning when W=1 is set. Stop storing
> the return value to be consistent with all other calls of
> snd_soc_component_write() and to remove the warning.
>
> Fixes: 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> sound/soc/codecs/rk817_codec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
Mark, I'll send out another PR shortly.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
tiwai@suse.com, heiko@sntech.de, robh+dt@kernel.org,
perex@perex.cz, jbx6244@gmail.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, maccraft123mc@gmail.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH] ASoC: rk817: fix a warning in rk817_probe()
Date: Wed, 2 Jun 2021 08:02:20 +0100 [thread overview]
Message-ID: <20210602070220.GC2173308@dell> (raw)
In-Reply-To: <20210601214424.23432-1-macroalpha82@gmail.com>
On Tue, 01 Jun 2021, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The return value of snd_soc_component_write() is stored but not
> evaluated and this results in a warning when W=1 is set. Stop storing
> the return value to be consistent with all other calls of
> snd_soc_component_write() and to remove the warning.
>
> Fixes: 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> sound/soc/codecs/rk817_codec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
Mark, I'll send out another PR shortly.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-06-02 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 21:44 [PATCH] ASoC: rk817: fix a warning in rk817_probe() Chris Morgan
2021-06-01 21:44 ` Chris Morgan
2021-06-01 21:44 ` Chris Morgan
2021-06-02 7:02 ` Lee Jones [this message]
2021-06-02 7:02 ` Lee Jones
2021-06-02 7:02 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602070220.GC2173308@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.