Re: [PATCH 2/3 v4] crypto: ixp4xx: Add DT bindings

[Rob Herring <robh@kernel.org>]

On Tue, 25 May 2021 10:48:46 +0200, Linus Walleij wrote:
> This adds device tree bindings for the ixp4xx crypto engine.
> 
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v3->v4:
> - Revert back to the phandle to the NPE with the instance
>   in the cell as in v1. Use intel,npe-handle just like
>   the ethernet driver does.
> - Drop the other changes related to using an u32 or reg
>   and revert back to v1.
> - Keep the other useful stuff from v2 and v3.
> ChangeLog v2->v3:
> - Use the reg property to set the NPE instance number for
>   the crypto engine.
> - Add address-cells and size-cells to the NPE bindings
>   consequently.
> - Use a patternProperty to match the cryto engine child
>   "crypto@N".
> - Define as crypto@2 in the example.
> - Describe the usage of the queue instance cell for the
>   queue manager phandles.
> ChangeLog v1->v2:
> - Drop the phandle to self, just add an NPE instance number
>   instead.
> - Add the crypto node to the NPE binding.
> - Move the example over to the NPE binding where it appears
>   in context.
> ---
>  .../bindings/crypto/intel,ixp4xx-crypto.yaml  | 47 +++++++++++++++++++
>  ...ntel,ixp4xx-network-processing-engine.yaml | 22 +++++++--
>  2 files changed, 65 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>