All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
	Wolfram Sang <wsa@kernel.org>, Nishanth Menon <nm@ti.com>,
	linux-kernel@vger.kernel.org,
	Andreas Kemnade <andreas@kemnade.info>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: i2c: Move i2c-omap.txt to YAML format
Date: Wed, 2 Jun 2021 14:06:11 -0500	[thread overview]
Message-ID: <20210602190611.GA3792700@robh.at.kernel.org> (raw)
In-Reply-To: <20210526100412.484-1-vigneshr@ti.com>

On Wed, 26 May 2021 15:34:12 +0530, Vignesh Raghavendra wrote:
> Convert i2c-omap.txt to YAML schema for better checks and documentation.
> 
> Following properties were used in DT but were not documented in txt
> bindings and has been included in YAML schema:
> 1. Include ti,am4372-i2c compatible
> 2. Document clocks property
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> 
> Note that am335x-myirtech*.dtsi needs fixing to drop scl/sda-gpios
> which are not supported by i2c-omap driver.
> omap2/3 dmas property is being dropped by:
> https://lore.kernel.org/20210526094424.27234-1-vigneshr@ti.com
> 
> v3:
> Add conditions around ti,hwmods usage
> drop dmas property as it was never used/supported
> set additionalProperties: False
> Address Rob H comments
> 
> v2:
> Fix issues with make dt_bindings_check
> Add description on usage of ti,hwmods
> 
> v2: https://lore.kernel.org/r/20210506140026.31254-1-vigneshr@ti.com
> v1: https://lore.kernel.org/r/20210505065511.918-1-vigneshr@ti.com
> 
>  .../devicetree/bindings/i2c/i2c-omap.txt      |  37 -------
>  .../devicetree/bindings/i2c/ti,omap4-i2c.yaml | 102 ++++++++++++++++++
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 103 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-omap.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/ti,omap4-i2c.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
	Wolfram Sang <wsa@kernel.org>, Nishanth Menon <nm@ti.com>,
	linux-kernel@vger.kernel.org,
	Andreas Kemnade <andreas@kemnade.info>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: i2c: Move i2c-omap.txt to YAML format
Date: Wed, 2 Jun 2021 14:06:11 -0500	[thread overview]
Message-ID: <20210602190611.GA3792700@robh.at.kernel.org> (raw)
In-Reply-To: <20210526100412.484-1-vigneshr@ti.com>

On Wed, 26 May 2021 15:34:12 +0530, Vignesh Raghavendra wrote:
> Convert i2c-omap.txt to YAML schema for better checks and documentation.
> 
> Following properties were used in DT but were not documented in txt
> bindings and has been included in YAML schema:
> 1. Include ti,am4372-i2c compatible
> 2. Document clocks property
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> 
> Note that am335x-myirtech*.dtsi needs fixing to drop scl/sda-gpios
> which are not supported by i2c-omap driver.
> omap2/3 dmas property is being dropped by:
> https://lore.kernel.org/20210526094424.27234-1-vigneshr@ti.com
> 
> v3:
> Add conditions around ti,hwmods usage
> drop dmas property as it was never used/supported
> set additionalProperties: False
> Address Rob H comments
> 
> v2:
> Fix issues with make dt_bindings_check
> Add description on usage of ti,hwmods
> 
> v2: https://lore.kernel.org/r/20210506140026.31254-1-vigneshr@ti.com
> v1: https://lore.kernel.org/r/20210505065511.918-1-vigneshr@ti.com
> 
>  .../devicetree/bindings/i2c/i2c-omap.txt      |  37 -------
>  .../devicetree/bindings/i2c/ti,omap4-i2c.yaml | 102 ++++++++++++++++++
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 103 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-omap.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/ti,omap4-i2c.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-02 19:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 10:04 [PATCH v3] dt-bindings: i2c: Move i2c-omap.txt to YAML format Vignesh Raghavendra
2021-05-26 10:04 ` Vignesh Raghavendra
2021-06-02 19:06 ` Rob Herring [this message]
2021-06-02 19:06   ` Rob Herring
2021-06-04 20:29 ` Wolfram Sang
2021-06-04 20:29   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602190611.GA3792700@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.