From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2] nvme: reset disk to the mpath node also when requeuing
Date: Thu, 3 Jun 2021 09:25:37 +0200 [thread overview]
Message-ID: <20210603072537.GA4718@lst.de> (raw)
In-Reply-To: <20210602130039.122879-1-dwagner@suse.de>
On Wed, Jun 02, 2021 at 03:00:39PM +0200, Daniel Wagner wrote:
> + struct bio *b;
> blk_qc_t ret = BLK_QC_T_NONE;
> int srcu_idx;
>
> @@ -324,6 +325,8 @@ static blk_qc_t nvme_ns_head_submit_bio(struct bio *bio)
> dev_warn_ratelimited(dev, "no usable path - requeuing I/O\n");
>
> spin_lock_irq(&head->requeue_lock);
> + for (b = bio; b; b = b->bi_next)
> + bio_set_dev(b, head->disk->part0);
> bio_list_add(&head->requeue_list, bio);
> spin_unlock_irq(&head->requeue_lock);
> } else {
I can't see why we'd need this hunk. bio->bi_bdev should have never been
changed to start with in this path.
> @@ -435,11 +438,6 @@ static void nvme_requeue_work(struct work_struct *work)
> next = bio->bi_next;
> bio->bi_next = NULL;
>
> - /*
> - * Reset disk to the mpath node and resubmit to select a new
> - * path.
> - */
> - bio_set_dev(bio, head->disk->part0);
> submit_bio_noacct(bio);
> }
This hunk looks fine.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v2] nvme: reset disk to the mpath node also when requeuing
Date: Thu, 3 Jun 2021 09:25:37 +0200 [thread overview]
Message-ID: <20210603072537.GA4718@lst.de> (raw)
In-Reply-To: <20210602130039.122879-1-dwagner@suse.de>
On Wed, Jun 02, 2021 at 03:00:39PM +0200, Daniel Wagner wrote:
> + struct bio *b;
> blk_qc_t ret = BLK_QC_T_NONE;
> int srcu_idx;
>
> @@ -324,6 +325,8 @@ static blk_qc_t nvme_ns_head_submit_bio(struct bio *bio)
> dev_warn_ratelimited(dev, "no usable path - requeuing I/O\n");
>
> spin_lock_irq(&head->requeue_lock);
> + for (b = bio; b; b = b->bi_next)
> + bio_set_dev(b, head->disk->part0);
> bio_list_add(&head->requeue_list, bio);
> spin_unlock_irq(&head->requeue_lock);
> } else {
I can't see why we'd need this hunk. bio->bi_bdev should have never been
changed to start with in this path.
> @@ -435,11 +438,6 @@ static void nvme_requeue_work(struct work_struct *work)
> next = bio->bi_next;
> bio->bi_next = NULL;
>
> - /*
> - * Reset disk to the mpath node and resubmit to select a new
> - * path.
> - */
> - bio_set_dev(bio, head->disk->part0);
> submit_bio_noacct(bio);
> }
This hunk looks fine.
next prev parent reply other threads:[~2021-06-03 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:00 [PATCH v2] nvme: reset disk to the mpath node also when requeuing Daniel Wagner
2021-06-02 13:00 ` Daniel Wagner
2021-06-03 7:25 ` Christoph Hellwig [this message]
2021-06-03 7:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603072537.GA4718@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.