All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: lkp@lists.01.org
Subject: Re: [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement
Date: Thu, 03 Jun 2021 10:43:24 +0200	[thread overview]
Message-ID: <20210603084324.GC23647@quack2.suse.cz> (raw)
In-Reply-To: <CAOQ4uxjdtfriARxh_CiTxFi8=T6j065HtbJGnuAas7oyPNADKg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On Thu 03-06-21 09:57:15, Amir Goldstein wrote:
> On Thu, Jun 3, 2021 at 4:36 AM kernel test robot <oliver.sang@intel.com> wrote:
> >
> >
> >
> > Greeting,
> >
> > FYI, we noticed a 32.2% improvement of stress-ng.fanotify.ops_per_sec due to commit:
> >
> >
> > commit: a8b98c808eab3ec8f1b5a64be967b0f4af4cae43 ("fanotify: fix permission model of unprivileged group")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >
> >
> 
> I guess now we know what caused the reported regression:
> https://lore.kernel.org/lkml/20210511124632.GL24154(a)quack2.suse.cz/
> 
> I didn't know that capable() is so significant.

Yeah, I wouldn't guess either. Interesting.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: kernel test robot <oliver.sang@intel.com>,
	Jan Kara <jack@suse.cz>, Matthew Bobrowski <repnop@google.com>,
	Christian Brauner <christian.brauner@ubuntu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@lists.01.org, kbuild test robot <lkp@intel.com>,
	ying.huang@intel.com, feng.tang@intel.com,
	zhengjun.xing@linux.intel.com,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement
Date: Thu, 3 Jun 2021 10:43:24 +0200	[thread overview]
Message-ID: <20210603084324.GC23647@quack2.suse.cz> (raw)
In-Reply-To: <CAOQ4uxjdtfriARxh_CiTxFi8=T6j065HtbJGnuAas7oyPNADKg@mail.gmail.com>

On Thu 03-06-21 09:57:15, Amir Goldstein wrote:
> On Thu, Jun 3, 2021 at 4:36 AM kernel test robot <oliver.sang@intel.com> wrote:
> >
> >
> >
> > Greeting,
> >
> > FYI, we noticed a 32.2% improvement of stress-ng.fanotify.ops_per_sec due to commit:
> >
> >
> > commit: a8b98c808eab3ec8f1b5a64be967b0f4af4cae43 ("fanotify: fix permission model of unprivileged group")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >
> >
> 
> I guess now we know what caused the reported regression:
> https://lore.kernel.org/lkml/20210511124632.GL24154@quack2.suse.cz/
> 
> I didn't know that capable() is so significant.

Yeah, I wouldn't guess either. Interesting.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2021-06-03  8:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  1:53 [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement kernel test robot
2021-06-03  1:53 ` kernel test robot
2021-06-03  6:57 ` Amir Goldstein
2021-06-03  6:57   ` Amir Goldstein
2021-06-03  8:43   ` Jan Kara [this message]
2021-06-03  8:43     ` Jan Kara
2021-06-03 21:56     ` Matthew Bobrowski
2021-06-03 21:56       ` Matthew Bobrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603084324.GC23647@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.